[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108843221 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108837093 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108809796 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108785672 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108778378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108764164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108756250 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108755645 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108720888 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108720512 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -384,33 +379,13 @@ case class NullPropagation(conf:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108607884 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108530204 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108529414 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -384,33 +379,13 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108519047 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1122,7 +1119,7 @@ case class

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/17450 [SPARK-20121][SQL] simplify NullPropagation with NullIntolerant ## What changes were proposed in this pull request? Instead of iterating all expressions that can return null for null