[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19020 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19020 **[Test build #83515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83515/testReport)** for PR 19020 at commit

[GitHub] spark pull request #19020: [SPARK-3181] [ML] Implement huber loss for Linear...

2017-11-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19020#discussion_r149247240 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -208,6 +292,26 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request #19020: [SPARK-3181] [ML] Implement huber loss for Linear...

2017-11-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19020#discussion_r149247162 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -744,11 +754,20 @@ object LinearRegressionModel extends

[GitHub] spark issue #19660: [SPARK-18755][WIP][ML] Add Randomized Grid Search to Spa...

2017-11-06 Thread tengpeng
Github user tengpeng commented on the issue: https://github.com/apache/spark/pull/19660 @srowen You are absolutely right. That's the what 2 aims to accomplish. I believe implementing 1 & 2 is the goal, like what they did in sklearn. Need some discussions on design. ---

[GitHub] spark pull request #19020: [SPARK-3181] [ML] Implement huber loss for Linear...

2017-11-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19020#discussion_r149247042 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19020 **[Test build #83524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83524/testReport)** for PR 19020 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83523/testReport)** for PR 19674 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 Will take a look more tonight (KST). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 Here, I printed in amp-jenkins-worker-07 ``` PyPy - No Pandas Python 2.7 Pandas [0.16.0] Python 3.4 Pandas [0.19.2] PyPy - No PyArrow python 2.7 - No PyArrow

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83522/testReport)** for PR 19674 at commit

[GitHub] spark issue #19681: [SPARK-20652][sql] Store SQL UI data in the new app stat...

2017-11-06 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19681 For context: * Project link: https://issues.apache.org/jira/browse/SPARK-18085 * Upcoming PRs that build on this code: https://github.com/vanzin/spark/pulls Note I took this PR

[GitHub] spark issue #19681: [SPARK-20652][sql] Store SQL UI data in the new app stat...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19681 **[Test build #83521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83521/testReport)** for PR 19681 at commit

[GitHub] spark pull request #19681: [SPARK-20652][sql] Store SQL UI data in the new a...

2017-11-06 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/19681 [SPARK-20652][sql] Store SQL UI data in the new app status store. This change replaces the SQLListener with a new implementation that saves the data to the same store used by the SparkContext's

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 Thanks for quick response. Will try to produce a matrix for it while I am here. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19672 **[Test build #83520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83520/testReport)** for PR 19672 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19674 > @ueshin and @BryanCutler, do you guys maybe remember / know if / why Pandas and PyArrow are only installed in Python 3 in Jenkins? I'm afraid I don't know about those but I think Python 2

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 Will double check it by myself in any event. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83517/testReport)** for PR 19674 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83517/ Test PASSed. ---

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19553 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19679: [SPARK-20647][core] Port StorageTab to the new UI backen...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19679 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83509/ Test FAILed. ---

[GitHub] spark issue #19679: [SPARK-20647][core] Port StorageTab to the new UI backen...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19679 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17819: [SPARK-20542][ML][SQL] Add an API to Bucketizer that can...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17819 **[Test build #83519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83519/testReport)** for PR 17819 at commit

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-11-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19679: [SPARK-20647][core] Port StorageTab to the new UI backen...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19679 **[Test build #83509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83509/testReport)** for PR 19679 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 Oh BTW, I was trying to check the issue https://github.com/apache/spark/pull/19607#issuecomment-342119675 from top to bottom. ---

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149235352 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -99,11 +96,8 @@ class

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149237172 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -772,6 +783,14 @@

[GitHub] spark issue #17819: [SPARK-20542][ML][SQL] Add an API to Bucketizer that can...

2017-11-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17819 @MLnick Conflicts resolved. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149236687 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -58,8 +60,9 @@

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149236410 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala --- @@ -0,0 +1,166 @@ +/* +

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149235095 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala --- @@ -55,7 +55,9 @@ private[spark] class

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149235641 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -213,6 +216,14 @@

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149235832 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala --- @@ -0,0 +1,166 @@ +/* +

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r149235915 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala --- @@ -0,0 +1,166 @@ +/* +

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19674 @ueshin and @BryanCutler, do you guys maybe remember / know if / why Pandas and PyArrow are only installed in Python 3 in Jenkins? I was trying to check diff in Python2 and 3 as the

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/19680 I think it's important to restructure these summaries to inherit from the same traits, so different methods can be re-used. That structure has to live somewhere and there isn't really a logical

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83506/ Test PASSed. ---

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83506/testReport)** for PR 19553 at commit

[GitHub] spark issue #19678: [SPARK-20646][core] Port executors page to new UI backen...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19678 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19678: [SPARK-20646][core] Port executors page to new UI backen...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83505/ Test PASSed. ---

[GitHub] spark issue #19678: [SPARK-20646][core] Port executors page to new UI backen...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19678 **[Test build #83505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83505/testReport)** for PR 19678 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83516/ Test FAILed. ---

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83516/testReport)** for PR 19674 at commit

[GitHub] spark issue #19677: [SPARK-20645][core] Port environment page to new UI back...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83504/ Test PASSed. ---

[GitHub] spark issue #19677: [SPARK-20645][core] Port environment page to new UI back...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19677 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19677: [SPARK-20645][core] Port environment page to new UI back...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19677 **[Test build #83504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83504/testReport)** for PR 19677 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83512/ Test PASSed. ---

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83512/testReport)** for PR 19674 at commit

[GitHub] spark issue #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Sc...

2017-11-06 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19468 The plan looks good, I'm going to review another round recently, thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19672 **[Test build #83518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83518/testReport)** for PR 19672 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83517/testReport)** for PR 19674 at commit

[GitHub] spark issue #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19672 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19673: [SPARK-21640][SQL][PYTHON][R][FOLLOWUP] Add errorifexist...

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19673 cc @felixcheung, this is mostly R and Python changes. Would you mind taking a look please when you have some time? --- - To

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149228980 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala --- @@ -101,6 +101,20 @@ class TrainValidationSplit @Since("1.5.0")

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149227862 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -323,39 +338,40 @@ object CrossValidatorModel extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149226734 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -108,11 +111,19 @@ abstract class MLWriter extends BaseReadWrite with

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149225714 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -323,39 +338,40 @@ object CrossValidatorModel extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149217598 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -262,15 +273,26 @@ class CrossValidatorModel private[ml] (

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149226550 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -323,39 +338,40 @@ object CrossValidatorModel extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149227049 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -108,11 +111,19 @@ abstract class MLWriter extends BaseReadWrite with

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r149225109 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -262,15 +273,26 @@ class CrossValidatorModel private[ml] (

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83516/testReport)** for PR 19674 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/19680 Mima failures :) These APIs were all marked as experimental, which does give us some freedom to move them, though I know we prefer to avoid it. It's mainly complaining that we changed these classes

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19680 **[Test build #83513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83513/testReport)** for PR 19680 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19680 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83513/ Test FAILed. ---

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19680 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83511/testReport)** for PR 19674 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19674 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83511/ Test FAILed. ---

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19020 **[Test build #83515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83515/testReport)** for PR 19020 at commit

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19020 **[Test build #83514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83514/testReport)** for PR 19020 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19680 **[Test build #83513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83513/testReport)** for PR 19680 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83512/testReport)** for PR 19674 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19680 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19680 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83510/ Test FAILed. ---

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19680 **[Test build #83510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83510/testReport)** for PR 19680 at commit

[GitHub] spark issue #19674: [DO-NOT-MERGE] Investigate test failures related with SP...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19674 **[Test build #83511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83511/testReport)** for PR 19674 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19680 **[Test build #83510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83510/testReport)** for PR 19680 at commit

[GitHub] spark issue #19680: [SPARK-22641][ML] Refactor Spark ML model summaries

2017-11-06 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/19680 cc @yanboliang @srowen @WeichenXu123 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19680: [SPARK-22641][ML] Refactor Spark ML model summari...

2017-11-06 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19680#discussion_r149216754 --- Diff: mllib/src/main/scala/org/apache/spark/ml/summary/ClusteringSummary.scala --- @@ -30,11 +30,12 @@ import org.apache.spark.sql.{DataFrame, Row}

[GitHub] spark pull request #19680: [SPARK-22641][ML] Refactor Spark ML model summari...

2017-11-06 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/19680 [SPARK-22641][ML] Refactor Spark ML model summaries ## What changes were proposed in this pull request? JIRA: [SPARK-22641](https://issues.apache.org/jira/browse/SPARK-22461) This

[GitHub] spark issue #17980: [SPARK-20728][SQL] Make ORCFileFormat configurable betwe...

2017-11-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17980 Thank you for review, @jiangxb1987 . Yes. This is still required. I'll rebase this PR after #19651 . --- - To

[GitHub] spark issue #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words mode...

2017-11-06 Thread shubhamchopra
Github user shubhamchopra commented on the issue: https://github.com/apache/spark/pull/17673 @hhbyyh Thanks for your suggestions. Will try to incorporate these in a day or so. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19651 Thank you so much for review, @cloud-fan . I'll try to update the PR tonight. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-11-06 Thread shubhamchopra
Github user shubhamchopra commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r149215757 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request #19646: [SPARK-22417][PYTHON] Fix for createDataFrame fro...

2017-11-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19646#discussion_r149212192 --- Diff: python/pyspark/sql/session.py --- @@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema): data = [schema.toInternal(row) for

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

2017-11-06 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17702#discussion_r149211599 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -246,6 +246,18 @@ class SparkHadoopUtil extends Logging { if

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

2017-11-06 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17702#discussion_r149211542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -432,6 +433,32 @@ case class DataSource( }

[GitHub] spark pull request #19646: [SPARK-22417][PYTHON] Fix for createDataFrame fro...

2017-11-06 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19646#discussion_r149211050 --- Diff: python/pyspark/sql/session.py --- @@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema): data = [schema.toInternal(row)

[GitHub] spark pull request #19646: [SPARK-22417][PYTHON] Fix for createDataFrame fro...

2017-11-06 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19646#discussion_r149210042 --- Diff: python/pyspark/sql/session.py --- @@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema): data = [schema.toInternal(row)

[GitHub] spark issue #19646: [SPARK-22417][PYTHON] Fix for createDataFrame from panda...

2017-11-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19646 **[Test build #83508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83508/testReport)** for PR 19646 at commit

[GitHub] spark issue #19646: [SPARK-22417][PYTHON] Fix for createDataFrame from panda...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83508/ Test PASSed. ---

[GitHub] spark issue #19646: [SPARK-22417][PYTHON] Fix for createDataFrame from panda...

2017-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19646 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19623: [SPARK-22078][SQL] clarify exception behaviors fo...

2017-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19623 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

<    1   2   3   4   5   >