[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120269932 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -578,39 +583,29 @@ case class

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18159 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77765/ Test PASSed. ---

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77765/testReport)** for PR 18159 at commit

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18159 @cloud-fan The screenshot looks like: https://cloud.githubusercontent.com/assets/68855/26815029/614f13ba-4abc-11e7-9fbf-2248f0b7211d.png;> --- If your project is set up for it,

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120265375 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -578,39 +583,29 @@ case class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120261787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1105,19 +1105,26 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-06-05 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/17953 @cloud-fan Do you think it should be done in this pull? And where should add the filter, `CalalogImpl.createTable()` or `ExternalCatalog.createTable()` --- If your project is set up for it, you

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-06-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18108 @liu-zhaokun, I would request another test after manually checking the test failure at least. Does this succeed in your local without a problem? --- If your project is set up for it, you can

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-06-05 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18108 @srowen First,I think the tests which are related to hive went to fail doesn't my business,right? And then ,the test of "org.apache.spark.deploy.master.PersistenceEngineSuite" says

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18207 Yep. Right. Then, could you officially resolve [SPARK-12661](https://issues.apache.org/jira/browse/SPARK-12661), too? --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17953 **[Test build #77766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77766/testReport)** for PR 17953 at commit

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-06-05 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/17953 Ahh, found it. Re-generated the golden files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18207 OK great then we have officially deprecated it, haven't we? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18207 @rxin, as of #17355 Jenkins is using Python 2.7 sourced from a virtualenv instead of Python 2.6. That patch was merged into master before branch-2.2 was cut. --- If your project is set up for

[GitHub] spark issue #18205: [SPARK-20986] [SQL] Reset table's statistics after Prune...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18205 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18205: [SPARK-20986] [SQL] Reset table's statistics after Prune...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18205 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77763/ Test PASSed. ---

[GitHub] spark issue #18205: [SPARK-20986] [SQL] Reset table's statistics after Prune...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18205 **[Test build #77763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77763/testReport)** for PR 18205 at commit

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18159 @adrian-ionescu Thanks for the review. I've addressed the above comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77762/ Test PASSed. ---

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77762/testReport)** for PR 18199 at commit

[GitHub] spark issue #18209: [SPARK-20992][Scheduler] Add support for Nomad as a sche...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18209 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18159: [SPARK-20703][SQL] Associate metrics with data writes on...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77765/testReport)** for PR 18159 at commit

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18207 Jenkins runs with `['python2.7', 'python3.4', 'pypy']` only, doesn't it? Also, this is a major release cycle with the other big changes. For me, removing Python 2.6 is not proper with

[GitHub] spark pull request #18209: [SPARK-20992][Scheduler] Add support for Nomad as...

2017-06-05 Thread barnardb
GitHub user barnardb opened a pull request: https://github.com/apache/spark/pull/18209 [SPARK-20992][Scheduler] Add support for Nomad as a scheduler backend ## What changes were proposed in this pull request? Adds support for [Nomad](https://github.com/hashicorp/nomad) as a

[GitHub] spark issue #16820: [SPARK-19471] AggregationIterator does not initialize th...

2017-06-05 Thread yangw1234
Github user yangw1234 commented on the issue: https://github.com/apache/spark/pull/16820 Sorry I could not find time to finish this pr recently. Close it for now. If you need this fix, please feel free to base on it and finish it. --- If your project is set up for it, you can reply

[GitHub] spark pull request #16820: [SPARK-19471] AggregationIterator does not initia...

2017-06-05 Thread yangw1234
Github user yangw1234 closed the pull request at: https://github.com/apache/spark/pull/16820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18193: [SPARK-15616] [SQL] CatalogRelation should fallback to H...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18193 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18193: [SPARK-15616] [SQL] CatalogRelation should fallback to H...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18193 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77764/ Test PASSed. ---

[GitHub] spark issue #18193: [SPARK-15616] [SQL] CatalogRelation should fallback to H...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18193 **[Test build #77764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77764/testReport)** for PR 18193 at commit

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18207 I believe we still support Python 2.6, given Jenkins runs 2.6... There seems to be no point in removing that support this late in the release cycle. --- If your project is set up for it, you can

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18192 I guess it is discouraged to move codes alone as explained but wouldn't it be better to merge this rather than close if this looks better in any way and the change is safe? --- If your

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-05 Thread zhengcanbin
Github user zhengcanbin commented on the issue: https://github.com/apache/spark/pull/18192 @jerryshao Should I close this issue ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17723 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77761/ Test PASSed. ---

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17723 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17723 **[Test build #77761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77761/testReport)** for PR 17723 at commit

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-05 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18192 The change should be safe, but usually we don't do such code structure refactoring alone without a strong reason, so I'm neutral of this change. --- If your project is set up for it, you can

[GitHub] spark issue #18192: [SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from S...

2017-06-05 Thread zhengcanbin
Github user zhengcanbin commented on the issue: https://github.com/apache/spark/pull/18192 @jerryshao It's a tiny change for more reasonable code structure. There exists three `ShuffleWriter ` implementations, we first use the helper method `SortShuffleWriter#shouldBypassMergeSort`

[GitHub] spark issue #18193: [SPARK-15616] [SQL] CatalogRelation should fallback to H...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18193 **[Test build #77764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77764/testReport)** for PR 18193 at commit

[GitHub] spark issue #18205: [SPARK-20986] [SQL] Reset table's statistics after Prune...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18205 **[Test build #77763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77763/testReport)** for PR 18205 at commit

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120244321 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -199,13 +199,52 @@ class RateStreamSource(

[GitHub] spark pull request #18205: [SPARK-20986] [SQL] Reset table's statistics afte...

2017-06-05 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/18205#discussion_r120244237 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala --- @@ -66,4 +67,33 @@ class

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120243896 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -730,4 +730,58 @@ public void testToLong() throws

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120243912 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -502,69 +503,232 @@ case class

[GitHub] spark pull request #18208: [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should ...

2017-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120243671 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -578,39 +583,29 @@ case class

[GitHub] spark issue #18208: [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a Ti...

2017-06-05 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18208 Thanks. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77762/testReport)** for PR 18199 at commit

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120243433 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120243013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,58 +503,63 @@ case class

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18207 Thank you for confirming, @JoshRosen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18207 As of #17355 we no longer test against Python 2.6. That doesn't mean that 2.6 won't work today, but there's nothing stopping 2.6 support from breaking in a future 2.2.x release because we are no

[GitHub] spark issue #18207: [MINOR][DOC] Update deprecation notes on Python/Hadoop/S...

2017-06-05 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/18207 /cc @joshrosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120236128 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -193,6 +197,21 @@ object

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120236059 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -100,6 +103,7 @@ object

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120235938 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -193,6 +197,21 @@ object

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120235619 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -193,6 +197,21 @@ object

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17955 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77759/ Test PASSed. ---

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17955 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17955 **[Test build #77759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77759/testReport)** for PR 17955 at commit

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120234538 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -100,6 +103,7 @@ object

[GitHub] spark pull request #18029: [SPARK-20168][WIP][DStream] Add changes to use ki...

2017-06-05 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r120234200 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -100,6 +103,7 @@ object

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77760/ Test PASSed. ---

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77760/testReport)** for PR 18199 at commit

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77756/ Test PASSed. ---

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18083 **[Test build #77756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77756/testReport)** for PR 18083 at commit

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77758/ Test PASSed. ---

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17723: [SPARK-20434][YARN][CORE] Move kerberos delegation token...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17723 **[Test build #77761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77761/testReport)** for PR 17723 at commit

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18083 **[Test build #77758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77758/testReport)** for PR 18083 at commit

[GitHub] spark pull request #18098: [SPARK-16944][Mesos] Improve data locality when l...

2017-06-05 Thread gpang
Github user gpang commented on a diff in the pull request: https://github.com/apache/spark/pull/18098#discussion_r120231509 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -502,6 +521,25 @@

[GitHub] spark issue #18203: [SPARK-20954][SQL] Simple `DESCRIBE` result should be co...

2017-06-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18203 Hi, @gatorsmile and @cloud-fan . Could you review this PR when you have sometime? This will recover the incompatible changes at Spark 2.2.0. --- If your project is set up for it, you

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120228866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -503,58 +503,63 @@ case class

[GitHub] spark issue #18208: [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a Ti...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18208 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77755/ Test PASSed. ---

[GitHub] spark issue #18208: [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a Ti...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18208 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18208: [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a Ti...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18208 **[Test build #77755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77755/testReport)** for PR 18208 at commit

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77757/ Test PASSed. ---

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77757/testReport)** for PR 18199 at commit

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120225704 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

2017-06-05 Thread ash211
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17935 @JoshRosen what was the other type of database you were using? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120222903 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120222158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120220998 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -746,10 +751,6 @@ public void trim() {

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120219958 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120219455 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,240 @@ +/* + * Licensed to the

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120218796 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -511,7 +511,7 @@ public UTF8String trim() { }

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120217172 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2658,17 +2658,17 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-05 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r120217123 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2658,17 +2658,17 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.S...

2017-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.Streamin...

2017-06-05 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18180 Merging this to master and 2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18176: [SPARK-20952] Make TaskContext an InheritableTheadLocal

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18176 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18176: [SPARK-20952] Make TaskContext an InheritableTheadLocal

2017-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77753/ Test PASSed. ---

[GitHub] spark issue #18176: [SPARK-20952] Make TaskContext an InheritableTheadLocal

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18176 **[Test build #77753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77753/testReport)** for PR 18176 at commit

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r120212469 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/RateSourceProvider.scala --- @@ -0,0 +1,208 @@ +/* + * Licensed to the

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77760/testReport)** for PR 18199 at commit

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-06-05 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17955 LGTM, also cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   4   >