Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16575
@robert3005 why is this needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16581#discussion_r96121284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -86,6 +86,19 @@ trait PredicateHelper
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16608
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275903
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -300,7 +311,7 @@ abstract class ExplodeBase
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -233,11 +244,11 @@ abstract class ExplodeBase
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96276717
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2879,6 +2888,15 @@ object functions {
def posexplode(e: Column
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96276562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -160,9 +160,20 @@ case class GenerateExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96276812
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -175,6 +175,9 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96276686
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2871,6 +2871,15 @@ object functions {
def explode(e: Column): Column
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -323,7 +334,7 @@ case class Explode(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -204,6 +204,17 @@ case class Stack(children: Seq
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -175,6 +175,9 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -369,3 +380,5 @@ case class Inline(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96323578
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/ExpressionToSQLSuite.scala
---
@@ -102,6 +102,9 @@ class ExpressionToSQLSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96324322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -508,4 +511,12 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96323956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -104,7 +104,10 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96324372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -508,4 +511,12 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96324395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -508,4 +511,12 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96323864
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -204,6 +204,17 @@ case class Stack(children: Seq
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96323976
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2879,6 +2888,15 @@ object functions {
def posexplode(e: Column
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15302
@dongjoon-hyun I have taken a quick look. Shouldn't we just use Expressions
for filtering partitions?
---
If your project is set up for it, you can reply to this email and have your
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
@tejasapatil I have triggered a new build. I'll merge this as soon as it
completes successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15302
@dongjoon-hyun I think that `AlterTableDropPartitionCommand` just should
take a set of catalyst `Expression`s instead of a `PartitionRangeSpec`.
I have added a few things the `Catalog
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15337
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15337
@seyfe could we add a little test to see if this is working?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15322
Merging to master/2.0. Thanks for the reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15345
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15348
[SPARK-17758][SQL] Last returns wrong result in case of empty partition
## What changes were proposed in this pull request?
The result of the `Last` function can be wrong when the last
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15345
LGTM - merging to 2.0. Thanks!
Could you close this PR? (our merge tooling does not close backports
automatically)
---
If your project is set up for it, you can reply to this email and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15348#discussion_r81887208
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/LastTestSuite.scala
---
@@ -0,0 +1,105
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15346#discussion_r81821454
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -593,6 +593,14 @@ colTypeList
;
colType
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15346#discussion_r81887963
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -67,9 +86,331 @@ class SparkSqlParserSuite extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15319
cc @sameeragarwal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15044
@kiszk this seems nice, is this ready for review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15044
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15355
[SPARK-17782][STREAMING]Disable Kafka 010 pattern based subscription test.
## What changes were proposed in this pull request?
This PR disables the `pattern based subscription` test in the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15355
cc @koeninger any idea why this flaky?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14828
@gatorsmile does this LGTY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15357#discussion_r81900460
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -265,7 +265,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15357
LGTM - merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15044
@kiszk this PR is. It is much more concise!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82056906
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82058100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15348
You cannot. Last is not deterministic outside of ordered window functions.
The only thing is that you can have inconsistent results if the last physical
partition happens to be an empty one
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14912
@viirya TBH this seems hacky to me and I'd rather not merge this. I think
we should just focus on having proper CNF in the optimizer. I am sorry to
disappoint you.
---
If your project i
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14828
@gatorsmile we tried that in Spark 2.0. But it turns out that this is quite
confusing to an end-user, and that this is problematic in case of testing (due
to small numeric differences
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15363
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15371
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell closed the pull request at:
https://github.com/apache/spark/pull/15323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15323
closing this in favor of https://github.com/apache/spark/pull/1/files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82244393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15351
@dongjoon-hyun it LGTM. It is just a rather big patch to backport, for
something that is not a bug fix. But I'll merge it.
---
If your project is set up for it, you can reply to this emai
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15351
Merging to 2.0. @dongjoon-hyun can you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15355
I have re-enables the kafka test. This PR now only contains a change to
build infrastructure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15390
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15333
Merging to master. Thanks for commenting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15297
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15403#discussion_r82506382
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala ---
@@ -29,12 +28,23 @@ sealed trait IdentifierWithDatabase
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15403
@jiangxb1987 This looks pretty good.
What is the problem `getTable` and `getFunction`? Could you give an
example? assume you are talking about the
`org.apache.spark.sql.catalog.Catalog
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15403
LGTM - merging to master/2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15346
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14788
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14788
LGTM - I'll merge as soon as tests complete successfully
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15316#discussion_r82545437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,6 +43,11 @@ class AnalysisException protected[sql
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82650345
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2548,16 +2548,20 @@ object functions {
def to_date(e: Column
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15316#discussion_r82650465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,6 +43,11 @@ class AnalysisException protected[sql
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15416#discussion_r82664096
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -298,10 +298,11 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r82726273
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -53,7 +53,15 @@ import org.apache.spark.util.Utils
private[sql
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15412
LGTM - merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r82728542
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -53,7 +53,15 @@ import org.apache.spark.util.Utils
private[sql
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r82743571
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -53,7 +53,15 @@ import org.apache.spark.util.Utils
private[sql
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15448
Could you try to fix this by adding implicit casting to the `GetMapValue`
(make it extend `ImplicitCastInputTypes` instead of `ExpectsInputTypes`)?
---
If your project is set up for it, you
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15448
Also add unit tests please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r82944265
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13065
cc @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15457
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15457
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r83280122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +931,26 @@ case class ToDate
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15464
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r83300104
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala
---
@@ -61,4 +63,39 @@ class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15416
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15487#discussion_r83470770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -29,15 +29,18 @@ import
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15512
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15316
LGTM. Merging to master/2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15316
@gatorsmile I cannot merge this 2.0. Can you open a backport for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15542
[SPARK-17996][SQL] Fix unqualified catalog.getFunction(...)
## What changes were proposed in this pull request?
Currently an unqualified `getFunction(..)`call returns a wrong result; the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15542
cc @srinathshankar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15544#discussion_r83993309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -142,319 +84,37 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84007872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -488,23 +488,13 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84001582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84012469
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -518,59 +517,64 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003737
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84005447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -281,9 +294,11 @@ class Analyzer(
s
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84006017
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -488,23 +488,13 @@ class AstBuilder extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16909
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17244#discussion_r106363391
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -52,62 +63,79 @@ private[spark] class TaskContextImpl(
@volatile
201 - 300 of 4178 matches
Mail list logo
