[GitHub] spark pull request: [SPARK-6337][Documentation, SQL]Spark 1.3 doc ...

2015-03-20 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5112 [SPARK-6337][Documentation, SQL]Spark 1.3 doc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark spark_1.3_doc_fixes

[GitHub] spark pull request: [SPARK-6445][SQL]Handle 'filesystem closed' ex...

2015-03-21 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5117#issuecomment-84286644 please merge only this file : core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala , which is modified for IOException handling --- If your

[GitHub] spark pull request: [SPARK-6445][SQL]Handle 'filesystem closed' ex...

2015-03-21 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5117 [SPARK-6445][SQL]Handle 'filesystem closed' exception on exiting spark-sql console You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc

[GitHub] spark pull request: [SPARK-6448][Core]Added exception log in Histo...

2015-03-21 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5123 [SPARK-6448][Core]Added exception log in History server logError You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-6448][Core]Added exception log in Histo...

2015-03-22 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5123#issuecomment-84530741 Due to JIRA sync issue, didn't see your PR. I'll close mine. On Mar 22, 2015 9:06 AM, Ryan Williams notificati...@github.com wrote: Weird, I think

[GitHub] spark pull request: [SPARK-6448][Core]Added exception log in Histo...

2015-03-22 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/5123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6223][SQL] Fix build warning- enable im...

2015-03-09 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/4948 [SPARK-6223][SQL] Fix build warning- enable implicit value scala.language.existentials visible You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] spark pull request: [SPARK-6223][SQL] Fix build warning- enable im...

2015-03-09 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/4948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6317][SQL]Fixed HIVE console startup is...

2015-03-13 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5011 [SPARK-6317][SQL]Fixed HIVE console startup issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark HIVE_console_startupError

[GitHub] spark pull request: [SPARK-6317][SQL]Fixed HIVE console startup is...

2015-03-13 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5011#issuecomment-79045419 If DSL support is already removed from 1.3 release, I shall modify the file and submit it. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6317][SQL]Fixed HIVE console startup is...

2015-03-13 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5011#issuecomment-78972452 I'll update it now. Thanks On Mar 13, 2015 6:45 PM, Sean Owen notificati...@github.com wrote: LGTM, except the new import should sort one line below now

[GitHub] spark pull request: [SPARK-6178][Shuffle] Removed unused imports

2015-03-05 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/4900#discussion_r25847020 --- Diff: network/common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -17,13 +17,10 @@ package org.apache.spark.network

[GitHub] spark pull request: [SPARK-6178][Shuffle] Removed unused imports

2015-03-04 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/4900 [SPARK-6178][Shuffle] Removed unused imports Author: Vinod K C vinod...@huawei.com You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc

[GitHub] spark pull request: [SPARK-6178][Shuffle] Removed unused imports

2015-03-05 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/4900#discussion_r25849888 --- Diff: network/shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java --- @@ -17,6 +17,10 @@ package

[GitHub] spark pull request: [SPARK-7055][SQL]Use correct ClassLoader for J...

2015-04-22 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5633#issuecomment-95446962 @marmbrus, Have you tried MySQL and Postgres integration tests for this PR ? https://github.com/apache/spark/pull/5543 --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-7055][SQL]Use correct ClassLoader for J...

2015-04-22 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5633 [SPARK-7055][SQL]Use correct ClassLoader for JDBC Driver in JDBCRDD.getConnector You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-6928][Spark Shell]Fixed spark-shell exc...

2015-04-22 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/5521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6928][Spark Shell]Fixed spark-shell exc...

2015-04-22 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5521#issuecomment-95148140 Closing this PR based on review comments from Sean Owen. Thanks for the clarification. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7103][Spark Core]Verify patitionors are...

2015-04-24 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/5678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-7103][Spark Core]Verify patitionors are...

2015-04-24 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5678#issuecomment-95839288 there is another PR 5679 with better fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7103][Spark Core]Verify patitionors are...

2015-04-23 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5678 [SPARK-7103][Spark Core]Verify patitionors are available in all RDDs used in PartitionerAwareUnionRDD You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5974 [SPARK-7438][Spark Core]Fixed validation of relativeSD in countApproxDistinct You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100086226 Removed relativeSD validation in python.Validation is done in scala --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7489][Spark Shell]Spark shell crashes w...

2015-05-08 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/6013#issuecomment-100310097 @andrewor14 , Jenkins is not triggering test build. Can you please comment now to start build? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-7489][Spark Shell]Spark shell crashes w...

2015-05-08 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/6013 [SPARK-7489][Spark Shell]Spark shell crashes when compiled with scala 2.11 Spark shell crashes when compiled with scala 2.11 and SPARK_PREPEND_CLASSES=true There is a similar Resolved

[GitHub] spark pull request: [SPARK-7470] [SQL] Spark shell SQLContext cras...

2015-05-09 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5997#issuecomment-100585781 @marmbrus , PR https://github.com/apache/spark/pull/6013 handled it --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6928][Spark Shell]Fixed spark-shell exc...

2015-04-15 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5521 [SPARK-6928][Spark Shell]Fixed spark-shell exception after :replay command On replay command , Spark REPL calls reset method before playing the previous commands.Since reset method currently

[GitHub] spark pull request: [SPARK-6928][Spark Shell]Fixed spark-shell exc...

2015-04-15 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/5521#discussion_r28406327 --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkIMain.scala --- @@ -978,15 +978,32 @@ import org.apache.spark.annotation.DeveloperApi

[GitHub] spark pull request: [SPARK-6733][ Scheduler]Added scala.language.e...

2015-04-06 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5384 [SPARK-6733][ Scheduler]Added scala.language.existentials You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-6733][ Scheduler]Added scala.language.e...

2015-04-07 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5384#issuecomment-90407297 I've not raise in JIRA, Reporter is Raymond Tay --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6445][SQL]Handle 'filesystem closed' ex...

2015-04-08 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/5117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-8628][SQL]Race condition in AbstractSpa...

2015-06-25 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7015 [SPARK-8628][SQL]Race condition in AbstractSparkSQLParser.parse Added synchronization in 'initialize' method You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [SPARK-8628][SQL]Race condition in AbstractSpa...

2015-06-26 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7015#issuecomment-115572040 Python test failure in unrelated module mllib File /home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/mllib/classification.py, line 106

[GitHub] spark pull request: [SPARK-8628][SQL]Race condition in AbstractSpa...

2015-06-25 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7015#issuecomment-115492255 @smola ,I've updated the code.Can you please check whether that fix solves the issue ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-8787][SQL]Changed parameter order of @d...

2015-07-02 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7183 [SPARK-8787][SQL]Changed parameter order of @deprecated in package object sql You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-8787][SQL]Changed parameter order of @d...

2015-07-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/7183#discussion_r33763973 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala --- @@ -46,6 +46,6 @@ package object sql { * Type alias for [[DataFrame]]. Kept

[GitHub] spark pull request: [SPARK-8787][SQL]Changed parameter order of @d...

2015-07-02 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7183#issuecomment-117957848 Added description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8628][SQL]Race condition in AbstractSpa...

2015-06-30 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/7015#discussion_r33558094 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/AbstractSparkSQLParser.scala --- @@ -30,12 +30,14 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10016][ML]Stored broadcast var in a pri...

2015-08-16 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8233 [SPARK-10016][ML]Stored broadcast var in a private var You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_SPARK-10016

[GitHub] spark pull request: [SPARK-8636][SQL] Fix equalNullSafe comparison

2015-06-26 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7040#issuecomment-115654691 Ok, I'll update that test suite. @smola , In predicates.scala, eval method of case class EqualNullSafe has similar if (l == null r == null) check , shall I

[GitHub] spark pull request: [SPARK-8636][SQL] Fix equalNullSafe comparison

2015-06-26 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7040 [SPARK-8636][SQL] Fix equalNullSafe comparison You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_CaseKeyWhen_equalNullSafe

[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...

2015-07-28 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-125820807 @mengxr , I've added message in JIRA page from my JIRA account. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8636][SQL] Fix equalNullSafe comparison

2015-07-13 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/7040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-13 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/7364#discussion_r34534208 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -727,40 +727,44 @@ private[master] class Master( def

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-14 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/7364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-14 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7364#issuecomment-121303647 Closing this incomplete PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...

2015-07-13 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7367 [SPARK-8991][ML]Update SharedParamsCodeGen's Generated Documentation Removed private[ml] from Generated documentation You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...

2015-07-09 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7325 [SPARK-8919][Documentation, MLlib]Added @since tags to mllib.recommendation You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark

[GitHub] spark pull request: [SPARK-8636][SQL] Fix equalNullSafe comparison

2015-07-09 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/7040#discussion_r34328058 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala --- @@ -296,9 +295,7 @@ case class CaseKeyWhen(key

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-12 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7364 [SPARK-8761][Deploy]Added synchronization in removeApplication Master.removeApplication is not thread-safe. But it's called both in the message loop of Master and MasterPage.handleAppKillRequest

[GitHub] spark pull request: [SPARK-10199][MLlib]Avoid using reflections fo...

2015-08-28 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8507 [SPARK-10199][MLlib]Avoid using reflections for parquet model save You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_SPARK

[GitHub] spark pull request: [SPARK-10016][ML]Stored broadcast var in a pri...

2015-08-24 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8233#issuecomment-134471497 Sure, I'll update the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10199][MLlib]Avoid using reflections fo...

2015-09-01 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8507#discussion_r38410341 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala --- @@ -159,19 +159,25 @@ object GaussianMixtureModel extends

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8565#discussion_r38507995 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -278,7 +278,8 @@ class DenseMatrix @Since("

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8565 [SPARK-10414][MLlib]Fix hashcode issues in MLLib Added/Updated hashcode methods in 3 classes You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-04 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8507#issuecomment-137686626 @feynmanliang , I've removed case classes used for schema inference. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-04 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8507#discussion_r38733907 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala --- @@ -125,16 +126,19 @@ object KMeansModel extends Loader[KMeansModel

[GitHub] spark pull request: [SPARK-10468][ MLlib ]Verify schema before Dat...

2015-09-06 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8636 [SPARK-10468][ MLlib ]Verify schema before Dataframe select API call Loader.checkSchema was called to verify the schema after dataframe.select(...). Schema verification should be done before

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-06 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8565#issuecomment-138167561 Closing this PR, as there is already an existing JIRA & PR on same issue --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-06 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/8565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-02 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8507#issuecomment-137312813 @feynmanliang , fixed your review comments. Could you please verify it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10430][SPARK-10430]Added hashCode metho...

2015-09-02 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8581 [SPARK-10430][SPARK-10430]Added hashCode methods in AccumulableInfo and RDDOperationScope You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8565#discussion_r38609166 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -278,7 +278,8 @@ class DenseMatrix @Since("

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8565#discussion_r38522537 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -278,7 +278,8 @@ class DenseMatrix @Since("

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8565#discussion_r38514784 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -278,7 +278,8 @@ class DenseMatrix @Since("

[GitHub] spark pull request: [SPARK-10516][ MLlib]Added values property in ...

2015-09-16 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8682#issuecomment-140645936 Sure I'll work on SPARK-10631 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10575][Spark Core]Wrapped RDD.takeSampl...

2015-09-12 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8730 [SPARK-10575][Spark Core]Wrapped RDD.takeSample with Scope You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_takesample_return

[GitHub] spark pull request: [SPARK-10016][ML]Stored broadcast var in a pri...

2015-09-12 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/8233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10516][ MLlib]Added values property in ...

2015-09-09 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8682 [SPARK-10516][ MLlib]Added values property in DenseVector You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_SPARK-10516

[GitHub] spark pull request: [SPARK-10575][Spark Core]Wrapped RDD.takeSampl...

2015-09-13 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8730#issuecomment-139956635 Can we retest?, it is failing in unrelated module --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-10575][Spark Core]Wrapped RDD.takeSampl...

2015-09-13 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8730#issuecomment-139957047 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-08 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/8507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-08 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8507#issuecomment-138789894 Closing this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10631][Documentation, MLlib, PySpark]Ad...

2015-09-19 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8834 [SPARK-10631][Documentation, MLlib, PySpark]Added documentation for few APIs There are some missing API docs in pyspark.mllib.linalg.Vector (including DenseVector and SparseVector). We should add

[GitHub] spark pull request #18771: [SPARK-21478][SQL] Avoid unpersisting related Dat...

2017-07-29 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/18771 [SPARK-21478][SQL] Avoid unpersisting related Datasets ## What changes were proposed in this pull request? While unpersisting a dataset, only unpersist and remove that datasets's plan from

[GitHub] spark pull request #18771: [SPARK-21478][SQL] Avoid unpersisting related Dat...

2017-07-30 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/18771#discussion_r130234632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -114,13 +114,13 @@ class CacheManager extends Logging

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/18852 [SPARK-21588][SQL] SQLContext.getConf(key, null) should return null ## What changes were proposed in this pull request? In SQLContext.get(key,null) for a key that is not defined

[GitHub] spark pull request #18771: [SPARK-21478][SQL] Avoid unpersisting related Dat...

2017-07-30 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/18771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #18880: [SPARK-21665][Core]Need to close resources after ...

2017-08-08 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/18880 [SPARK-21665][Core]Need to close resources after use ## What changes were proposed in this pull request? Resources in Core - SparkSubmitArguments.scala, Spark-launcher

[GitHub] spark issue #18880: [SPARK-21665][Core]Need to close resources after use

2017-08-09 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/18880 retest this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131519921 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -808,6 +808,12 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request #19007: [SPARK-21783][SQL]Turn on ORC filter push-down by...

2017-08-20 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/19007 [SPARK-21783][SQL]Turn on ORC filter push-down by default ## What changes were proposed in this pull request? Turned on ORC filter push-down option by default

[GitHub] spark pull request #19007: [SPARK-21783][SQL]Turn on ORC filter push-down by...

2017-08-20 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/19007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #19007: [SPARK-21783][SQL]Turn on ORC filter push-down by defaul...

2017-08-20 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19007 Ok , I'm closing my PR. Now a days, Spark JIRA is not showing PR status.That is why I missed your PR. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

2017-08-20 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/19008 [SPARK-21756][SQL]Add JSON option to allow unquoted control characters ## What changes were proposed in this pull request? This patch adds allowUnquotedControlChars option in JSON data

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

2017-08-21 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19008#discussion_r134227248 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala --- @@ -72,6 +72,21 @@ class

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

2017-08-21 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19008#discussion_r134227247 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala --- @@ -72,6 +72,21 @@ class

[GitHub] spark issue #19008: [SPARK-21756][SQL]Add JSON option to allow unquoted cont...

2017-08-23 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19008 @rxin , Sure, I'll update it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 to branc...

2017-11-24 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19809 Thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

2017-11-24 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/19809 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 to branc...

2017-11-23 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19809 ping @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

2017-11-24 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19809#discussion_r152922206 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -700,12 +700,7 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

2017-11-23 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/19809 [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 to branch-2.2 ## What changes were proposed in this pull request? A followup of > https://github.com/apache/spark/pull/19

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19779 @gatorsmile , @cloud-fan and @dongjoon-hyun Thanks for the review comments and guidence Sure, I'll submit a separate PR for backporting it to 2.2

[GitHub] spark issue #19795: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Backport PR...

2017-11-22 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19795 Thank you --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19795: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Back...

2017-11-22 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/19795 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19795: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Back...

2017-11-22 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/19795 [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Backport PR 19779 to branch-2.2 - Support writing to Hive table which uses Avro schema url 'avro.schema.url' ## What changes were proposed

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-18 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/19779 [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support writing to Hive table which uses Avro schema url 'avro.schema.url' ## What changes were proposed in this pull request? Support writing

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-20 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r152067290 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -841,6 +841,76 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-19 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/19779#discussion_r151902033 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveFileFormat.scala --- @@ -89,6 +90,8 @@ class HiveFileFormat(fileSinkConf

  1   2   >