[GitHub] spark pull request: [SPARK-7838] [STREAMING] Set scope for kinesis...

2015-05-23 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/6369#issuecomment-104940840 good catch, TD. didn't even know this concept existed. do kafka or other impls need this? should we add this to the Custom Receiver guide? --- If your project

[GitHub] spark pull request: [SPARK-7788] Made KinesisReceiver.onStart() no...

2015-05-22 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6348#discussion_r30934351 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -126,8 +131,19 @@ private[kinesis] class

[GitHub] spark pull request: [SPARK-7788] Made KinesisReceiver.onStart() no...

2015-05-22 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/6348#issuecomment-104787031 otherwise, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7788] Made KinesisReceiver.onStart() no...

2015-05-22 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/6348#issuecomment-104845837 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656] Ability t...

2015-05-21 Thread cfregly
Github user cfregly closed the pull request at: https://github.com/apache/spark/pull/5882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775126 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -16,29 +16,75 @@ */ package

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775061 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala --- @@ -190,7 +198,7 @@ private[kinesis] object

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775051 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala --- @@ -116,7 +124,7 @@ private[kinesis] class

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775347 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -79,19 +181,116 @@ object KinesisUtils

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775370 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -79,19 +181,116 @@ object KinesisUtils

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30774982 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -59,92 +60,103 @@ import

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30774960 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -59,92 +60,103 @@ import

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775257 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -79,19 +181,116 @@ object KinesisUtils

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775310 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -79,19 +181,116 @@ object KinesisUtils

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775220 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -48,28 +94,84 @@ object KinesisUtils

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775440 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala --- @@ -40,6 +40,7 @@ import

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-21 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/6147#discussion_r30775176 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -16,29 +16,75 @@ */ package

[GitHub] spark pull request: [SPARK-7722] [STREAMING] Added Kinesis to styl...

2015-05-21 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/6325#issuecomment-104409718 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656][SPARK-767...

2015-05-17 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/6147#issuecomment-102827199 @tdas: Looks like you forgot to bring over the docs/streaming-kinesis-integration.md and 2 examples (JavaKinesisWordCountASL and KinesisWordCountASL) changes from my

[GitHub] spark pull request: [SPARK-6514][SPARK-5960][SPARK-6656] Ability t...

2015-05-03 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/5882 [SPARK-6514][SPARK-5960][SPARK-6656] Ability to specify DynamoDB region ... ...separate from Kinesis region (or use the same), ability to pass in AWS credentials and not rely on EC2 IAM roles

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390431 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -82,15 +82,19 @@ private[kinesis] class

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390749 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -59,9 +61,10 @@ object KinesisUtils

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391705 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -39,6 +39,7 @@ object KinesisUtils

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390150 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -24,8 +24,7 @@ import

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390315 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -82,15 +82,19 @@ private[kinesis] class

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390948 --- Diff: docs/streaming-kinesis-integration.md --- @@ -32,7 +32,7 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390980 --- Diff: docs/streaming-kinesis-integration.md --- @@ -67,6 +67,8 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390951 --- Diff: docs/streaming-kinesis-integration.md --- @@ -44,7 +44,7 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391597 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -36,18 +36,19 @@ import

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391619 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -39,6 +39,7 @@ object KinesisUtils

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390832 --- Diff: extras/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java --- @@ -34,7 +34,7 @@ public void

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390845 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala --- @@ -113,7 +113,7 @@ private object

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390844 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390830 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala --- @@ -86,7 +86,7 @@ class KinesisReceiverSuite

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391631 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -70,6 +72,7 @@ object KinesisUtils

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390679 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -16,6 +16,7 @@ */ package

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28391083 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28391006 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-06 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/5375#issuecomment-90308088 @srowen @kopiczko This is part of a larger effort to overhaul Kinesis-based streaming slated for 1.4. Lots of API changes including region, AWS credentials

[GitHub] spark pull request: clean up println's

2015-03-23 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/5153 clean up println's You can merge this pull request into a Git repository by running: $ git pull https://github.com/cfregly/spark ml-docs Alternatively you can review and apply these changes

[GitHub] spark pull request: [SPARK-5187][SQL] Fix caching of tables with H...

2015-01-09 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/3987#issuecomment-69423882 lgtm. as we just discussed, this is the same code path as SchemaRDD.cache(), so no need for additional tests. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-3639] [Streaming] [Kinesis] Allow users...

2014-12-07 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/3092#issuecomment-65963749 @tdas the summary is here: https://issues.apache.org/jira/browse/SPARK-3640?focusedCommentId=14204334page=com.atlassian.jira.plugin.system.issuetabpanels:comment

[GitHub] spark pull request: [SPARK-3639] [Streaming] [Kinesis] Allow users...

2014-11-09 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/3092#issuecomment-62340672 @aniketbhatnagar it looks like the title of this PR should reference SPARK-3640 instead. can you change this? thx. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-3639] [Streaming] [Kinesis] Allow users...

2014-11-09 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/3092#issuecomment-62340980 @tdas i've updated SPARK-3640 with an offline discussion between aniket and me. we may not need to integrate this PR. waiting for aniket to confirm. thanks

[GitHub] spark pull request: [SPARK-1981][Streaming] Updated kinesis docs a...

2014-09-08 Thread cfregly
Github user cfregly closed the pull request at: https://github.com/apache/spark/pull/2306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-1981][Streaming] Updated kinesis docs a...

2014-09-06 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/2306 [SPARK-1981][Streaming] Updated kinesis docs and added architecture diagram You can merge this pull request into a Git repository by running: $ git pull https://github.com/cfregly/spark

[GitHub] spark pull request: [SPARK-1981] updated streaming-kinesis.md

2014-08-03 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/1757 [SPARK-1981] updated streaming-kinesis.md fixed markup, separated out sections more-clearly, more thorough explanations You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727578 --- Diff: bin/run-example --- @@ -29,7 +29,9 @@ if [ -n $1 ]; then else echo Usage: ./bin/run-example example-class [example-args] 12 echo

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727580 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727587 --- Diff: extras/kinesis-asl/pom.xml --- @@ -0,0 +1,99 @@ +?xml version=1.0 encoding=UTF-8? +!-- +~ Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727688 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727694 --- Diff: dev/audit-release/sbt_app_kinesis/build.sbt --- @@ -0,0 +1,30 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-02 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15727693 --- Diff: dev/audit-release/audit_release.py --- @@ -105,7 +105,7 @@ def get_url(url): spark-core, spark-bagel, spark-mllib, spark-streaming, spark

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-01 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15685837 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessorUtils.scala --- @@ -0,0 +1,79

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-01 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15685828 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisStringRecordSerializer.scala --- @@ -0,0 +1,44

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-01 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15685855 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala --- @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-01 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15685887 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala --- @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-08-01 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15685865 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala --- @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-2770: Rename spark-ganglia-lgpl to gangl...

2014-08-01 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/1730 SPARK-2770: Rename spark-ganglia-lgpl to ganglia-lgpl this PR will may conflict a bit with https://github.com/apache/spark/pull/1434 (SPARK-1981 Kinesis Streaming support) due to the timing

[GitHub] spark pull request: SPARK-2770: Rename spark-ganglia-lgpl to gangl...

2014-08-01 Thread cfregly
Github user cfregly closed the pull request at: https://github.com/apache/spark/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: SPARK-2770: Rename spark-ganglia-lgpl to gangl...

2014-08-01 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/1730#issuecomment-50951751 oops. looks like too much got picked up. closing this PR. will retry later. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-31 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15651823 --- Diff: project/SparkBuild.scala --- @@ -62,7 +62,7 @@ object SparkBuild extends PomBuild { var isAlphaYarn = false var profiles

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-31 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15651971 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-31 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15653238 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-31 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/1434#issuecomment-50786500 ah, gotcha matei. the examples aren't part of the core, so they can depend on external libs. i'll make the change. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15615786 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15616231 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15616323 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15617751 --- Diff: docs/streaming-programming-guide.md --- @@ -467,6 +468,62 @@ For more details on these additional sources, see the corresponding [API documen

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15617745 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15617770 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15617760 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15617773 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15618463 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15618507 --- Diff: project/SparkBuild.scala --- @@ -60,9 +60,13 @@ object SparkBuild extends PomBuild { var isAlphaYarn = false var profiles

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15618503 --- Diff: extras/spark-kinesis-asl/src/test/resources/log4j.properties --- @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15618546 --- Diff: extras/spark-kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCount.java --- @@ -0,0 +1,310

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15618561 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCount.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-30 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15620896 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-29 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r1270 --- Diff: bin/run-kinesis-example --- @@ -0,0 +1,60 @@ +#!/usr/bin/env bash + --- End diff -- yup, yup. this is a special circumstance

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-29 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r1598 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-29 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r1717 --- Diff: extras/spark-kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-29 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r1852 --- Diff: extras/spark-kinesis-asl/pom.xml --- @@ -0,0 +1,98 @@ +?xml version=1.0 encoding=UTF-8? --- End diff -- makes sense. i'll update

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-26 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/1434#issuecomment-50253400 @mateiz - this is a completely brand-new, from-scratch implementation. parviz's old code was actually a Scala port of the Java-based Kinesis sample

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-26 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/1434#issuecomment-50253422 also, can someone address the questions i have here regarding the ec2 scripts and other peripheral aspects of this PR: https://issues.apache.org/jira/browse/SPARK-1981

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-26 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/1434#issuecomment-50253442 this PR worked for @srosenthal , btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-18 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/1434#discussion_r15141666 --- Diff: project/SparkBuild.scala --- @@ -63,6 +63,10 @@ object SparkBuild extends PomBuild { println(NOTE: SPARK_GANGLIA_LGPL is deprecated

[GitHub] spark pull request: [SPARK-1981] Add AWS Kinesis streaming support

2014-07-16 Thread cfregly
GitHub user cfregly opened a pull request: https://github.com/apache/spark/pull/1434 [SPARK-1981] Add AWS Kinesis streaming support You can merge this pull request into a Git repository by running: $ git pull https://github.com/cfregly/spark master Alternatively you can

[GitHub] spark pull request: support for Kinesis

2014-05-31 Thread cfregly
Github user cfregly commented on the pull request: https://github.com/apache/spark/pull/223#issuecomment-44760308 update: i discusses this with parviz recently - and we agreed that i would take this over. new PR to come shortly. here's the jira ticket: https://issues.apache.org