[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19709969 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -67,8 +68,9 @@ private void init(int portToBind) {

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19709984 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -67,8 +68,9 @@ private void init(int portToBind) {

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19710036 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -67,8 +68,9 @@ private void init(int portToBind) {

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61396104 [Test build #22749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22749/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61396321 [Test build #22750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22750/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397196 [Test build #22755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22755/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397212 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397209 [Test build #22749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22749/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397423 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397421 [Test build #22750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22750/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19710327 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.storage.BlockManagerId

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19710329 --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala --- @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19710333 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -491,17 +491,16 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61397668 [Test build #22758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22758/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61398711 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61398709 [Test build #22755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22755/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61399539 [Test build #22758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22758/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61399542 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714045 --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala --- @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714058 --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala --- @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714558 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -491,17 +491,16 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714588 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -491,17 +491,16 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714782 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -491,17 +491,16 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714794 --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala --- @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714825 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala --- @@ -46,6 +46,10 @@ class StreamingContextSuite extends

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61423247 [Test build #22771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22771/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19714845 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala --- @@ -46,6 +46,10 @@ class StreamingContextSuite extends

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61423536 [Test build #22772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22772/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61425604 LGTM. Feel free to merge after tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61425851 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61425849 [Test build #22771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22771/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61426763 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61426868 [Test build #22775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22775/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61426981 [Test build #22772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22772/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61426984 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61429938 [Test build #22775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22775/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61429941 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61431063 Okay great - let's try this again. I'll merge it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3053 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19719899 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.storage.BlockManagerId

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19708329 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala --- @@ -106,5 +106,8 @@ class NettyBlockTransferService(conf:

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread aarondav
GitHub user aarondav opened a pull request: https://github.com/apache/spark/pull/3053 [SPARK-4183] Close transport-related resources between SparkContexts A leak of event loops may be causing test failures. You can merge this pull request into a Git repository by running: $

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19708335 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1178,6 +1178,10 @@ private[spark] class BlockManager( def

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19708340 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -49,6 +49,7 @@ private ChannelFuture

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61386622 [Test build #22706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22706/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61386808 [Test build #22707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22707/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61386919 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61386920 [Test build #22708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22708/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61388688 [Test build #22706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22706/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61388689 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61388718 [Test build #22708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22708/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61388720 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61390211 [Test build #22723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22723/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61391217 [Test build #22726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22726/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61391677 [Test build #22723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22723/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61391679 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61392115 [Test build #22730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22730/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61392231 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61392404 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61392403 [Test build #22726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22726/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61393213 [Test build #22735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22735/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61394149 [Test build #22730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22730/consoleFull) for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61394151 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19709795 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -49,6 +49,7 @@ private ChannelFuture channelFuture;

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3053#discussion_r19709798 --- Diff: network/common/src/main/java/org/apache/spark/network/server/TransportServer.java --- @@ -67,8 +68,9 @@ private void init(int portToBind) {

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61395256 **[Test build #22735 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22735/consoleFull)** for PR 3053 at commit

[GitHub] spark pull request: [SPARK-4183] Close transport-related resources...

2014-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3053#issuecomment-61395258 Test FAILed. Refer to this link for build results (access rights to CI server needed):