Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122926978
LGTM. Merged into master. Thanks! It didn't pass the test because of some
other flaky test. My updates didn't affect the correctness, just did some
optimization.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122513661
[Test build #37694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37694/console)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122513669
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122504545
[Test build #37694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37694/consoleFull)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122504419
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122504417
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122563588
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122563585
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122580503
[Test build #37722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37722/console)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122580536
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122563383
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122563653
[Test build #37722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37722/consoleFull)
for PR 6112 at commit
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122583002
@mengxr Why did it not pass the first time after I merged your pr but now
passes?
---
If your project is set up for it, you can reply to this email and have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121849815
@GeorgeDittmar I will try to fix it and send you a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122176463
@GeorgeDittmar I sent you a PR at
https://github.com/GeorgeDittmar/spark/pull/1.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-122153012
@mengxr Sounds good. I'll keep trying to sort out wahts going on. looks
like when I run the test script locally it is now failing out so hoping I can
get a more
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121826531
Not sure why unit tests are failing. when I run them locally for the code
in VectorSuite it runs all green. I'll keep trying locally.
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121522533
[Test build #37324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37324/console)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121522571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121502183
[Test build #37324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37324/consoleFull)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121501444
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121501460
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121500838
@mengxr I added what I think was needed to the MimaExcludes but not sure if
I did it correctly or not.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121072792
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-121074637
I need to look into these MiMa tests it looks like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119840263
[Test build #36900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36900/console)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119840267
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119841350
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119841336
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119829973
@mengxr is the MimaExcludes used for keeping builds clean between versions?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119841409
[Test build #36902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36902/consoleFull)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119839451
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119839460
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119839600
[Test build #36900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36900/consoleFull)
for PR 6112 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119846462
[Test build #36902 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36902/console)
for PR 6112 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119846476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119300866
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119300923
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r34079072
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,51 @@ class SparseVector(
new SparseVector(size, ii,
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r34079015
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,51 @@ class SparseVector(
new SparseVector(size, ii,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119301899
[Test build #36704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36704/console)
for PR 6112 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119299270
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119301481
[Test build #36704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36704/consoleFull)
for PR 6112 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119308607
@GeorgeDittmar You might also need to update MimaExcludes. See
https://github.com/apache/spark/commit/34d448dbe1d7bd5bf9a8d6ef473878e570ca6161
for example.
---
If your
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119321370
@mengxr Ok i'll look over all that this evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119301902
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-119302159
Just saw it failed the style check. I'll look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r34079007
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,51 @@ class SparseVector(
new SparseVector(size, ii,
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r34079003
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,51 @@ class SparseVector(
new SparseVector(size, ii,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r34111592
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,51 @@ class SparseVector(
new
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r32049209
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -63,11 +63,49 @@ class VectorsSuite extends FunSuite {
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-110463701
@GeorgeDittmar People are busy with the Spark Summit so it might take some
time for core developers to have a last look ;)
---
If your project is set up for it, you
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-110224081
@mengxr @MechCoder Ok should be good to go I think. I cleaned up the rest
of the unit tests and found a new more style issues that I cleaned up.
---
If your
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31921583
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,53 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31923436
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,53 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31923358
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,53 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-110029570
After the minor comments LGTM.
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31921723
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,53 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31923541
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -63,11 +63,56 @@ class VectorsSuite extends FunSuite {
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-109654581
@MechCoder @mengxr Any thoughts on this latest commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-107824804
I think these last changes SHOULD catch all the corner cases lol. Hopefully
I thought of all the cases to check for in the unit tests though wouldnt
surprise me
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31387451
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31387415
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31387418
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31387482
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31387313
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31383352
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382216
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382229
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382319
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382691
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382733
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31386495
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31380991
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31204451
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31048162
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31036316
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31037349
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31045378
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31036096
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31036151
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31036655
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31048074
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31046460
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31048417
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-10554
@mengxr The latest commit should handle all cases now. Not sure why the
commit doesnt have my message attached to it though...
---
If your project is set up for
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-104544364
Latest commit does not fix this yet just initial work towards the solution.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30863343
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new SparseVector(size, ii,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30866652
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30767889
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30711828
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new SparseVector(size, ii,
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-102532848
New commit should handle the case @mengxr was talking about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30384574
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30300407
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new SparseVector(size, ii,
Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30302320
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new
Github user GeorgeDittmar commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-101748526
Associated JIRA https://issues.apache.org/jira/browse/SPARK-7422
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user GeorgeDittmar opened a pull request:
https://github.com/apache/spark/pull/6112
[Spark-7422][MLLIB] Add argmax to Vector, SparseVector
Modifying Vector, DenseVector, and SparseVector to implement argmax
functionality. This work is to set the stage for changes to be done
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6112#issuecomment-101530846
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
99 matches
Mail list logo
