Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-46396473
Took a look through and didn't see any issues with the merge. Thanks to
everyone who helped me get this in!
On Tue, Jun 17, 2014 at 2:48 PM, Reynold Xin
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-46348842
There was a conflict that I had to merge manually. Take a look at master to
make sure everything is ok. I did compile and ran a couple things.
---
If your project is set up
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-46345169
This looks good to me. I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-46343296
I will test this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-46255197
Ping I think this is ready for merging. There's been some discussion about
how to pass the implicit parameters to the methods (in two phases of
discussion!) but I think we
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13530130
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T] = thi
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13423508
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13422474
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T] =
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13419732
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T]
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13418102
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T] = t
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13387198
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13376621
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T] =
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-45053945
@rxin want to give this a final sign off?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-44148572
Any objections to merging this `.sortBy()` method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43574435
Success!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43572007
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15087/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43572005
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43569435
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43569426
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43052152
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14969/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43052151
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43049565
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-43049575
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621775
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -541,14 +543,64 @@ class RDDSuite extends FunSuite with
SharedSparkContext {
}
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621830
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -541,14 +543,64 @@ class RDDSuite extends FunSuite with
SharedSparkContext {
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621760
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag[T
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621764
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -541,14 +543,64 @@ class RDDSuite extends FunSuite with
SharedSparkContext {
}
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621569
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621500
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag[T
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621340
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag[T
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621237
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag[T
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12621279
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -150,6 +153,18 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag: ClassTag
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42904709
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42904649
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42904665
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42906068
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42906072
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42906069
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14919/
---
If your project is set up for it, you can r
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42905647
Fixed up with an unfortunate force push. I typically use merges for these
sorts of things but forgot how bad they appear in GitHub. Will remember to use
rebase for GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42906147
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14920/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42905778
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42906146
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42905496
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42905502
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42905001
I'll say it again: When you are working on preparing a PR, you're better
off rebasing than merging.
within a clone of your github repo:
git pull --reb
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42873882
Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42904711
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14915/
---
If your project is set up for it, you can r
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42904551
That merge makes the GitHub diffs really unclean, one sec and I'll make it
a nicer clean merge
---
If your project is set up for it, you can reply to this email and have y
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12554718
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -541,6 +543,46 @@ class RDDSuite extends FunSuite with
SharedSparkContext {
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r12554704
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -541,6 +543,46 @@ class RDDSuite extends FunSuite with
SharedSparkContext {
}
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42891085
This looks good. This would be a useful API to add to Spark to facilitate
sorting. Do you mind looking into Java and Python API for this as well?
---
If your project is se
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42391059
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42391094
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42391095
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14758/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42391055
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-42391069
Would appreciate getting this into 1.0 but it can wait until later as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40267040
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40267041
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14067/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40267020
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40267016
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40266965
Moved the Ordering outside of the test class, but it still brings in a
SparkConf from somewhere that fails to serialize. Sorry, I'm not much of a
Scala expert so will need
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40036254
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13973/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40036252
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40034991
You'll have to define your Ordering outside of the test class, otherwise it
will try to bring in the test class's implicit "RDDSuite.this" into the
closure. You can defin
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40034670
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40034678
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40034695
I tried writing a test for the Ordering parameter but am getting issues
with SparkConf not being serializable. I suspect that the surrounding context
of the Ordering param
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40033173
Ah, alas, looks like the context bound just desugars to the exact same
thing here, except we've just reordered the implicit arguments. We might be
able to get around this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40033138
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40033139
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13970/
---
If your project
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40031981
That gets me closer, but it looks like you then have to pass all the
implicit parameters or none of them. I tried passing in the ord parameter by
name as well, but that st
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40031655
It's likely you'll have to specify the classtag as an implicit parameter of
its own, by appending the following argument: `(implicit ctag: ClassTag[K])`,
and remove the c
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40031343
How would you write the signature with the implicit Ordering parameter as
well?
I tried with the below definition and below test
```
def sortBy[K: Cl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40031354
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40031345
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40010754
Through this pull request, I just realized how inefficient the sorting code
was (one that takes Ordered). I'm glad you are using Ordering instead. We
should change the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-39976773
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13950/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-39976772
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-39971959
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-39971934
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
GitHub user ash211 opened a pull request:
https://github.com/apache/spark/pull/369
SPARK-1063 Add .sortBy(f) method on RDD
This never got merged from the apache/incubator-spark repo (which is now
deleted) but there had been several rounds of code review on this PR there.
I
82 matches
Mail list logo
