Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21080
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r182028213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,10 +575,10 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181966326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181957835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181953816
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181952028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181950606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181949672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181931856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181931283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21080
[SPARK-23986][SQL] freshName can generate non-unique names
## What changes were proposed in this pull request?
We are using `CodegenContext.freshName` to get a unique name for any new
11 matches
Mail list logo
