Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread jun aoki
> On March 17, 2016, 11:10 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py, > > line 45 > > > > > > plural, so perhaps "..they should be.

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124128 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/packa

Re: Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44986/#review124222 --- Ship it! Ship It! - Nate Cole On March 17, 2016, 7 p.m., Nah

Review Request 45041: Strange paths in ambari-server setup

2016-03-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45041/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/ --- (Updated March 17, 2016, 2:56 p.m.) Review request for Ambari, Dmytro Sen, Jona

Re: Review Request 44565: Hive view: Visual Explain does not work when there are multiple statements in the query editor

2016-03-19 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44565/ --- (Updated March 17, 2016, 4:07 p.m.) Review request for Ambari, DIPAYAN BHOWMICK

Re: Review Request 44868: Changed HAWQ directory descriptions

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44868/#review123918 --- Ship it! Ship It! - Jayush Luniya On March 15, 2016, 10:51 p

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124309 --- Ship it! Ship It! - bhuvnesh chaudhary On March 18, 2016, 10

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/#review124042 --- Fix it, then Ship it! ambari-server/src/main/python/ambari_ser

Review Request 44931: Use Version Definition value for package-version when installing

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44931/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/ --- Review request for Ambari, Dmytro Sen, Jonathan Hurley, Nate Cole, and Sid Wagle

Re: Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45035/#review124232 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Review Request 44972: Improve error logging for install errors during blueprint deployments.

2016-03-19 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/ --- Review request for Ambari, Di Li and Sumit Mohanty. Bugs: AMBARI-15412 http

Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45030/ --- Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sid Wagle. Bu

Re: Review Request 44687: Update RCO : PXF should start after HDFS

2016-03-19 Thread Tim Thorpe
> On March 11, 2016, 9:06 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, > > line 14 > > > > > > RCO can be defined at service level > > (https://issues.apach

Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44956/ --- Review request for Ambari, Alejandro Fernandez, Laszlo Puskas, Oliver Szabo, San

Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property

2016-03-19 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45012/ --- (Updated March 18, 2016, 7:34 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

2016-03-19 Thread Gautam Borad
> On March 16, 2016, 12:24 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py, > > lines 128-131 > > > > > > Do you need to: > > >

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/#review124172 --- Ship it! Ship It! - Robert Levas On March 18, 2016, 4:39 a.m

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/#review124195 --- Thanks for providing this patch, but I believe an alternate approa

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124306 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/packa

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Daniel Gergely
> On márc. 17, 2016, 4:37 du, Robert Levas wrote: > > ambari-server/src/main/python/ambari_server_main.py, line 89 > > > > > > I am not familiar with these options, but it apears like no one really > > knows what the

Re: Review Request 44931: Use Version Definition value for package-version when installing

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44931/ --- (Updated March 16, 2016, 6:08 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 44962: file_system get_mount_point_for_dir works incorrect

2016-03-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44962/#review124045 --- Ship it! Ship It! - Dmytro Sen On Март 17, 2016, 4:03 п.п.,

Re: Review Request 44923: Alerts: Allow alerts to emit a structured response

2016-03-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44923/ --- (Updated Березень 17, 2016, 8:11 після полудня) Review request for Ambari, Dmyt

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/ --- (Updated March 17, 2016, 8:52 p.m.) Review request for Ambari, Jaimin Jetly, Ri

Re: Review Request 44959: Enable Ambari build process to automatically switch repo base urls in the repo files

2016-03-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44959/#review124020 --- Ship it! Ship It! - Sumit Mohanty On March 17, 2016, 2:49 p.

Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-19 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44933/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

2016-03-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44941/ --- (Updated March 17, 2016, 1:09 a.m.) Review request for Ambari, Aravindan Vijaya

Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45054/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44956/#review124168 --- Ship it! Ship It! - Sebastian Toader On March 18, 2016, 10:2

Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44926/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-15446

Re: Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-19 Thread Jonathan Hurley
> On March 18, 2016, 1:50 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java, > > line 453 > > > > > > I think adding a new column i

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Daniel Gergely
> On márc. 17, 2016, 6:23 du, Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 145 > > > > > > May need to ensure this is idempotent. Impl

Review Request 45045: enable ssl for ambari does not update the tez view url in tez-site.xml

2016-03-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45045/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-15484 https://iss

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/#review124098 --- Ship it! Ship It! - Srimanth Gunturi On March 17, 2016, 8:52

Re: Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-19 Thread Jonathan Hurley
> On March 18, 2016, 1:50 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java, > > line 453 > > > > > > I think adding a new column i

Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor Mag

Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property

2016-03-19 Thread Alexander Denissov
> On March 18, 2016, 5:08 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > line 699 > > > > > > do you want to inline this since propertyvalue is used only onc

Re: Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45030/#review124198 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Review Request 44960: AMBARI-15466. RBAC: Add dialog popup to explain roles

2016-03-19 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44960/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15466 https://issues.ap

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
> On March 17, 2016, 12:37 p.m., Robert Levas wrote: > > ambari-server/src/main/python/ambari_server_main.py, line 89 > > > > > > I am not familiar with these options, but it apears like no one really > > knows what

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
> On March 16, 2016, 1:57 p.m., Sid Wagle wrote: > > Shouldn't we also have a non-null check in the backend code? I am not sure.. I guess it depends on the expectations. Historically it appears that the property map is expected to not be null. I am happy to add null protections in place I can

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/#review123954 --- ambari-web/app/messages.js (line 3016)

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123892 --- Ship it! ambari-common/src/main/python/resource_management/lib

Review Request 44966: In IE, logging out of Ambari Admin View doesn't log user out of web console.

2016-03-19 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44966/ --- Review request for Ambari, Alexandr Antonenko and Denys Buzhor. Bugs: AMBARI-15

Review Request 44983: Service version display should be based on Version Definition

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44983/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 44773: Hive View : Upload Table : Tables are not deleted in case of exception.

2016-03-19 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44773/#review123976 --- Ship it! Ship It! - Pallav Kulshreshtha On March 14, 2016, 6

Re: Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45035/ --- (Updated March 18, 2016, 4:56 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44724/#review124178 --- ambari-web/app/controllers/main/alerts/manage_alert_notifications

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
> On March 16, 2016, 5:14 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java, > > line 224 > > > > > > How can this ev

Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property

2016-03-19 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45012/ --- (Updated March 18, 2016, 7:47 p.m.) Review request for Ambari, Alejandro Fernan

Review Request 45035: Restarting HDFS Before Upgrade Finalizing Does Not Supply the rollingUpgrade Flag

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45035/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas. Bu

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
> On March 17, 2016, 8:53 a.m., Jonathan Hurley wrote: > > My only concern is for safety and clarify of code, does it makes sense to > > change the contract of the config to always return a non-null (if empty) > > map? I attempted to go this route, but I got stuck where the Jackson JSON parser

Review Request 44965: AMBARI-15452 : Change timeouts for Hbase and Phoenix

2016-03-19 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44965/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/#review123919 --- Ship it! Ship It! - Jayush Luniya On March 11, 2016, 1:26 a.

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-19 Thread bhuvnesh chaudhary
> On March 16, 2016, 8 p.m., Jayush Luniya wrote: > > Ship It! Thank you Jayush. No worries, will do merge now. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/#review123919

Re: Review Request 45056: Blueprint install using config_recommendation_strategy is not functional

2016-03-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45056/#review124404 --- Ship it! Ship It! In the near future I will create a patch for

Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44915/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, and

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/ --- (Updated March 17, 2016, 1:13 a.m.) Review request for Ambari, Jaimin Jetly, Ri

Re: Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44926/#review123927 --- ambari-server/src/main/java/org/apache/ambari/server/agent/RetryA

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44933/#review124285 --- ambari-common/src/main/python/resource_management/libraries/funct

Review Request 44955: Yarn start is failed (YARN Client Install) after upgrade from 1.7.0 to 2.2.2.0

2016-03-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44955/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15461 https:

Re: Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45030/#review124204 --- Ship it! Ship It! - Jonathan Hurley On March 18, 2016, 11:33

Re: Review Request 44859: Cannot specify ZooKeeper heap size via UI

2016-03-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44859/#review124013 --- ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.

Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

2016-03-19 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44886/ --- (Updated March 17, 2016, 10:13 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44956/#review124030 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-19 Thread Amruta Borkar
> On March 14, 2016, 12:27 p.m., Di Li wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2668 > > > > > > So any properties end with

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Jayush Luniya
> On March 16, 2016, 5:53 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 106 > > > > > > This may not necessarily be a rolling up

Re: Review Request 44962: file_system get_mount_point_for_dir works incorrect

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44962/#review124066 --- Ship it! Ship It! - Alejandro Fernandez On March 17, 2016, 4

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44956/#review124240 --- Ship it! Ship It! - Oliver Szabo On March 18, 2016, 9:27 a.m

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-19 Thread bhuvnesh chaudhary
> On March 14, 2016, 5:10 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, > > line 140 > > > > > > Check for null (i.e. no active namenode) >

Re: Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

2016-03-19 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44986/#review124119 --- ambari-server/src/main/java/org/apache/ambari/server/events/Servi

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Jonathan Hurley
> On March 16, 2016, 5:14 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java, > > line 224 > > > > > > How can this ev

Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

2016-03-19 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44986/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wa

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/#review124010 --- Ship it! My only concern is for safety and clarify of code, doe

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/ --- (Updated March 17, 2016, 1:48 p.m.) Review request for Ambari, Dmytro Sen, Jona

Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44915/ --- (Updated March 17, 2016, 2:28 p.m.) Review request for Ambari, Alexander Deniss

Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44915/ --- (Updated March 17, 2016, 12:47 a.m.) Review request for Ambari, Alexander Denis

Re: Review Request 45041: Strange paths in ambari-server setup

2016-03-19 Thread Alejandro Fernandez
> On March 18, 2016, 5:44 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py, line 230 > > > > > > This is doing rstrip instead, if the original string contains le

Review Request 44953: Download client configurations does not work

2016-03-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44953/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15460 https:

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/#review123895 --- Shouldn't we also have a non-null check in the backend code? - Si

Review Request 44969: After upgrading from Ambari 2.1.2 to 2.2.1, HDP from 2.3.0 to 2.3.4 , user is getting 'Consistency Check Failed' error while trying to save configuration in Ranger, Hive and HBas

2016-03-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44969/ --- Review request for Ambari, Jaimin Jetly and Sebastian Toader. Bugs: AMBARI-1546

Re: Review Request 44923: Alerts: Allow alerts to emit a structured response

2016-03-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44923/ --- (Updated Березень 17, 2016, 9:28 після полудня) Review request for Ambari, Dmyt

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124115 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/packa

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/#review124069 --- ambari-web/app/messages.js (line 3019)

Re: Review Request 44923: Alerts: Allow alerts to emit a structured response

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44923/#review123914 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44926/#review124202 --- ambari-server/src/main/java/org/apache/ambari/server/actionmanage

Re: Review Request 44565: Hive view: Visual Explain does not work when there are multiple statements in the query editor

2016-03-19 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44565/#review124065 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 17, 2016, 4:07

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-19 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/ --- (Updated March 17, 2016, 6:52 p.m.) Review request for Ambari, Di Li and Robert

Re: Review Request 44878: Atlas Integration : Rename Atlas Configurations

2016-03-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44878/#review123865 --- Ship it! Ship It! - Nate Cole On March 15, 2016, 8:57 p.m.,

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

2016-03-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44941/#review123978 --- ambari-metrics/ambari-metrics-host-monitoring/src/main/python/cor

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/ --- (Updated March 18, 2016, 8:57 p.m.) Review request for Ambari, Alejandro Fernan

Review Request 44957: [Ambari tarballs] ambari-server setup fails

2016-03-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44957/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15464 https:

Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44915/#review123956 --- ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_ad

Re: Review Request 45041: Strange paths in ambari-server setup

2016-03-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45041/#review124233 --- Ship it! Ship It! - Andrew Onischuk On March 18, 2016, 5:39

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/ --- (Updated March 18, 2016, 7:26 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 44926: [DRAFT] Auto-retry on failure during RU/EU

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44926/#review124117 --- ambari-server/src/main/java/org/apache/ambari/server/actionmanage

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/ --- (Updated márc. 18, 2016, 8:39 de) Review request for Ambari, Laszlo Puskas, Oli

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

2016-03-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44941/#review123980 --- Ship it! Ship It! - Sumit Mohanty On March 17, 2016, 1:09 a.

  1   2   >