Review Request 48782: Show better error message when remote cluster attached to view is deleted

2016-06-16 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48782/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-16 Thread Daniel Gergely
> On jún. 15, 2016, 3:49 du, Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java, > > line 87 > > > > > > The member annotated with @TestSubject is

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-16 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 16, 2016, 8:24 de) Review request for Ambari, Laszlo Puskas,

Review Request 48793: Log Level filter not applied before Log Search Starts at first

2016-06-16 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48793/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 48792: Zeppelin: Intermittent failure while downloading example notebooks

2016-06-16 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48792/#review137975 --- Ship it! Ship It! - Rohit Choudhary On June 16, 2016, 1:09

Re: Review Request 48782: Show better error message when remote cluster attached to view is deleted

2016-06-16 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48782/#review137956 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 16, 2016,

Review Request 48788: With Atlas HA enabled, atlas instance fails to come up with "Unable to find IDs matching any local host and port binding among id1"

2016-06-16 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48788/ --- Review request for Ambari and John Speidel. Bugs: AMBARI-17273

Re: Review Request 48041: SERVICE_CHECK Upgrade pre-check does not throw error when its expected to

2016-06-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48041/#review137961 --- Hi Dmitry, what's the status of this review/patch? - Nate Cole

Review Request 48792: Zeppelin: Intermittent failure while downloading example notebooks

2016-06-16 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48792/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 48791: All created views disappear after upgrade to 2.4.0.0 [views page]

2016-06-16 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48791/#review137976 --- Ship it! Ship It! - Rohit Choudhary On June 16, 2016, 1:07

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48817/#review138083 --- I'm really sorry about this review; Our python code is a mess.

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48817/#review138082 --- Ship it! Ship It! - Alejandro Fernandez On June 16, 2016,

Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2

2016-06-16 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/#review138096 ---

Re: Review Request 48812: Use customized display name as version string

2016-06-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48812/ --- (Updated June 16, 2016, 4:27 p.m.) Review request for Ambari, Alejandro

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Victor Galgo
> On June 16, 2016, 6:34 p.m., Di Li wrote: > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js, > > line 146 > > > > > > I am under the impression that the time it takes for NN

Re: Review Request 48814: AMBARI-17283. Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in HIVE Advanced section.

2016-06-16 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48814/ --- (Updated June 16, 2016, 9:13 p.m.) Review request for Ambari, Alejandro

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-16 Thread Jeff Zhang
> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > --- > > Failed tests: > > FAIL: test_hook_default_conf_select > >

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Robert Nettleton
> On June 16, 2016, 2:56 p.m., Robert Nettleton wrote: > > I believe this patch might have some issues that need clarification prior > > to merging this. > > > > The review and bug don't specify why this change is necessary, so I'm a > > little confused as to why this change is required in

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/ --- (Updated June 16, 2016, 9:20 p.m.) Review request for Ambari, Alejandro

Review Request 48819: As part of atlas startup, "/usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh" script is executed by ambari, which fails with "java.io.FileNotFoundException"

2016-06-16 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48819/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs:

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Di Li
> On June 16, 2016, 6:34 p.m., Di Li wrote: > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js, > > line 146 > > > > > > I am under the impression that the time it takes for NN

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48817/#review138094 --- Ship it! Any new tests required for these changes? - Nate

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Victor Galgo
> On June 16, 2016, 6:34 p.m., Di Li wrote: > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js, > > line 146 > > > > > > I am under the impression that the time it takes for NN

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review138115 ---

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-16 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/ --- (Updated June 16, 2016, 11:06 p.m.) Review request for Ambari, Jayush Luniya

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-16 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review138077 --- Ship it! Ship It! - Don Bosco Durai On June 16, 2016, 5:53

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a

Re: Review Request 48814: AMBARI-17283. Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in HIVE Advanced section.

2016-06-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48814/#review138127 --- Ship it! Ship It! - Alejandro Fernandez On June 16, 2016,

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if

Re: Review Request 48831: UI: 'llap' queue is not shown in dropdown even though recommendation says so. Shows 'llap' queue after save.

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48831/#review138133 --- Ship it! Ship It! - Zhe (Joe) Wang On June 17, 2016, 12:30

Review Request 48830: AMBARI-17288 Redundant element on create version page

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48830/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. Bugs:

Review Request 48831: UI: 'llap' queue is not shown in dropdown even though recommendation says so. Shows 'llap' queue after save.

2016-06-16 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48831/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku

Review Request 48827: AMBARI-17286 Service config links should use public host name

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48827/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Srimanth Gunturi,

Review Request 48829: AMBARI-17245 Failed to start Hive metastore due to UnicodeDecodeError

2016-06-16 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48829/ --- Review request for Ambari, Andrew Onischuk and jun aoki. Bugs: AMBARI-17245

Review Request 48834: AMBARI-17289 VDF: UI Edits #2

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48834/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.

Re: Review Request 48809: AMBARI-17266 - StackDeploys: Suse: after enabling ranger plugin save button is always present

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48809/#review138070 --- Ship it! Ship It! - Zhe (Joe) Wang On June 16, 2016, 7:23

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
> On Июнь 16, 2016, 2:56 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2692 > > > > > > Has the Metrics

Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/ --- (Updated June 16, 2016, 2:28 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/#review137986 --- Ship it! Ship It! - Sebastian Toader On June 16, 2016, 4:28

Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/#review137981 --- Ship it! Ship It! - Robert Levas On June 16, 2016, 10:28

Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/ --- Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, Robert

Re: Review Request 48772: [AMBARI-17243] Use " livy-${cluster-name}@${realm}" instead of " livy@${realm}" for identity "livy.server.kerberos.principal"

2016-06-16 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48772/#review137980 ---

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48729/#review137985 --- Fix it, then Ship it! I believe this patch might have some

Review Request 48791: All created views disappear after upgrade to 2.4.0.0 [views page]

2016-06-16 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48791/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 48792: Zeppelin: Intermittent failure while downloading example notebooks

2016-06-16 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48792/#review137970 --- Ship it! Ship It! - Gaurav Nagar On June 16, 2016, 1:09

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-16 Thread Masahiro Tanaka
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit it? - Masahiro --- This is an automatically generated e-mail. To reply, visit:

Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48805/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Re: Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48805/#review138033 ---

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-16 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/ --- (Updated June 16, 2016, 5:53 p.m.) Review request for Ambari, Don Bosco Durai,

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
> On Июнь 16, 2016, 2:56 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2693 > > > > > > My concern here

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
> On Июнь 16, 2016, 2:56 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2693 > > > > > > My concern here

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Sumit Mohanty
> On June 16, 2016, 2:56 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2693 > > > > > > My concern here

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
> On Июнь 16, 2016, 2:56 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2693 > > > > > > My concern here

Re: Review Request 48788: With Atlas HA enabled, atlas instance fails to come up with "Unable to find IDs matching any local host and port binding among id1"

2016-06-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48788/#review138020 --- Ship it! Ship It! - Alejandro Fernandez On June 16, 2016,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 16, 2016, 6:43 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-06-16 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/ --- (Updated June 16, 2016, 6:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread Tom Beerbower
> On June 16, 2016, 6:11 p.m., John Speidel wrote: > > Curious, how does the Hive hook work now that the Atlas config isn't in > > it's classpath? > > Tom Beerbower wrote: > Ambari now writes the atlas configuration file into the Hive conf folder. Thanks for the review. - Tom

Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread Tom Beerbower
> On June 16, 2016, 6:11 p.m., John Speidel wrote: > > Curious, how does the Hive hook work now that the Atlas config isn't in > > it's classpath? Ambari now writes the atlas configuration file into the Hive conf folder. - Tom ---

Re: Review Request 48788: With Atlas HA enabled, atlas instance fails to come up with "Unable to find IDs matching any local host and port binding among id1"

2016-06-16 Thread Tom Beerbower
> On June 16, 2016, 5:04 p.m., Alejandro Fernandez wrote: > > Ship It! Thanks for the review. - Tom --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48788/#review138020

Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread John Speidel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48743/#review138038 --- Ship it! Curious, how does the Hive hook work now that the

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48734/#review138047 ---

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review138042 --- This is causing unit test failures. Please take a look.

Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS

2016-06-16 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/#review138067 --- Ship it! Ship It! - Aravindan Vijayan On June 16, 2016,

Re: Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-16 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48805/#review138056 --- Ship it! Ship It! - Tim Thorpe On June 16, 2016, 5:47 p.m.,

Re: Review Request 48782: Show better error message when remote cluster attached to view is deleted

2016-06-16 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48782/#review138157 --- Ship it! Ship It! - Nitiraj Rathore On June 16, 2016, 10:34

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48817/ --- (Updated June 16, 2016, 11:11 p.m.) Review request for Ambari, Alejandro