Re: Review Request 51201: Generate REST API docs with Swagger for Log Search

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51201/#review148144 --- Ship it! Ship It! - Dharmesh Makwana On Aug. 18, 2016,

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51207/ --- (Updated Сен. 8, 2016, 11:49 д.п.) Review request for Ambari, Aravindan

Re: Review Request 51691: JMX metric retrieval method may unnecessarily refresh metrics at a high rate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51691/#review148177 --- Ship it! Ship It! ambari-server/docs/configuration/index.md

Review Request 51725: Microsoft-R client should work in a secured cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, Sumit

Review Request 51727: Need to validate behaviour and show warn message for user after hcat user was removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51727/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51713/ --- (Updated Sept. 8, 2016, 10:23 a.m.) Review request for Ambari, Alejandro

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

> On Sept. 7, 2016, 4:56 a.m., Alexandr Antonenko wrote: > > In step-4 the flag "nextBtnClickInProgress" was not set anywhere -> We set > > nextBtnClickInProgress in router for step 4 > > > > So if a timeout was manually added in the "submit" function of the > > controller, we could allow

Re: Review Request 51578: AMBARI-18071: Ambari Files View needs to have ability to load security configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51578/#review148187 --- Ship it! Ship It! - Di Li On Sept. 7, 2016, 4:57 p.m., Keta

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51713/ --- (Updated Sept. 8, 2016, 11:09 a.m.) Review request for Ambari, Alejandro

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148191 --- I'm not sure what you're fixing here. Every execution command is

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 11:13 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > line 50 > > > > > > Does not match class name,

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 1:07 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json, > > lines 107-108 > > > > > > Does this change require work in the next

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 11:13 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > line 99 > > > > > > log statement should use

Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/ --- Review request for Ambari, Di Li, Dmytro Sen, and Sid Wagle. Bugs:

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- Ship it! The patch looks fine to me. Thanks for catching and

Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51733/ --- Review request for Ambari, Jonathan Hurley and Sumit Mohanty. Bugs:

Re: Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51733/#review148211 --- ambari-agent/src/test/python/ambari_agent/TestMain.py (lines 138

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 11:13 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml, > > line 473 > > > > > > If you use KERBEROS and KERBEROS_SERVER as

Re: Review Request 51537: Use the PropertiesFile python command to create property files instead of jinja templates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51537/#review148227 --- Ship it! Ship It! - Robert Nettleton On Sept. 7, 2016, 5:45

Re: Review Request 51733: AMBARI-18342: Unit Tests failure: test_update_open_files_ulimit (TestMain.TestMain)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51733/ --- (Updated Sept. 8, 2016, 11:37 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 12:06 p.m., Nate Cole wrote: > > What will happen if, say, doing an Upgrade after this code has run, the > > user decides to Downgrade? Will the old data be intact or does it get > > overwritten? Looking at the *-upgrade-2.5.xml files, will `UpgradeUserKerberosDescriptor`

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? Hi Amruta, Sure, I can push this to trunk today. - Robert

Re: Review Request 51711: AMBARI-17458 : Add support for distributed collector to Ambari REST API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51711/#review148216 ---

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/#review148224 ---

Review Request 51739: Ambari server start fails after upgrade due to missing krb5JAASLogin.conf file on WireEncrypted cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51739/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18343

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51713/#review148199 --- What will happen if, say, doing an Upgrade after this code has

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 1:07 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > line 101 > > > > > > Can this possibly be

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

> On Sept. 8, 2016, 8:03 a.m., Laszlo Puskas wrote: > > Ship It! Thank you Laszlo. - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148157

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. Thank you Robert, could you please help me push this to trunk? - Amruta --- This is an

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 11:13 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > lines 85-89 > > > > > > Suggest making

Re: Review Request 51659: Ambari cannot install HDP from mirror list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51659/#review148213 --- Ship it! Ship It! - Andrew Onischuk On Sept. 8, 2016, 5:23

Re: Review Request 51748: Ranger audit log collection is not used in Log Search (managed by ambari)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51748/#review148281 --- Ship it! Ship It! - Oliver Szabo On Sept. 8, 2016, 10:02

Re: Review Request 51570: Enable log search for NIFI_CA component

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51570/#review148240 --- Ship it! Ship It! - Robert Nettleton On Sept. 1, 2016, 8:44

Re: Review Request 51739: Ambari server start fails after upgrade due to missing krb5JAASLogin.conf file on WireEncrypted cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51739/#review148242 --- Ship it! Ship It! - Sumit Mohanty On Sept. 8, 2016, 6:21

Re: Review Request 51747: AMBARI-18324: Externalize skip repo url check to ambari.properties instead of hardcoding it in Ambari Java code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51747/#review148265 --- Ship it! Ship It! - Tim Thorpe On Sept. 8, 2016, 9:11 p.m.,

Review Request 51748: Ranger audit log collection is not used in Log Search (managed by ambari)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51748/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 51743: AMBARI-18345. 'Stack advisor' validation code reports error while trying to access 'yarn.nodemanager.resource.memory-mb' config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51743/#review148253 --- Ship it! Ship It! - Sumit Mohanty On Sept. 8, 2016, 8:05

Review Request 51747: AMBARI-18324: Externalize skip repo url check to ambari.properties instead of hardcoding it in Ambari Java code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51747/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-18324

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? > > Robert Nettleton wrote: > Hi Amruta, > >

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/#review148255 ---

Re: Review Request 49804: improve resourcemanager HA description

> On Sept. 6, 2016, 3:41 p.m., Nate Cole wrote: > > Ship It! > > wang yaoxin wrote: > Thank you , but I don't have the authority to ship, so i will trouble you > to commit the patch! A review needs 2 approvals before being pushed. - Nate

Re: Review Request 51727: Need to validate behaviour and show warn message for user after hcat user was removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51727/#review148239 --- Ship it! Ship It! - Sumit Mohanty On Sept. 8, 2016, 7:21

Re: Review Request 51708: While checking for component dependency code looks for incorrect component name

> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? > > Robert Nettleton wrote: > Hi Amruta, > >

Re: Review Request 51698: Added database metrics source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51698/#review148252 --- ambari-server/conf/unix/metrics.properties (line 28)

Re: Review Request 51727: Need to validate behaviour and show warn message for user after hcat user was removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51727/ --- (Updated Вер. 8, 2016, 7:21 після полудня) Review request for Ambari, Andrew

Re: Review Request 51698: Added database metrics source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51698/ --- (Updated Sept. 8, 2016, 8:25 p.m.) Review request for Ambari and Aravindan

Review Request 51745: Setting fetch_nonlocal_groups to false Can Prevent Services From Starting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51745/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Nate Cole.

Re: Review Request 51698: Added database metrics source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51698/ --- (Updated Sept. 8, 2016, 9:05 p.m.) Review request for Ambari and Aravindan

Re: Review Request 51570: Enable log search for NIFI_CA component

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51570/#review148235 --- Ship it! Ship It! - Jayush Luniya On Sept. 1, 2016, 8:44

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

> On Sept. 8, 2016, 1:07 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelper.java, > > lines 555-558 > > > > > > I'm worried about

Review Request 51744: SmartSense Mandatory Install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51744/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/#review148251 --- Ship it! Ship It! - Oliver Szabo On Sept. 8, 2016, 2 p.m.,

Re: Review Request 51713: After upgrading cluster from HDP-2.4.x to HDP-2.5.x and added atlas service - missing kafka security properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51713/#review148295 --- Impressive set of changes. One question: Some of the config

Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51754/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Repository:

Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51754/ --- (Updated 9月 9, 2016, 10:21 a.m.) Review request for Ambari, Alexander