Re: Review Request 52467: Use logsearch truststore to look for credential in case of external authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52467/#review151166 --- Ship it! Ship It! - Oliver Szabo On Oct. 3, 2016, 1:08

Review Request 52483: Write unittests for configs.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52483/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18515

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151169 --- Ship it! Ship It! - Di Li On Sept. 30, 2016, 11:10 p.m.,

Re: Review Request 52467: Use logsearch truststore to look for credential in case of external authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52467/ --- (Updated Oct. 3, 2016, 1:08 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 51197: Zeppelin logsearch configuration typo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51197/ --- (Updated Oct. 3, 2016, 1:16 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 52456: Modify HTTP headers to follow best security practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151168 --- Ship it! Ship It! - Di Li On Sept. 30, 2016, 10:56 p.m.,

Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/ --- Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako. Bugs:

Re: Review Request 52481: Ambari-Server restart causes all host components to go in Heartbeat Lost state indefinitely.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52481/#review151163 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 3, 2016,

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151170 --- ambari-admin/src/main/resources/ui/admin-web/app/index.html

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151171 --- Ship it! Overall, the patch looks fine to me, just a few

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you please help push the fix? > > Alexandr Antonenko wrote: > done Thank you. Closing the review request. - Sangeeta

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151178 ---

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

> On Oct. 3, 2016, 3:19 p.m., Robert Nettleton wrote: > > pom.xml, line 679 > > > > > > I think the overall scheme to categorize tests sounds like a good idea. > > > > However, I do have some concerns

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Oct. 3, 2016, 4:35 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151187 --- Add unit tests - Jayush Luniya On Oct. 3, 2016, 3:20 p.m.,

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151188 ---

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Oct. 3, 2016, 11:43 a.m.) Review request for Ambari, Alejandro

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Sept. 30, 2016, 7:48 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 117 > > > > > > Does this store the entire

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/ --- (Updated Oct. 3, 2016, 6:22 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 6:13 p.m.) Review request for Ambari, Alexandr

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151209 --- Fix it, then Ship it! Please add unit tests maybe another Jira

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Sept. 30, 2016, 7:45 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 103 > > > > > > REST API URLs mostly use

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review151191 --- Ship it! Ship It! - Di Li On Sept. 30, 2016, 12:39 a.m.,

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/ --- (Updated Oct. 3, 2016, 6:52 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151217 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 3, 2016,

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/ --- (Updated Oct. 3, 2016, 7:32 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review151223 ---

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review151212 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 3, 2016,

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

> On Oct. 3, 2016, 7:04 p.m., Alejandro Fernandez wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, > > line 150 > > > > > > Will hostname_hash ever be negative? Ideally,

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/#review151221 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 3, 2016,

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/ --- (Updated Oct. 3, 2016, 8:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review151215 --- Ship it! Ship It! - Di Li On Oct. 3, 2016, 6:43 p.m.,

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151213 ---

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 12:04 p.m., Di Li wrote: > > Ship It! Thank you Di. - Vishal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review151215

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/ --- (Updated Oct. 3, 2016, 7:30 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151220 ---

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 11:58 a.m., Alejandro Fernandez wrote: > > Ship It! Thank you for reviewing the patch. I would appreciate if you can commit the changes on my behalf (I am not a committer). - Vishal --- This is an automatically

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

> On Oct. 1, 2016, 3:21 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 956 > > > > > > Should we instead introduce a variable in

Re: Review Request 52451: AMBARI-18508. Provide a configurable option for "LLAP's headroom space for YARN container".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/ --- (Updated Oct. 3, 2016, 8:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52451: AMBARI-18508. Provide a configurable option for "LLAP's headroom space for YARN container".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52451/#review151230 --- Ship it! Ship It! - Sumit Mohanty On Oct. 3, 2016, 8:16

Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote: > > ambari-server/src/main/python/ambari_server/setupSecurity.py, lines 838-843 > > > > > > Roles will be configurable in the future, this will be problematic. -is

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296 > > > > > > group_type does not need to be that large. Thank you for reviewing the

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151248 --- When you say "local testing done", what did that entail? Also,

Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52497/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 11:25 p.m.) Review request for Ambari, Alexandr

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 3, 2016, 7:41 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 86 > > > > > > what's the point of passing

Re: Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52496/ --- (Updated Oct. 3, 2016, 10:56 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52496/ --- (Updated Oct. 3, 2016, 10:56 p.m.) Review request for Ambari, Dmytro Sen,

Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52496/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.

Re: Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52497/#review151265 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 3, 2016, 11:13

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 4, 2016, 12:51 a.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 52340: Refactor solr layer in logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/#review151146 --- Fix it, then Ship it! Fix it, then ship it

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151153 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 3, 2016,

Re: Review Request 52340: Refactor solr layer in logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- (Updated Oct. 3, 2016, 9:58 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 3, 2016, 9:38 a.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151155 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 3, 2016,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 3, 2016, 9:19 a.m.) Review request for Ambari and Dmitro

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151158 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 3, 2016,

Review Request 52482: Analyze and Optimize Ambari Server Unit Tests - Group 7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52482/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18513

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151161 --- Ship it! Ship It! - Tim Thorpe On Sept. 30, 2016, 11:10

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151160 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 1, 2016,

Review Request 52481: Ambari-Server restart causes all host components to go in Heartbeat Lost state indefinitely.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52481/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18512

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you please help push the fix? done - Alexandr --- This is an automatically generated e-mail. To reply,

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

On Oct. 3, 2016, 1:17 p.m., Vishal Ghugare wrote: > > Missing unit test for `AmbariPamAuthenticationProvider`. Can you please review AmbariPamAuthenticationProviderTest? - Vishal --- This is an automatically generated e-mail. To reply,

Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/ --- Review request for Ambari, Mahadev Konar, Robert Levas, and Sumit Mohanty.

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/#review151291 --- Ship it! Ship It! - Sumit Mohanty On Oct. 4, 2016, 3:14

Re: Review Request 52455: Ambari UI changes to support PAM authentication

> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > > > > > I don't see this newly created file in diff files list. You were able >

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Oct. 3, 2016, 7:57 p.m.) Review request for Ambari, Alejandro