Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
> On Oct. 12, 2017, 5:46 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > > Lines 365-375 (original), 364-371 (patched) > > > > > >

Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62931/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-22216

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62931/#review187779 --- Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 8:29

Review Request 62933: Log Search UI generated by maven build uses mock data instead of real API

2017-10-12 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62933/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-22218

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62931/#review187784 --- Fix it, then Ship it!

Re: Review Request 62933: Log Search UI generated by maven build uses mock data instead of real API

2017-10-12 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62933/#review187785 --- Ship it! Ship It! - Aleksandr Kovalenko On Окт. 12, 2017, 1

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Jonathan Hurley
> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 217-222 (patched) > > > > > > Should these oddly named FKs go in a

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Nate Cole
> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 217-222 (patched) > > > > > > Should these oddly named FKs go in a

Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/ --- Review request for Ambari, Dmytro Grinenko and Nate Cole. Bugs: AMBARI-22219

Re: Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/#review187795 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 9:57 a.m.,

Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

2017-10-12 Thread Piyush Chavhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62930/ --- Review request for Ambari. Bugs: AMBARI-22187

Re: Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/#review187796 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 1:57

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Jonathan Hurley
> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 217-222 (patched) > > > > > > Should these oddly named FKs go in a

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62931/ --- (Updated Oct. 12, 2017, 6:36 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 62932: Deploy fails due to PU code related issues (post-merge)

2017-10-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62932/#review187819 --- Ship it! Ship It! - Sid Wagle On Oct. 12, 2017, 12:38 p.m.,

Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62941/ --- Review request for Ambari and Aravindan Vijayan. Bugs: AMBARI-22192

Review Request 62943: AMBARI-22220 - Should be able to switch the extension version to which a stack version is linked

2017-10-12 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62943/ --- Review request for Ambari, Di Li, Jonathan Hurley, and Jayush Luniya. Bugs:

Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/ --- Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187837 ---

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62941/#review187840 ---

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187842 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 2:57 p.m.,

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187843 --- Ship it! Ship It! - Sebastian Toader On Oct. 12, 2017, 8:57

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62941/ --- (Updated Oct. 12, 2017, 7:10 p.m.) Review request for Ambari and Aravindan

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187845 --- Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 2:57

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62941/#review187849 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 12, 2017,

Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62948/ --- Review request for Ambari, Balázs Bence Sári, Nate Cole, Robert Levas, and

Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs:

Re: Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

2017-10-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62948/#review187865 --- Ship it! Ship It! - Robert Levas On Oct. 12, 2017, 4:33

Re: Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

2017-10-12 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62948/#review187871 --- Ship it! Ship It! - Sandor Magyari On Oct. 12, 2017, 8:33

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187876 ---

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187878 --- Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 4:46

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
> On Oct. 12, 2017, 5:46 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > > Lines 365-375 (original), 364-371 (patched) > > > > > >

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-12 Thread Madhuvanthi Radhakrishnan
> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > > Line 664 (original), 664 (patched) > > > > > > We have to look at references

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-12 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/ --- (Updated Oct. 12, 2017, 11:47 p.m.) Review request for Ambari, Jonathan

Review Request 62932: Deploy fails due to PU code related issues (post-merge)

2017-10-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62932/ --- Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/ --- (Updated Oct. 12, 2017, 2:33 p.m.) Review request for Ambari, DIPAYAN

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/#review187765 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 12, 2017,

Re: Review Request 62924: Alter logic for storing interpreter.json

2017-10-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62924/#review187764 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 12, 2017,

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187753 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 11, 2017,

Re: Review Request 62890: AMBARI-22204 Updating Ranger Admin pre-upgrade task

2017-10-12 Thread Mugdha Varadkar
> On Oct. 11, 2017, 2:08 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > > Lines 201-205 (original), 201-207 (patched) > > > > > > Why

Re: Review Request 62890: AMBARI-22204 Updating Ranger Admin pre-upgrade task

2017-10-12 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62890/ --- (Updated Oct. 12, 2017, 9 a.m.) Review request for Ambari, Alejandro

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/#review187756 ---

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread Prabhjyot Singh
> On Oct. 12, 2017, 2:29 p.m., Jeff Zhang wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py > > Lines 230 (patched) > > > > > > livy.key-password is optional, it is

Re: Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62922/#review187768 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 5:30

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187773 --- Ship it! Ship It! - Sebastian Toader On Oct. 12, 2017, 1:39

Re: Review Request 62924: Alter logic for storing interpreter.json

2017-10-12 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62924/ --- (Updated Oct. 12, 2017, 4:56 p.m.) Review request for Ambari, DIPAYAN

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/ --- (Updated Oct. 12, 2017, 11:39 a.m.) Review request for Ambari, Jonathan

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187778 --- Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 7:39

Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-12 Thread Yussuf Shaikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62923/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22200

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-12 Thread Yussuf Shaikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62923/ --- (Updated Oct. 12, 2017, 6:20 a.m.) Review request for Ambari and Nate Cole.

Review Request 62924: Alter logic for storing interpreter.json

2017-10-12 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62924/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit

Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit

Re: Review Request 62924: Alter logic for storing interpreter.json

2017-10-12 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62924/#review187747 --- Ship it! Ship It! - venkat sairam On Oct. 12, 2017, 6:37

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62925/#review187748 --- Ship it! Ship It! - venkat sairam On Oct. 12, 2017, 7:06