Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-03 Thread Jayush Luniya
de add="false" v/s on-ambari-upgrade add="true") Can you provide examples? I am not clear on why on-ambari-upgrade delete="true" and on-stack-upgrade delete="false"? I will look at your original patch to get some context and then review la

Re: Review Request 48332: Log search capability for Nifi

2016-06-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48332/#review136499 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 10:05

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
> On June 3, 2016, 5:16 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml, > > line 32 > > <https://reviews.apache.org/r/48212/diff/1-2/?file=1405757#file1405757line32> > > > &g

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/#review136366 --- Ship it! Ship It! - Jayush Luniya On June 3, 2016, 4:55 p.m

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136845 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 4:09 p.m

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
16, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > >

Re: Review Request 47830: AMBARI-16874 Add capability to derive required core-site.xml properties in case if not already available

2016-05-25 Thread Jayush Luniya
/functions/constants.py (line 86) <https://reviews.apache.org/r/47830/#comment199780> Dont name feature with stack name in it. The feature might be useful for for some other stack as well. - Jayush Luniya On May 25, 2016, 2:09 p.m., Mugdha Varadkar

Re: Review Request 47845: "Zeppelin service check" was scheduled before "Zeppelin Notebook Start"

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47845/#review134907 --- Ship it! Ship It! - Jayush Luniya On May 25, 2016, 7:13 p.m

Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

2016-06-15 Thread Jayush Luniya
> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit this ? Committed, thanks for your contribution. Can you close the

Re: Review Request 48659: Fix Spark2 thriftserver Ambari definition bug

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 4:40 p.m., Jayush Luniya wrote: > > Ship It! Committed patch. Please close CR - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48659/#rev

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Jayush Luniya
ing whitespace. "hooks_folder": "HDP/2.0.6/hooks", error: patch failed: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py:156 error: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py: patch does

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-15 Thread Jayush Luniya
> On June 1, 2016, 8:55 p.m., Jayush Luniya wrote: > > Ship It! Lav, can you close the review if the patch is already committed? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 48636: Zeppelin Views are not working with Custom and Remote cluster view configuration

2016-06-15 Thread Jayush Luniya
) <https://reviews.apache.org/r/48636/#comment202960> fake? - Jayush Luniya On June 13, 2016, 1:22 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48335: Zeppelin service: Update default zeppelin_pid_dir to /var/run/zeppelin

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48335/#review137770 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 11:45

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48308/#review137771 --- Ship it! Ship It! - Jayush Luniya On June 14, 2016, 4:10

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 5:51 p.m., Jayush Luniya wrote: > > Ship It! For 2.4 and trunk, we should not have any hdp-select and hdp hardcodings. Everything should be stack config driven. - Jayush --- This is an automatically ge

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review135657 --- Ship it! Ship It! - Jayush Luniya On May 31, 2016, 12:53

Re: Review Request 47830: AMBARI-16874 Add capability to derive required core-site.xml properties in case if not already available

2016-05-25 Thread Jayush Luniya
/package/scripts/setup_ranger_xml.py (line 522) <https://reviews.apache.org/r/47830/#comment199845> So for HDP when HDFS is not installed we create a blank core-site. How is that different from the case where HDFS is not in the stack def. - Jayush Luniya On May 25, 2016, 2:09 p.m.,

Re: Review Request 47774: AMBARI-16843. Auto logout zeppelin server in case of session inactivity.

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47774/#review134905 --- Ship it! Ship It! - Jayush Luniya On May 24, 2016, 1:27 p.m

Re: Review Request 47781: clean up import * for PIG service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47781/#review135741 --- Ship it! Ship It! - Jayush Luniya On May 24, 2016, 4:39 p.m

Re: Review Request 47934: clean up import * for SLIDER service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47934/#review135752 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 12:20

Re: Review Request 47964: clean up import * for ZOOKEEPER service

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47964/#review135757 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:36 p.m

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-05-31 Thread Jayush Luniya
conflicts? - Jayush Luniya On May 20, 2016, 6:14 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-05-31 Thread Jayush Luniya
- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description

Re: Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47962/#review135755 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:28 p.m

Re: Review Request 47922: clean up import * for KNOX service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47922/#review135749 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 10:59

Re: Review Request 47619: clean up import * for MAHOUT service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47619/#review135743 --- Ship it! Ship It! - Jayush Luniya On May 19, 2016, 11:27

Re: Review Request 47963: clean up import * for YARN service

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47963/#review135756 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:33 p.m

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
Memory: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
change in a new CR request. I will verify it and commit this delta patch instead of reverting the old patch. - Jayush Luniya On June 1, 2016, 11:06 p.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
/kerberos.json (line 1) <https://reviews.apache.org/r/46727/#comment200974> Patch does not apply. I dont see a kerberos.json file in HDP-2.5 ls ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK metainfo.xml - Jayush Luniya On June 2, 2016, 10:27 a.m., Jeff

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Jayush Luniya
e path defined in one place - Jayush Luniya On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47653/#review135952 --- Ship it! Ship It! - Jayush Luniya On May 20, 2016, 6:14 p.m

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Jayush Luniya
g/r/47941/#comment200972> Use explicit imports - Jayush Luniya On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
> On June 2, 2016, 4:52 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json, > > line 1 > > <https://reviews.apache.org/r/46727/diff/18/?file=1404615#file1404615line1> > > > > Patch does not

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review135966 --- Ship it! Ship It! - Jayush Luniya On June 2, 2016, 10:27

Re: Review Request 47579: Spark2 service definition for Ambari

2016-06-02 Thread Jayush Luniya
-mail. To reply, visit: > https://reviews.apache.org/r/47579/ > --- > > (Updated May 23, 2016, 2:55 a.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16753 > http

Re: Review Request 47885: AMBARI-16894: Default Ranger repos for some services are not getting created

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47885/#review135972 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:30 a.m

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135942 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 11:04

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48157/#review135933 ------- On June 2, 2016, 6:15 p.m., Jayush Luniya wrote: > > --- > This is an au

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
y: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Re: Review Request 47830: AMBARI-16874 Add capability to derive required core-site.xml properties in case if not already available

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47830/#review134932 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 5:29 a.m

Re: Review Request 47722: AMBARI-16813 Ranger Usersync config to support Group Based Search for LDAP Sync Source

2016-05-26 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47722/#review134934 --- Ship it! Ship It! - Jayush Luniya On May 25, 2016, 10:38

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-26 Thread Jayush Luniya
> > (Updated May 23, 2016, 2:55 a.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16753 > https://issues.apache.org/jira/browse/AMBARI-16753 > > > Repository: ambari

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Jayush Luniya
/package/scripts/nodemanager.py (line 90) <https://reviews.apache.org/r/47963/#comment200862> @Juanjo, it looks like check_process_status is not imported for YARN nodemanager and will cause problems. Can you submit an addendum patch with this change? - Jayush Luniya On May 27, 2016

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
y: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48143/#review135851 --- Ship it! Ship It! - Jayush Luniya On June 1, 2016, 6:26 p.m

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135854 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 7:11 p.m

Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
/test_ru_set_all.py 9a4dd31 ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 Diff: https://reviews.apache.org/r/48157/diff/ Testing --- Thanks, Jayush Luniya

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-31 Thread Jayush Luniya
> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote: > > @Jeff > > Can you verify that blueprint deployment of the cluster without Livy Server > > works? > > > > Guide on Blueprints > > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints >

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
. There are conflicts. Will commit once I have the latest patch. - Jayush Luniya On June 13, 2016, 10:45 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
> On June 2, 2016, 4:42 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py, > > line 1 > > <https://reviews.apache.org/r/47941/diff/1/?file=1396057#file1396057line1> > > > > Pleas

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > --- > > Failed tests: > > FAIL: test_hook_default_conf_select > > (

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review138862 --- Ship it! Ship It! - Jayush Luniya On June 20, 2016, 4:18

Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48970/#review138863 --- Ship it! Ship It! - Jayush Luniya On June 20, 2016, 11:19

Re: Review Request 48999: Fix Spark2 history server quick link still point to spark1 url

2016-06-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48999/#review138755 --- Ship it! Ship It! - Jayush Luniya On June 21, 2016, 3:14

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-16 Thread Jayush Luniya
- [INFO] Total time: 1:15.808s [INFO] Finished at: Thu Jun 16 09:56:48 PDT 2016 [INFO] Final Memory: 60M/837M [INFO]

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > --- > > Failed tests: > > FAIL: test_hook_default_conf_select > > (

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review138226 --- Ship it! Ship It! - Jayush Luniya On June 16, 2016, 11:06

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-17 Thread Jayush Luniya
> On June 2, 2016, 5:01 p.m., Jayush Luniya wrote: > > Ship It! @Jeff can you close this CR? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#rev

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 17, 2016, 2:57 p.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > Update patch in CR with > https://issues.apache.org/jira/secure/attachment/12811383/AMBARI-16920-7.patch Also close CR

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-17 Thread Jayush Luniya
as this is a FE change - Jayush Luniya On June 15, 2016, 4:41 p.m., Victor Galgo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 17, 2016, 2:57 p.m., Jayush Luniya wrote: > > Ship It! Update patch in CR with https://issues.apache.org/jira/secure/attachment/12811383/AMBARI-16920-7.patch - Jayush --- This is an automatically generated e-mail.

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-17 Thread Jayush Luniya
trailing whitespace. "hooks_folder": "HDP/2.0.6/hooks", error: patch failed: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py:58 error: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_servi

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-17 Thread Jayush Luniya
> On June 15, 2016, 4:57 p.m., Jayush Luniya wrote: > > Ship It! @Jeff can you close this CR as the patch is committed? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-17 Thread Jayush Luniya
tps://reviews.apache.org/r/48734/#comment203429> Not sure if stopping namenodes is the right way to go about with this. - Jayush Luniya On June 15, 2016, 4:41 p.m., Victor Galgo wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49134: Add llap-*log4j config dependency for hive server interactive component

2016-06-23 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49134/#review139323 --- Ship it! Ship It! - Jayush Luniya On June 23, 2016, 6:18

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
y 4601092 ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py 31dac56 ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py ab08776 Diff: https://reviews.apache.org/r/44835/diff/ Testing --- Thanks, Jayush Luniya

Re: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses

2016-03-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44285/#review123455 --- Ship it! Ship It! - Jayush Luniya On March 3, 2016, 7:56

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-14 Thread Jayush Luniya
/package/alerts/api_status.py (line 140) <https://reviews.apache.org/r/44688/#comment185706> Check for null (i.e. no active namenode) - Jayush Luniya On March 11, 2016, 1:26 a.m., bhuvnesh chaudhary

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
-------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123658 --- On March 15, 2016, 6:32 a.m., Jayush Luniya wrote: > >

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
but I am not going with refactoring to that level right now. - Jayush Luniya On March 15, 2016, 6:32 a.m., Jayush Luniya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
t variants of stacks similar to HDP can work. - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123658 ----------

Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
rn_client.py 4601092 ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py ab08776 Diff: https://reviews.apache.org/r/44835/diff/ Testing --- Thanks, Jayush Luniya

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
/hooks/after-INSTALL/test_after_install.py daee726 ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py ab08776 Diff: https://reviews.apache.org/r/44835/diff/ Testing --- Thanks, Jayush Luniya

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
/functions/constants.py (line 47) <https://reviews.apache.org/r/45328/#comment188809> Typo: Rename to REMOVE_RANGER_HDFS_PLUGIN_ENV - Jayush Luniya On March 24, 2016, 11:26 p.m., Juanjo Marron wrote: > > --- > This is a

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
This should be 2.3.0.0 and not 2.3.0.1 - Jayush Luniya On March 24, 2016, 11:26 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
> On March 29, 2016, 4:17 p.m., Jayush Luniya wrote: > > Ship It! @Juanjo Please see my comments below. I noticed the issue after I +1'ed. Can you revise the patch? - Jayush --- This is an automatically generated e-mail.

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Jayush Luniya
/functions/stack_features.py (line 73) <https://reviews.apache.org/r/45338/#comment188812> We are copying Tez, Mapreduce and Slider tarballs under this condition. - Jayush Luniya On March 28, 2016, 4:09 p.m., Juanjo Marron

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Jayush Luniya
ly, visit: https://reviews.apache.org/r/45458/#review126112 ------- On March 30, 2016, 4:06 a.m., Jayush Luniya wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Jayush Luniya
revisited for Atlas. - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45470/#review126157 --- On March 30, 2016, 5:15 a.m., Jayush Luniya wrote

Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic

2016-03-30 Thread Jayush Luniya
change? - It looks like there is a dependent change that has been made in the past and the context is missing in the Apache JIRA - Jayush Luniya On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Jayush Luniya
ng.xml ambari/ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_nonrolling.xml - Jayush Luniya On March 31, 2016, 2:07 a.m., Alejandro Fernandez

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-31 Thread Jayush Luniya
/stack_features.json (line 123) <https://reviews.apache.org/r/45522/#comment189213> Rename to oozie_create_hive_tez_configs instead? - Jayush Luniya On March 31, 2016, 2:50 a.m., Juanjo Marron wrote: > > --- > This is a

Re: Review Request 45810: zeppelin_log_dir change leads to fail for different Zeppelin Notebook service actions

2016-04-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45810/#review127376 --- Ship it! Ship It! - Jayush Luniya On April 6, 2016, 1:10

Re: Review Request 45867: Add shiro.ini in Ambari Zeppelin service config

2016-04-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45867/#review127620 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 1:17

Re: Review Request 45857: RU/EU PreCheck to ensure dfs.client.retry.policy.enable is set to false

2016-04-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45857/#review127622 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 1:46

Re: Review Request 45878: Remove PHD references from HAWQ

2016-04-07 Thread Jayush Luniya
-services/HAWQ/2.0.0/package/scripts/hawqmaster.py (line 25) <https://reviews.apache.org/r/45878/#comment191007> Yes this is no longer required. - Jayush Luniya On April 7, 2016, 4:48 p.m., Lav Jain

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

2016-04-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127661 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 5:55

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
the stack_advisor from stack-level to service-level at one shot. It is too risky a change. Instead we should support service-level advisors as extensions to stack_advisors so that add-on/custom services can extend the stack_advisors. Similar to how you handled RCO. - Jayush Luniya On March 1, 2016, 4

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
ptions. - Jayush Luniya On March 1, 2016, 4:53 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44210/ >

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45705/#review127127 --- Ship it! Ship It! - Jayush Luniya On April 4, 2016, 9:48

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-04-05 Thread Jayush Luniya
> On March 29, 2016, 12:49 p.m., Nate Cole wrote: > > I think you need a more concrete way of ordering here. What if two > > services are marked as YARN? Which one takes precedence? You may > > want to introduce an in order to > > specifically state how it happens. Order would be a

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

2016-04-06 Thread Jayush Luniya
/configuration/kafka-env.xml (line 61) <https://reviews.apache.org/r/45835/#comment190803> Shouldnt we update these values during ambari-server upgrade instead i.e. existing cluster value should be updated on upgrading ambari-server? - Jayush Luniya On April 6, 2016, 9:12 p.m., Sri

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Jayush Luniya
/package/scripts/params.py (line 143) <https://reviews.apache.org/r/45837/#comment190822> @Sriharsha There is a typo here that we missed in the CR. Missing ')' Can you fix it? - Jayush Luniya On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45837/#review127458 --- Ship it! Ship It! - Jayush Luniya On April 6, 2016, 9:12

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/#review127445 --- Ship it! Ship It! - Jayush Luniya On April 6, 2016, 8:21

Re: Review Request 45751: Alert definitions: Percentage params should be the percentage number instead of fraction number

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45751/#review127128 --- Merge with https://reviews.apache.org/r/45705/ changes - Jayush

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
> On March 2, 2016, 6:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/default_stack_advisor.py, line 35 > > > > > > Please include Srimanth Gunturi in the code review, thanks! +1 on

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-06 Thread Jayush Luniya
/package/scripts/hive_service_interactive.py (line 113) <https://reviews.apache.org/r/45778/#comment190544> Keep cmd as a list - Jayush Luniya On April 5, 2016, 9:46 p.m., Juanjo Marron wrote: > > --- > This is a

  1   2   3   4   5   6   >