Review Request 48258: Fix description of SERVICE.ADD_DELETE_SERVICES permission

2016-06-05 Thread Robert Levas
and upgrade. Thanks, Robert Levas

Re: Review Request 48439: App Timeline Server start fails on a kerberized cluster due to absence of hdfs keytab

2016-06-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48439/#review136685 --- Ship it! Ship It! - Robert Levas On June 8, 2016, 2:46 p.m

Re: Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions

2016-06-08 Thread Robert Levas
/UpgradeCatalog230.java (lines 347 - 351) <https://reviews.apache.org/r/48440/#comment201784> If this is needed in UpgradeCatalog240, why is it being done in UpgradeCatalog230? - Robert Levas On June 8, 2016, 2:51 p.m., Vitalyi Brodetskyi

Re: Review Request 48489: Atlas Integration : Required changes for atlas-application.properties

2016-06-09 Thread Robert Levas
-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json (line 15) <https://reviews.apache.org/r/48489/#comment201901> Is this correct? Should "kafka" be taken from some property value since it seems like it may be a username that might be found in `kakfa-e

Re: Review Request 48392: Deadlock While Updating Stale Configuration Cache During Upgrade

2016-06-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48392/#review136637 --- Ship it! Ship It! - Robert Levas On June 8, 2016, 8:44 a.m

Re: Review Request 48350: Atlas Integration : Ambari overwrites users-credentials.properties and policy-store.txt

2016-06-07 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48350/#review136519 --- Ship it! Ship It! - Robert Levas On June 7, 2016, 12:33 p.m

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

2016-06-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48516/#review136991 --- Ship it! Ship It! - Robert Levas On June 9, 2016, 7 p.m

Re: Review Request 48553: Blueprint processor should handle manual stack definition changes without failing deployment

2016-06-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48553/#review137057 --- Ship it! Ship It! - Robert Levas On June 10, 2016, 3:09 p.m

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136134 --- Ship it! Ship It! - Robert Levas On June 3, 2016, 5:30 p.m

Re: Review Request 47828: Cluster deploy fails if property admin_sever_host not set in blueprint

2016-05-25 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47828/#review134768 --- Ship it! Ship It! - Robert Levas On May 25, 2016, 9:32 a.m

Re: Review Request 48689: Ability to add "javax.jdo.option.ConnectionPassword" to hive clients from ambari

2016-06-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48689/#review137514 --- Ship it! Ship It! - Robert Levas On June 14, 2016, 10:01

Review Request 48640: Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to SERVICE.ADMINISTRATOR role and above

2016-06-13 Thread Robert Levas
] # Jenkins test results: PENDING Thanks, Robert Levas

Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java 2642418 Diff: https://reviews.apache.org/r/48702/diff/ Testing --- # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
eviews.apache.org/r/48702/#review137568 --- On June 14, 2016, 2:57 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48702/ > ---

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
] # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
] # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137717 --- Ship it! Ship It! - Robert Levas On June 15, 2016, 5:46 a.m

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137312 --- Ship it! Ship It! - Robert Levas On June 13, 2016, 11:04

Re: Review Request 48640: Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to SERVICE.ADMINISTRATOR role and above

2016-06-13 Thread Robert Levas
//console Thanks, Robert Levas

Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Robert Levas
/... StackManagerTest.testServicesWithRangerPluginRoleCommandOrder:713 » Ambari Fil... ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us... Tests run: 4458, Failures: 0, Errors: 4, Skipped: 34 ``` #Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48204/#review136062 --- Ship it! Ship It! - Robert Levas On June 3, 2016, 8:43 a.m

Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

2016-06-08 Thread Robert Levas
Thanks, Robert Levas

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Robert Levas
te/kerberos/KerberosIdentityDescriptorTest.java 0ea7b26 Diff: https://reviews.apache.org/r/47933/diff/ Testing --- Manually tested # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Robert Levas
gt; > Should special permissions like this go right in the action definition > > itself? Would require finding out if the file is readable by non-root > > Ambari. Would help with having to hard code action names here. > > Robert Levas wrote: > I dont think I understa

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Robert Levas
> > > This is a little odd - string compares? We don't have anything more > > contractual for "check host" permissions? > > Robert Levas wrote: > Not really. Essentually the (custom) commands sent to the Reqeust > endpoint are strings that (I

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Robert Levas
] #Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Robert Levas
and sort of mirror what `org.apache.commons.collections` is doing. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47933/#review135255 -------

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Robert Levas
> On May 27, 2016, 3:04 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 52 > > <https://reviews.apache.org/r/47961/diff/2/?file=1397157#file1397157l

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47961/#review135291 --- Ship it! Ship It! - Robert Levas On May 27, 2016, 3:18 p.m

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Robert Levas
rg/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java (line 55) <https://reviews.apache.org/r/47961/#comment200306> "returns is as a resource property" -> "returns it as a resource property" - R

Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas
> On May 27, 2016, 4:08 p.m., Robert Levas wrote: > > Its not clear how the patch helps to prevent: > > > > ``` > > Traceback (most recent call last): > > File > > "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/packag

Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47967/#review135312 --- Ship it! Ship It! - Robert Levas On May 27, 2016, 1 p.m

Re: Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-27 Thread Robert Levas
berosIdentityDescriptorTest.java 0ea7b26 Diff: https://reviews.apache.org/r/47933/diff/ Testing --- Manually tested # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas
olr/server/solr/configsets/basic_configs/conf -cs basic_configs -rt 5 -i 10' returned 127. -bash: /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or directory ``` - Robert Levas On May 27, 2016, 1 p.m., Tom Beerb

Re: Review Request 47976: LDAP sync cannot handle if the member attribute value is not DN or id

2016-05-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47976/#review135310 --- Ship it! Ship It! - Robert Levas On May 27, 2016, 4:14 p.m

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Robert Levas
:28:21 EDT 2016 [INFO] Final Memory: 59M/1807M [INFO] #Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-02 Thread Robert Levas
s/stack_advisor.py (lines 229 - 230) <https://reviews.apache.org/r/48162/#comment200925> Do we want all this additional logging? If you want to keep it, maybe downgrade the level? - Robert Levas On

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-02 Thread Robert Levas
ectory`: ``` if "cluster-env" in services["configurations"] \ and "security_enabled" in services["configurations"]["cluster-env"]["properties"] \ and services["configurations"]["cluster-env

Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

2016-05-26 Thread Robert Levas
OrPredicateTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/PredicateUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47933/diff/ Testing --- Manually tested # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-26 Thread Robert Levas
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47783/#review134823 ------- On May 24, 2016, 1:48 p.m., Robert Levas wrote: > > --- &g

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-26 Thread Robert Levas
visit: https://reviews.apache.org/r/47783/#review134823 ------- On May 24, 2016, 1:48 p.m., Robert Levas wrote: > > --- > This is an automatically generat

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-06-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/#review135794 --- Ship it! Ship It! - Robert Levas On May 27, 2016, 6:48 p.m

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
- Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137568 --- On June 14, 2016, 2:57 p.m., Robert Le

Re: Review Request 49086: hiveserver2-site.xml not created

2016-06-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49086/#review139066 --- Ship it! Ship It! - Robert Levas On June 22, 2016, 9:41 a.m

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-22 Thread Robert Levas
335> > > > > isBlank instead? yup - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49029/#review139080 --- On

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-22 Thread Robert Levas
] # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-22 Thread Robert Levas
2016 [INFO] Final Memory: 61M/1851M [INFO] # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 49093: Unable To Delete A Service After Upgrade Due To Foreign Key Violation

2016-06-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49093/#review139074 --- Ship it! Ship It! - Robert Levas On June 22, 2016, 11:35

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Robert Levas
s/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml (line 216) <https://reviews.apache.org/r/48741/#comment203008> Is "none" an acceptable value here? Maybe this should be ""? - Robert Levas On J

Re: Review Request 48710: atlas.authentication.principal should be set to atlas/_h...@example.com

2016-06-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48710/#review137613 --- Ship it! Ship It! - Robert Levas On June 14, 2016, 7:03 p.m

Re: Review Request 48772: [AMBARI-17243] Change livy principal to service type

2016-06-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48772/#review138213 --- Ship it! Ship It! - Robert Levas On June 17, 2016, 8:58 a.m

Re: Review Request 49012: AMBARI-17330 Ambari changes to support kerberized Ranger tagsync

2016-06-21 Thread Robert Levas
ge/templates/zookeeper_jaas.conf.j2 - Robert Levas On June 21, 2016, 3:12 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-21 Thread Robert Levas
] # Jenkins test results: PENDING Thanks, Robert Levas

Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-21 Thread Robert Levas
/kerberos/KerberosServiceDescriptorTest.java e5392c0 Diff: https://reviews.apache.org/r/49029/diff/ Testing --- Manually testing... updated unit tests... # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 48844: Operations during upgrade are permitted by all roles

2016-06-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48844/#review138848 --- Ship it! Ship It! - Robert Levas On June 21, 2016, 10:56

Review Request 49106: AuthorizationHelperTest.testAuthName may fail due to residual SecurityContext from previously executed test cases.

2016-06-22 Thread Robert Levas
org.apache.ambari.server.security.authorization.AuthorizationHelperTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.354 sec - in org.apache.ambari.server.security.authorization.AuthorizationHelperTest Thanks, Robert Levas

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49104/#review139142 --- Ship it! Ship It! - Robert Levas On June 22, 2016, 5:25 p.m

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

2016-06-23 Thread Robert Levas
To reply, visit: > https://reviews.apache.org/r/49119/ > --- > > (Updated June 22, 2016, 8:14 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sumit > Mohanty. > > > Bugs: AMBARI-17

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

2016-06-23 Thread Robert Levas
/#comment204405> How about adding a `testGetAnyUserCaseInsensitive` (or something like that) to ensure no one accidentally breaks this in the future. - Robert Levas On June 22, 2016, 8:14 p.m., Nahappan

Re: Review Request 49145: Ability to add "javax.jdo.option.ConnectionPassword" to hive clients from ambari

2016-06-23 Thread Robert Levas
mment204398> Missing javadoc ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java (lines 507 - 508) <https://reviews.apache.org/r/49145/#comment204400> This formatting is a little off... - Robert Levas On June 23, 2016

Re: Review Request 49012: AMBARI-17330 Ambari changes to support kerberized Ranger tagsync

2016-06-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49012/#review139120 --- Ship it! Ship It! - Robert Levas On June 22, 2016, 2:30 a.m

Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/#review137981 --- Ship it! Ship It! - Robert Levas On June 16, 2016, 10:28

Re: Review Request 48772: [AMBARI-17243] Use " livy-${cluster-name}@${realm}" instead of " livy@${realm}" for identity "livy.server.kerberos.principal"

2016-06-16 Thread Robert Levas
/kerberos.json (lines 33 - 34) <https://reviews.apache.org/r/48772/#comment203188> Why is this not something like ``` ${livy-env/livy_user}/_HOST@${realm} ``` - Robert Levas On June 15, 2016, 10:52 p.m., Jeff Zhang

Re: Review Request 49198: Support Atlas in kerberized environment, submit Service Check as smokeuser

2016-06-24 Thread Robert Levas
/ATLAS/test_service_check.py (line 58) <https://reviews.apache.org/r/49198/#comment204576> user = 'ambari-qa' - Robert Levas On June 24, 2016, 9:10 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

2016-06-24 Thread Robert Levas
> IMO user name should be stored and returned in original case. > > Only comparison should be case insensitive. > > Robert Levas wrote: > I agree that the name should be stored lowercase. > > Nahappan Somasundaram wrote: > This is required for backward compatibili

Re: Review Request 48844: Operations during upgrade are permitted by all roles

2016-06-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48844/#review138212 --- Ship it! Ship It! - Robert Levas On June 17, 2016, 6:16 a.m

Review Request 49286: AmbariServer looks for ldap_url, container_dn in blueprint even for MIT security type

2016-06-27 Thread Robert Levas
ueprints/bp1 HTTP/1.1 100 Continue HTTP/1.1 400 Bad Request Date: Mon, 20 Jun 2016 19:02:27 GMT X-Frame-Options: DENY X-XSS-Protection: 1; mode=block Set-Cookie: AMBARISESSIONID=1a4dqzhedwoog4xg8jbu36e2q;Path=/;HttpOnly Expires: Thu, 01 Jan 1970 00:00:00 GMT User: admin Content-Type: text/plain Content-Length: 227 Server: Jetty(9.2.11.v20150529) { "status" : 400, "message" : "Blueprint configuration validation failed: Missing required properties. Specify a value for these properties in the blueprint configuration. {host1={kerberos-env=[ldap_url, container_dn]}}" } ``` # Solution Remove the `require-input` flag from the offending properties. This UI appears to handle making the fields required if necessary. Eventually a conditionally-required-input type should be created to handle this dynamically. Diffs - ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 98d2ada Diff: https://reviews.apache.org/r/49286/diff/ Testing --- Manually tested. Thanks, Robert Levas

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Robert Levas
ted e-mail. To reply, visit: https://reviews.apache.org/r/44784/#review123439 ------- On March 14, 2016, 8:19 a.m., Robert Levas wrote: > > --- > This is an automatically

Re: Review Request 44801: Fix ArtifactResourceProviderTest to avoid set ordering issues

2016-03-14 Thread Robert Levas
------- On March 14, 2016, 3:09 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44801/ > --

Re: Review Request 44472: Kerberos Tickets Expire Too Frequently For Alerts

2016-03-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44472/#review122592 --- Ship it! Ship It! - Robert Levas On March 8, 2016, 2:58 p.m

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/#review124172 --- Ship it! Ship It! - Robert Levas On March 18, 2016, 4:39

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
[INFO] Total time: 1:04:54.682s [INFO] Finished at: Thu Mar 17 14:54:27 EDT 2016 [INFO] Final Memory: 74M/1855M [INFO] # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
2016, 12:59 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44916/ > --- > > (Upd

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
> On March 17, 2016, 12:37 p.m., Robert Levas wrote: > > ambari-server/src/main/python/ambari_server_main.py, line 89 > > <https://reviews.apache.org/r/44958/diff/1/?file=1302356#file1302356line89> > > > > I am not familiar with these options, but it apears l

Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-07 Thread Robert Levas
y tested new cluster and upgraded cluster # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Robert Levas
g/r/45972/#comment191504> This value must include the cluster's name like other _headless_ principals. This is to help avoid name collisions when multiple Ambari clusters share the same KDC or AD. Example: `hive-${cluster-name}@${realm}` Also, hard-coding `hive` here is pro

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-11 Thread Robert Levas
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/#review128097 --- On April 8, 2016, 5:20 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46032/#review128129 --- Ship it! Ship It! - Robert Levas On April 11, 2016, 10:38

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-08 Thread Robert Levas
reviews.apache.org/r/45914/diff/ Testing --- manually tested new cluster and upgraded cluster # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 46052: Provide backward compatibility for kdc_host in krb5-conf for krb5.conf templates

2016-04-12 Thread Robert Levas
. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console Thanks, Robert Levas

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/#review127875 --- Ship it! Ship It! - Robert Levas On April 8, 2016, 4:09 p.m

Review Request 46052: Provide backward compatibility for kdc_host in krb5-conf for krb5.conf templates

2016-04-11 Thread Robert Levas
. -- Ran 9 tests in 0.112s OK ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
-- On March 16, 2016, 4:55 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44916/ > ---

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-19 Thread Robert Levas
y? Do we know how this will affect performance? - Robert Levas On March 17, 2016, 10:57 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
y 8c18421 Diff: https://reviews.apache.org/r/44916/diff/ Testing --- Manually tested in cluster Kerbrerized using the Ambari UI. Thanks, Robert Levas

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-20 Thread Robert Levas
r/internal/BlueprintConfigurationProcessorTest.java 68d5755 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9070c0a Diff: https://reviews.apache.org/r/44916/diff/ Testing --- Manually tested in cluster Kerbrerized using the Ambari UI. Thanks, Robert Levas

Re: Review Request 44148: Add FreeIPA support to Ambari.

2016-03-23 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44148/#review125104 --- Ship it! Ship It! - Robert Levas On March 14, 2016, 5:01

Re: Review Request 45056: Blueprint install using config_recommendation_strategy is not functional

2016-03-23 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45056/#review125100 --- Ship it! Ship It! - Robert Levas On March 18, 2016, 6:31

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-23 Thread Robert Levas
issue in the description addressed? - Robert Levas On March 22, 2016, 9:40 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 45289: RBAC based user access to view instances are not honoured

2016-03-24 Thread Robert Levas
org.apache.ambari.server.security.authorization.AuthorizationHelperTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec - in org.apache.ambari.server.security.authorization.AuthorizationHelperTest Thanks, Robert Levas

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-24 Thread Robert Levas
> On March 23, 2016, 8:31 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2723 > > <https://reviews.apache.org/r/44725/diff/4/?file=1310989#file1310989line2723> >

Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

2016-03-24 Thread Robert Levas
? - Robert Levas On March 23, 2016, 6:59 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-24 Thread Robert Levas
- > > (Updated March 24, 2016, 9:04 a.m.) > > > Review request for Ambari, Andrii Tkach, Dmitro Lisnichenko, Myroslav > Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-15554 > https://issues.apache.org/jira/browse/AM

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-24 Thread Robert Levas
> On March 24, 2016, 12:52 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java, > > line 39 > > <https://reviews.apache.org/r/45284/diff/1/?file=1313635#file1313635line39> >

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Robert Levas
er-env` config multiple times with the same tag. If you skip the setting of this, wont you loose data? - Robert Levas On March 21, 2016, 10:23 a.m., Sebastian Toader wrote: > > --- > This is an automatically generated e

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Robert Levas
> On March 21, 2016, 11:33 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > lines 1437-1438 > > <https://reviews.apache.org/r/45101/diff/1/?file=1308341#file1308341line1437> >

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-23 Thread Robert Levas
ambari/server/security/ldap/AmbariLdapDataPopulator.java (line 361) <https://reviews.apache.org/r/45208/#comment187770> You might want to reverse the clauses here since the boolean check is faster than the `contains` check and mail fail first. - Robert Levas On March 23, 2016, 7:45

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-23 Thread Robert Levas
> On March 23, 2016, 8:31 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2723 > > <https://reviews.apache.org/r/44725/diff/4/?file=1310989#file1310989line2723> >

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
ache.org/r/44916/diff/ Testing --- Manually tested in cluster Kerbrerized using the Ambari UI. Thanks, Robert Levas

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-19 Thread Robert Levas
a the stack advisor returns. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/#review123930 --- On March

  1   2   3   4   5   6   7   8   9   10   >