and upgrade.
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48439/#review136685
---
Ship it!
Ship It!
- Robert Levas
On June 8, 2016, 2:46 p.m
/UpgradeCatalog230.java
(lines 347 - 351)
<https://reviews.apache.org/r/48440/#comment201784>
If this is needed in UpgradeCatalog240, why is it being done in
UpgradeCatalog230?
- Robert Levas
On June 8, 2016, 2:51 p.m., Vitalyi Brodetskyi
-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json
(line 15)
<https://reviews.apache.org/r/48489/#comment201901>
Is this correct? Should "kafka" be taken from some property value since it
seems like it may be a username that might be found in `kakfa-e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48392/#review136637
---
Ship it!
Ship It!
- Robert Levas
On June 8, 2016, 8:44 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48350/#review136519
---
Ship it!
Ship It!
- Robert Levas
On June 7, 2016, 12:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review136991
---
Ship it!
Ship It!
- Robert Levas
On June 9, 2016, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48553/#review137057
---
Ship it!
Ship It!
- Robert Levas
On June 10, 2016, 3:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48221/#review136134
---
Ship it!
Ship It!
- Robert Levas
On June 3, 2016, 5:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47828/#review134768
---
Ship it!
Ship It!
- Robert Levas
On May 25, 2016, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48689/#review137514
---
Ship it!
Ship It!
- Robert Levas
On June 14, 2016, 10:01
/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
2642418
Diff: https://reviews.apache.org/r/48702/diff/
Testing
---
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
eviews.apache.org/r/48702/#review137568
---
On June 14, 2016, 2:57 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
]
# Jenkins test results: PENDING
Thanks,
Robert Levas
]
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48722/#review137717
---
Ship it!
Ship It!
- Robert Levas
On June 15, 2016, 5:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48642/#review137312
---
Ship it!
Ship It!
- Robert Levas
On June 13, 2016, 11:04
//console
Thanks,
Robert Levas
/...
StackManagerTest.testServicesWithRangerPluginRoleCommandOrder:713 » Ambari
Fil...
ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File
/Us...
Tests run: 4458, Failures: 0, Errors: 4, Skipped: 34
```
#Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48204/#review136062
---
Ship it!
Ship It!
- Robert Levas
On June 3, 2016, 8:43 a.m
Thanks,
Robert Levas
te/kerberos/KerberosIdentityDescriptorTest.java
0ea7b26
Diff: https://reviews.apache.org/r/47933/diff/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
gt; > Should special permissions like this go right in the action definition
> > itself? Would require finding out if the file is readable by non-root
> > Ambari. Would help with having to hard code action names here.
>
> Robert Levas wrote:
> I dont think I understa
>
> > This is a little odd - string compares? We don't have anything more
> > contractual for "check host" permissions?
>
> Robert Levas wrote:
> Not really. Essentually the (custom) commands sent to the Reqeust
> endpoint are strings that (I
and sort of mirror what
`org.apache.commons.collections` is doing.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/#review135255
-------
> On May 27, 2016, 3:04 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> > line 52
> > <https://reviews.apache.org/r/47961/diff/2/?file=1397157#file1397157l
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#review135291
---
Ship it!
Ship It!
- Robert Levas
On May 27, 2016, 3:18 p.m
> On May 27, 2016, 4:08 p.m., Robert Levas wrote:
> > Its not clear how the patch helps to prevent:
> >
> > ```
> > Traceback (most recent call last):
> > File
> > "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/packag
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/#review135312
---
Ship it!
Ship It!
- Robert Levas
On May 27, 2016, 1 p.m
berosIdentityDescriptorTest.java
0ea7b26
Diff: https://reviews.apache.org/r/47933/diff/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47976/#review135310
---
Ship it!
Ship It!
- Robert Levas
On May 27, 2016, 4:14 p.m
:28:21 EDT 2016
[INFO] Final Memory: 59M/1807M
[INFO]
#Jenkins test results: PENDING
Thanks,
Robert Levas
s/stack_advisor.py
(lines 229 - 230)
<https://reviews.apache.org/r/48162/#comment200925>
Do we want all this additional logging? If you want to keep it, maybe
downgrade the level?
- Robert Levas
On
ectory`:
```
if "cluster-env" in services["configurations"] \
and "security_enabled" in
services["configurations"]["cluster-env"]["properties"] \
and
services["configurations"]["cluster-env
OrPredicateTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/PredicateUtilsTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47933/diff/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/#review134823
-------
On May 24, 2016, 1:48 p.m., Robert Levas wrote:
>
> ---
&g
visit:
https://reviews.apache.org/r/47783/#review134823
-------
On May 24, 2016, 1:48 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review135794
---
Ship it!
Ship It!
- Robert Levas
On May 27, 2016, 6:48 p.m
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137568
---
On June 14, 2016, 2:57 p.m., Robert Le
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49086/#review139066
---
Ship it!
Ship It!
- Robert Levas
On June 22, 2016, 9:41 a.m
335>
> >
> > isBlank instead?
yup
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49029/#review139080
---
On
]
# Jenkins test results: PENDING
Thanks,
Robert Levas
2016
[INFO] Final Memory: 61M/1851M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49093/#review139074
---
Ship it!
Ship It!
- Robert Levas
On June 22, 2016, 11:35
s/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
(line 216)
<https://reviews.apache.org/r/48741/#comment203008>
Is "none" an acceptable value here? Maybe this should be ""?
- Robert Levas
On J
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48710/#review137613
---
Ship it!
Ship It!
- Robert Levas
On June 14, 2016, 7:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48772/#review138213
---
Ship it!
Ship It!
- Robert Levas
On June 17, 2016, 8:58 a.m
ge/templates/zookeeper_jaas.conf.j2
- Robert Levas
On June 21, 2016, 3:12 a.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
]
# Jenkins test results: PENDING
Thanks,
Robert Levas
/kerberos/KerberosServiceDescriptorTest.java
e5392c0
Diff: https://reviews.apache.org/r/49029/diff/
Testing
---
Manually testing... updated unit tests...
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48844/#review138848
---
Ship it!
Ship It!
- Robert Levas
On June 21, 2016, 10:56
org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.354 sec - in
org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/#review139142
---
Ship it!
Ship It!
- Robert Levas
On June 22, 2016, 5:25 p.m
To reply, visit:
> https://reviews.apache.org/r/49119/
> ---
>
> (Updated June 22, 2016, 8:14 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-17
/#comment204405>
How about adding a `testGetAnyUserCaseInsensitive` (or something like that)
to ensure no one accidentally breaks this in the future.
- Robert Levas
On June 22, 2016, 8:14 p.m., Nahappan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49012/#review139120
---
Ship it!
Ship It!
- Robert Levas
On June 22, 2016, 2:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48794/#review137981
---
Ship it!
Ship It!
- Robert Levas
On June 16, 2016, 10:28
/kerberos.json
(lines 33 - 34)
<https://reviews.apache.org/r/48772/#comment203188>
Why is this not something like
```
${livy-env/livy_user}/_HOST@${realm}
```
- Robert Levas
On June 15, 2016, 10:52 p.m., Jeff Zhang
/ATLAS/test_service_check.py (line 58)
<https://reviews.apache.org/r/49198/#comment204576>
user = 'ambari-qa'
- Robert Levas
On June 24, 2016, 9:10 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-
> IMO user name should be stored and returned in original case.
> > Only comparison should be case insensitive.
>
> Robert Levas wrote:
> I agree that the name should be stored lowercase.
>
> Nahappan Somasundaram wrote:
> This is required for backward compatibili
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48844/#review138212
---
Ship it!
Ship It!
- Robert Levas
On June 17, 2016, 6:16 a.m
ueprints/bp1
HTTP/1.1 100 Continue
HTTP/1.1 400 Bad Request
Date: Mon, 20 Jun 2016 19:02:27 GMT
X-Frame-Options: DENY
X-XSS-Protection: 1; mode=block
Set-Cookie: AMBARISESSIONID=1a4dqzhedwoog4xg8jbu36e2q;Path=/;HttpOnly
Expires: Thu, 01 Jan 1970 00:00:00 GMT
User: admin
Content-Type: text/plain
Content-Length: 227
Server: Jetty(9.2.11.v20150529)
{
"status" : 400,
"message" : "Blueprint configuration validation failed: Missing required
properties. Specify a value for these properties in the blueprint
configuration. {host1={kerberos-env=[ldap_url, container_dn]}}"
}
```
# Solution
Remove the `require-input` flag from the offending properties. This UI appears
to handle making the fields required if necessary. Eventually a
conditionally-required-input type should be created to handle this dynamically.
Diffs
-
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
98d2ada
Diff: https://reviews.apache.org/r/49286/diff/
Testing
---
Manually tested.
Thanks,
Robert Levas
ted e-mail. To reply, visit:
https://reviews.apache.org/r/44784/#review123439
-------
On March 14, 2016, 8:19 a.m., Robert Levas wrote:
>
> ---
> This is an automatically
-------
On March 14, 2016, 3:09 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44801/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44958/#review124172
---
Ship it!
Ship It!
- Robert Levas
On March 18, 2016, 4:39
2016, 12:59 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44916/
> ---
>
> (Upd
y tested new cluster and upgraded cluster
# Jenkins test results: PENDING
Thanks,
Robert Levas
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45914/#review128097
---
On April 8, 2016, 5:20 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6367//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6367//console
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45937/#review127875
---
Ship it!
Ship It!
- Robert Levas
On April 8, 2016, 4:09 p.m
.
--
Ran 9 tests in 0.112s
OK
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
--
On March 16, 2016, 4:55 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44916/
> ---
y? Do we know how this will affect
performance?
- Robert Levas
On March 17, 2016, 10:57 a.m., Daniel Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
y
8c18421
Diff: https://reviews.apache.org/r/44916/diff/
Testing
---
Manually tested in cluster Kerbrerized using the Ambari UI.
Thanks,
Robert Levas
r/internal/BlueprintConfigurationProcessorTest.java
68d5755
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9070c0a
Diff: https://reviews.apache.org/r/44916/diff/
Testing
---
Manually tested in cluster Kerbrerized using the Ambari UI.
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45056/#review125100
---
Ship it!
Ship It!
- Robert Levas
On March 18, 2016, 6:31
org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec - in
org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Thanks,
Robert Levas
-
>
> (Updated March 24, 2016, 9:04 a.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmitro Lisnichenko, Myroslav
> Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku Sako.
>
>
> Bugs: AMBARI-15554
> https://issues.apache.org/jira/browse/AM
> On March 24, 2016, 12:52 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java,
> > line 39
> > <https://reviews.apache.org/r/45284/diff/1/?file=1313635#file1313635line39>
>
er-env` config multiple times with the same tag.
If you skip the setting of this, wont you loose data?
- Robert Levas
On March 21, 2016, 10:23 a.m., Sebastian Toader wrote:
>
> ---
> This is an automatically generated e
ambari/server/security/ldap/AmbariLdapDataPopulator.java
(line 361)
<https://reviews.apache.org/r/45208/#comment187770>
You might want to reverse the clauses here since the boolean check is
faster than the `contains` check and mail fail first.
- Robert Levas
On March 23, 2016, 7:45
> On March 23, 2016, 8:31 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> > line 2723
> > <https://reviews.apache.org/r/44725/diff/4/?file=1310989#file1310989line2723>
>
ache.org/r/44916/diff/
Testing
---
Manually tested in cluster Kerbrerized using the Ambari UI.
Thanks,
Robert Levas
a the stack advisor returns.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44916/#review123930
---
On March
s/RequestUtils.java
(line 32)
<https://reviews.apache.org/r/44265/#comment184678>
Javadoc
- Robert Levas
On March 8, 2016, 8:36 a.m., Daniel Gergely wrote:
>
> ---
> This is an auto
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
d6dec26
Diff: https://reviews.apache.org/r/45548/diff/
Testing
---
Manually tested, but issues seems to be intermittent in *control* cluster.
Thanks,
Robert Levas
ent192147>
If extending EasyMockSupport, than this would be
```
replayAll();
```
- Robert Levas
On April 12, 2016, 11:28 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To
nux.py
(lines 260 - 261)
<https://reviews.apache.org/r/46619/#comment194174>
Why duplicate this? Rename _rm_* to rm_*
- Robert Levas
On April 25, 2016, 10:12 a.m., Gautam Borad wrote:
>
> ---
> This is an automatic
here... maybe
the Cluster object?
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-------
On
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-------
On April 22, 2016, 5:12 p.m., Robert Levas wrote:
>
> ---
&g
Testing
---
Manually tested using the UI and BP.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
thToLocalBuilderTest
Results :
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0
# Local test result: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
nal Memory: 60M/1866M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
exist in this file then when kerberos is disabled, they wont be
removed, they will be set to the empty string. Either is ok, I just wanted you
to be aware of this.
- Robert Levas
On April 22, 2016, 9:36 a.m., Mugdha Varadkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46833/#review131102
---
Ship it!
Ship It!
- Robert Levas
On April 29, 2016, 10:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46619/#review130814
---
Ship it!
Ship It!
- Robert Levas
On April 27, 2016, 6:45
ommand, user=user,
env=kerberos_env)
```
- Robert Levas
On April 26, 2016, 8:18 a.m., Gautam Borad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
views.apache.org/r/46583/diff/
Testing
---
Manually tested using the UI and BP.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
d?
Its interesting that IntellJ didn't flag this.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134135
---
On May 1
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> -------
>
> (Updated May 19, 2016, 10:06 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Leva
1 - 100 of 836 matches
Mail list logo