Review Request 45814: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45814/ --- Review request for Aurora. Repository: aurora Description --- Small Docu

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for Aurora, Stephan Erb and B

Re: Review Request 45779: Small Documentation fixes and nitpicks.

> On April 5, 2016, 10:06 p.m., Stephan Erb wrote: > > Cool, thanks! I believe there is a dead link in the service ports section. > > Would you mind to fix that as well? fixed. - Tony --- This is an automatically generated e-mail. To r

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127342 --- Ship it! Master (a9b3df8) is green with this patch. ./build-s

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127341 --- docs/additional-resources/tools.md (line 8)

Re: Review Request 45779: Small Documentation fixes and nitpicks.

> On April 6, 2016, 8:29 a.m., Joshua Cohen wrote: > > docs/additional-resources/tools.md, line 8 > > > > > > should really be "administrator" right? not "administer"? And `developer` rather than `developers`. - Bil

Re: Review Request 45782: Adding jq to package build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45782/#review127344 --- Ship it! Ship It! - Stephan Erb On April 6, 2016, 1:02 a.m.,

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127345 --- Ship it! LGTM mod previously-mentioned nits. - Bill Farner O

Re: Review Request 45779: Small Documentation fixes and nitpicks.

> On April 6, 2016, 3:29 p.m., Joshua Cohen wrote: > > docs/additional-resources/tools.md, line 8 > > > > > > should really be "administrator" right? not "administer"? > > Bill Farner wrote: > And `developer` rath

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/ --- (Updated April 6, 2016, 3:37 p.m.) Review request for Aurora, Stephan Erb and B

Re: Review Request 45177: Setting DiscoveryInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127350 --- Ship it! I will merge once I was able to build the box and run

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127352 --- Master (b2df0eb) is red with this patch. ./build-support/jenkins

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/#review127354 --- Ship it! Ship It! - Zameer Manji On April 4, 2016, 2:30 p.m.

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127362 --- @ReviewBot retry - Tony Dong On April 6, 2016, 3:37 p.m., Tony

Re: Review Request 45779: Small Documentation fixes and nitpicks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127375 --- Ship it! Master (b2df0eb) is green with this patch. ./build-s

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/ --- (Updated April 6, 2016, 10:37 a.m.) Review request for Aurora, Maxim Khutornenk

Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ --- (Updated April 6, 2016, 10:49 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127386 --- Master (ddbb965) is red with this patch. ./build-support/jenkins

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127389 --- Master (ddbb965) is red with this patch. ./build-support/jenkins

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ --- (Updated April 6, 2016, 11:06 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/ --- (Updated April 6, 2016, 11:10 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/#review127399 --- Master (ddbb965) is red with this patch. ./build-support/jenkins

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/ --- (Updated April 6, 2016, 11:33 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127408 --- src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCache

Re: Review Request 45770: Slim the `ServerSet` interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45770/#review127411 --- Ship it! Ship It! - Bill Farner On April 5, 2016, 12:51 p.m.

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/#review127412 --- Ship it! Master (ddbb965) is green with this patch. ./build-s

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ --- (Updated April 6, 2016, 12:05 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127418 --- Master (ddbb965) is red with this patch. ./build-support/jenkins

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127419 --- This patch does not apply cleanly against master (ddbb965), do you

Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1648

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127427 --- config/checkstyle/suppressions.xml (lines 24 - 25)

Review Request 45829: Lift the standard `ServerSet` encoding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45829/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1468 https://issues

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127430 --- Ship it! Master (103dae6) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127429 --- src/main/java/org/apache/aurora/scheduler/storage/backup/Temporar

Re: Review Request 45829: Lift the standard `ServerSet` encoding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45829/#review127436 --- Ship it! Master (103dae6) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:30 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java, > > line 84 > > > > > > How about making MigrationMapper an interface and se

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127437 --- build.gradle (line 369)

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127439 --- @ReviewBot retry - Zameer Manji On April 6, 2016, 11:10 a.m., Z

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

> On April 6, 2016, 11:46 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java, > > line 35 > > > > > > What ID value do we get here? Is it descriptive enough

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/ --- (Updated April 6, 2016, 1:47 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127440 --- Ship it! Ship It! - Maxim Khutornenko On April 6, 2016, 6:10

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127446 --- Master (103dae6) is red with this patch. ./build-support/jenkins

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:11 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:37 p.m., Zameer Manji wrote: > > build.gradle, line 369 > > > > > > If the goal here is to prevent a version conflict, there is an existing > > mechanism higher up in the file that looks like t

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:30 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml, > > line 20 > > > > > > This can be `sql`, right? > > Joshua Cohen wrote: >

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:17 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127457 --- This patch does not apply cleanly against master (103dae6), do you

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127459 --- RELEASE-NOTES.md (line 14)

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:26 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 9:24 p.m., Maxim Khutornenko wrote: > > RELEASE-NOTES.md, line 14 > > > > > > This is actually doc-worthy. Mind amending > > https://github.com/apache/aurora/blob/master/docs/development/thrift.md

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 9:24 p.m., Maxim Khutornenko wrote: > > RELEASE-NOTES.md, line 14 > > > > > > This is actually doc-worthy. Mind amending > > https://github.com/apache/aurora/blob/master/docs/development/thrift.md

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127468 --- Ship it! Master (103dae6) is green with this patch. ./build-s

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/ --- (Updated April 6, 2016, 2:52 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45829: Lift the standard `ServerSet` encoding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45829/#review127472 --- Ship it! Ship It! - Bill Farner On April 6, 2016, 12:41 p.m.

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127473 --- Master (103dae6) is red with this patch. ./build-support/jenkins

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127474 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

> On April 6, 2016, 3:16 p.m., Bill Farner wrote: > > Whoops, should have been a "Fix it, then ship it!" - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127474 ---

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ --- (Updated April 6, 2016, 3:27 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ --- (Updated April 6, 2016, 3:31 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/ --- (Updated April 6, 2016, 3:35 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127486 --- Master (103dae6) is red with this patch. ./build-support/jenkins

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127495 --- @ReviewBot retry - Bill Farner On April 6, 2016, 3:31 p.m., Bil

Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127504 --- Master (103dae6) is red with this patch. ./build-support/jenkins

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127516 --- Master (9a93955) is red with this patch. ./build-support/jenkins

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127517 --- @ReviewBot retry - Bill Farner On April 6, 2016, 3:31 p.m., Bil

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127519 --- Ship it! Master (9a93955) is green with this patch. ./build-s

Re: Review Request 45372: Skip flaky test test_health_checker_metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/ --- (Updated April 6, 2016, 5:42 p.m.) Review request for Aurora, John Sirois and Z

Review Request 45850: Factor out a discovery package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45850/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1468 https://issues

Re: Review Request 45372: Skip flaky test test_health_checker_metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review127525 --- Ship it! Ship It! - John Sirois On April 6, 2016, 6:42 p.m.,

Re: Review Request 45850: Factor out a discovery package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45850/#review127527 --- Ship it! Ship It! - Bill Farner On April 6, 2016, 5:43 p.m.,

Re: Review Request 45372: Skip flaky test test_health_checker_metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review127528 --- Ship it! Master (11d5a72) is green with this patch. ./build-s

Re: Review Request 45850: Factor out a discovery package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45850/#review127529 --- Ship it! Master (11d5a72) is green with this patch. ./build-s

Review Request 45858: Fix packer builder to not prompt for input.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45858/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description ---