Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16945/#review32019 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 15, 2014, 11:29 p.m

Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16945/#review32041 --- Ship it! Ship It! - Bill Farner On Jan. 16, 2014, 4:29 a.m., Jak

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

> On Jan. 16, 2014, 3:45 a.m., Jake Farrell wrote: > > This patch does not have anything to do with gpg keys, is something missing > > from the diff? also we probably want to look at moving this into a > > build-support/release/ folder since there will be several actions pre/post > > vote that

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

> On Jan. 15, 2014, 7:45 p.m., Jake Farrell wrote: > > This patch does not have anything to do with gpg keys, is something missing > > from the diff? also we probably want to look at moving this into a > > build-support/release/ folder since there will be several actions pre/post > > vote that

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16941/#review32058 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2014, 5:50 p.m., J

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

> On Jan. 15, 2014, 12:03 p.m., Bill Farner wrote: > > Thinking out loud — would it be better to just outright reject RUN_OVERLAP? > > This certainly has an immediate effect for anyone using it, but at least > > it won't go unnoticed. I don't feel _too_ strongly either way, FWIW. This blocks

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16941/ --- (Updated Jan. 16, 2014, 7:47 p.m.) Review request for Aurora and Kevin Sweeney.

Review Request 16983: Fix maintenance command documentation and host/filename logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/ --- Review request for Aurora and Jonathan Boulle. Repository: aurora Description

Review Request 16984: Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16984/ --- Review request for Aurora, Jonathan Boulle and Brian Wickman. Repository: auror

Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description -

Review Request 16986: Add a test to encourage taking care with thrift changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/ --- Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32069 --- src/main/python/apache/aurora/client/commands/admin.py

Re: Review Request 16984: Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16984/#review32070 --- Can you put the ticket (AURORA-42) in the bug field, and link to thi

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

> On Jan. 15, 2014, 8:03 p.m., Bill Farner wrote: > > Thinking out loud — would it be better to just outright reject RUN_OVERLAP? > > This certainly has an immediate effect for anyone using it, but at least > > it won't go unnoticed. I don't feel _too_ strongly either way, FWIW. > > Kevin Sw

Re: Review Request 16984: Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16984/ --- (Updated Jan. 16, 2014, 3:48 p.m.) Review request for Aurora, Jonathan Boulle a

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16874/#review32072 --- Ship it! Ship It! - Bill Farner On Jan. 14, 2014, 11:32 p.m., Ke

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm proba

Re: Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/ --- (Updated Jan. 16, 2014, 1:10 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

> On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm probab

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm proba

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/ --- (Updated Jan. 16, 2014, 1:17 p.m.) Review request for Aurora, Jonathan Boulle a

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32079 --- Ship it! Ship It! - Bill Farner On Jan. 16, 2014, 9:17 p.m., Joe

Re: Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/#review32080 --- Looks good, can you move it to the build-support/release folder - J

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32077 --- build.gradle

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32081 --- Ship it! Ship It! - Tobias Weingartner On Jan. 16, 2014, 9:17 p.

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

> On Jan. 16, 2014, 9:29 p.m., Kevin Sweeney wrote: > > src/test/org/apache/aurora/verify_thrift_checksum.sh, line 30 > > > > > > Actually thinking a bit more this means we'll have an implicit > > build-time openssl de

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

> On Jan. 16, 2014, 9:29 p.m., Kevin Sweeney wrote: > > build.gradle, line 293 > > > > > > should be bash - executable should match #! Fixed. > On Jan. 16, 2014, 9:29 p.m., Kevin Sweeney wrote: > > src/test/org/apac

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/ --- (Updated Jan. 16, 2014, 10:12 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32088 --- Ship it! Ship It! - Kevin Sweeney On Jan. 16, 2014, 2:12 p.m., B

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32093 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 16, 2014, 10:12 p.

Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16995/ --- Review request for Aurora, Kevin Sweeney and Suman Karumuri. Bugs: AURORA-45

Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16995/#review32096 --- src/main/java/org/apache/aurora/scheduler/Driver.java

Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

> On Jan. 16, 2014, 11:41 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/Driver.java, lines 148-149 > > > > > > There's a (very small window) check-then-act race here. Should this be > > sync

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

> On Jan. 15, 2014, 11:58 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 26 > > > > > > I find this behavior jarring (clicking anywhere in a row takes yo

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16528/ --- (Updated Jan. 17, 2014, 12:51 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/ --- (Updated Jan. 16, 2014, 4:56 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/#review32104 --- Ship it! Could you add a TODO or file a follow-up jira to upgrade t

Re: Review Request 16984: Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16984/#review32106 --- Ship it! - Brian Wickman On Jan. 16, 2014, 8:48 p.m., Mark Chu-Ca

Re: Review Request 16985: Script to create Python sdists.

> On Jan. 16, 2014, 5 p.m., Brian Wickman wrote: > > Could you add a TODO or file a follow-up jira to upgrade to a newer pants > > once setup_py --recursive goes in? Is the TODO on line 34 insufficient? - Kevin --- This is an automatic

Re: Review Request 16615: Client command hooks doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review32112 --- Ship it! Ship It! - Kevin Sweeney On Jan. 14, 2014, 12:23 p.m.,

Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17014/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: https://issues.

Re: Review Request 16615: Client command hooks doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review32113 --- I've committed this change at https://git-wip-us.apache.org/repos/a

Re: Review Request 16601: Adding initial image in images directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16601/#review32114 --- This was included in the larger commit https://git-wip-us.apache.or

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16874/#review32115 --- Ship it! src/main/java/org/apache/aurora/scheduler/configuration/C

Re: Review Request 16985: Script to create Python sdists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/ --- (Updated Jan. 16, 2014, 5:59 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16874/ --- (Updated Jan. 16, 2014, 6:22 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

> On Jan. 16, 2014, 5:52 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > line 269 > > > > > > How about a full url here to avoid confusion with

Review Request 17025: AURORA-49: add keys file for signed release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17025/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: A

Re: Review Request 17025: AURORA-49: add keys file for signed release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17025/ --- (Updated Jan. 17, 2014, 2:55 a.m.) Review request for Aurora, Dave Lester, Kevi

Review Request 17026: update release tag script to support patch versions as well as minor versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17026/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 17026: update release tag script to support patch versions as well as minor versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17026/ --- (Updated Jan. 17, 2014, 3:01 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17025: AURORA-49: add keys file for signed release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17025/#review32120 --- KEYS leadin

Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17028/ --- Review request for Aurora and Joe Smith. Bugs: AURORA-50 https://issues.apa

Re: Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17028/ --- (Updated Jan. 17, 2014, 3:18 a.m.) Review request for Aurora and Joe Smith. C

Re: Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17028/#review32121 --- Ship it! Ship It! - Joe Smith On Jan. 16, 2014, 7:18 p.m., Bill

Re: Review Request 17026: update release tag script to support patch versions as well as minor versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17026/ --- (Updated Jan. 17, 2014, 3:48 a.m.) Review request for Aurora, Kevin Sweeney and

Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17030/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wi

Re: Review Request 17025: AURORA-49: add keys file for signed release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17025/ --- (Updated Jan. 17, 2014, 3:57 a.m.) Review request for Aurora, Dave Lester, Kevi

Re: Review Request 17025: AURORA-49: add keys file for signed release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17025/#review32123 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 17, 2014, 3:57 a.m