[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 3: Code-Review+1 Thanks for applying the changes.

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8801 Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming .. IMPALA-5191: Behavior of column

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 7: Code-Review+1 (3 comments) thanks for the

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#7). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8802 Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. IMPALA-6291: disable AVX512 codegen in LLVM Adds a whitelist of LLVM CPU

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: The change looks good. Please address the question

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8802 to look at the new patch set (#2). Change subject: IMPALA-6291: disable AVX512 codegen in LLVM

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8791 to look at the new patch set (#2). Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts ..

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 4: Can you adjust the logging details according to

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#8). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 ) Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8802 to look at the new patch set (#3). Change subject: IMPALA-6291: disable AVX512 codegen in LLVM

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 16: Code-Review+2 Thanks for updating the patch to move

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/5829 ) Change subject: Add .pep8rc for Impala's Python style .. Abandoned Not finding time to work on this one. -- To view, visit

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8802 to look at the new patch set (#5). Change subject: IMPALA-6291: disable AVX512 codegen in LLVM

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 5: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 16: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8791 ) Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. IMPALA-6280: Materialize

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. IMPALA-6291: disable AVX512 codegen in LLVM Adds a

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 1: (19 comments) The approach looks good to me, I

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. IMPALA-6067: Enable S3 access via IAM roles

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. IMPALA-6286: Remove invalid runtime filter

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming .. Patch Set 1: Please see my comments on the

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. IMPALA-6242: Reduce flakiness in TimerCounterTest

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 18: @pranay - looks like compilation

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 3: > (1 comment) Clang must have a way of doing a mapping, since

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 3: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 3: Right, I'm sure it calls getHostCpuFeatures() like we do,

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. IMPALA-6069: Fix CodegenAnyVal's handling of

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 ) Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8791 to look at the new patch set (#3). Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts ..

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 ) Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. IMPALA-6114: Require type equality of

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::equals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8448 Change subject: IMPALA-6114: Require type equality of NumericLiteral::equals(). .. IMPALA-6114: Require type equality of