[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#2). Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 16: (1 comment) Please see PS16.

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#4). Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-01-29 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9154 Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. IMPALA-6008: Creating a UDF from a

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 10: Code-Review+2 GVO hit a flaky test; retrying.

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#7). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#4). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-29 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#16). Change subject: IMPALA-6193: Track memory of incoming data streams

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 2: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#5). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: Code-Review+2 (1 comment) LGTM unless Dan feels

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 6: Code-Review+2 (5 comments) Thanks, this looks like another

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-29 Thread Alex Behm (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9113 to look at the new patch set (#2). Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE ..

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 4: Code-Review+2 (1 comment) Thanks for fixing this.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#6). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: next change replaces the explicitly managed opaque

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 5: (16 comments)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-29 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#6). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#3). Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-01-29 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. IMPALA-6008: Creating a UDF from a

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 3: (4 comments) Thanks for adding the test. It looks

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#7). Change subject: IMPALA-4319: remove some deprecated query options ..

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 7: Disabled kerberized testing due to IMPALA-6448.

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9150 Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. IMPALA-6447: remove Python 2.7 dictionary comprehensions In

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. Patch Set 1: Code-Review+1 Looks fine to me, but

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. IMPALA-6447: remove Python 2.7 dictionary

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#5). Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 3: Code-Review+2 rebased, as

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. IMPALA-4835: prerequisite buffer pool changes The

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 2: Build started:

[native-toolchain-CR] Make file upload/downlad progress report less verbose

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Make file upload/downlad progress report less verbose .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#7). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 11: Code-Review+2 Rebase, carry +2. -- To view,

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9155 Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. IMPALA-6450: loosen DCHECK in EventSequence::Start() It looks

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 8: Code-Review+2 Rebase, carry +2. -- To view,

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9155 to look at the new patch set (#2). Change subject: IMPALA-6450: fix EventSequence::Start() ..

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-29 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#10). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-29 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#9). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 3: Verified-1 Build

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 8: clang tidy found an issue.. update fixes it and what

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-29 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#9). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

  1   2   >