[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 14: (1 comment) Applied the update. I realized that

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#15). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 4: (2 comments)

[Impala-ASF-CR] Add KuduDataTypeToColumnType default case

2018-02-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9283 ) Change subject: Add KuduDataTypeToColumnType default case .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 3: (4 comments) Logic of the

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 3: > I don't think

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9271 to look at the new patch set (#3). Change subject: IMPALA-6497: add "Last row fetched" and AC events ..

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 3: I don't think there's a JIRA.

[Impala-ASF-CR] Add KuduDataTypeToColumnType default case

2018-02-12 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/9283 ) Change subject: Add KuduDataTypeToColumnType default case .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9283 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Add KuduDataTypeToColumnType default case

2018-02-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9283 ) Change subject: Add KuduDataTypeToColumnType default case .. Patch Set 1: Test job running here:

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-12 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8958 to look at the new patch set (#3). Change subject: IMPALA-5152: Introduce metadata loading phase

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-12 Thread Xinran Tinney (Code Review)
Xinran Tinney has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 14: (16 comments)

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has abandoned this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Abandoned Per conversation on user@, folks are interested in keeping this around.

[Impala-ASF-CR] Add KuduDataTypeToColumnType default case

2018-02-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9283 ) Change subject: Add KuduDataTypeToColumnType default case .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add KuduDataTypeToColumnType default case

2018-02-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9283 Change subject: Add KuduDataTypeToColumnType default case .. Add KuduDataTypeToColumnType default case Given the Impala build breaks when

[Impala-ASF-CR] IMPALA-6077: remove Parquet BIT PACKED def level support

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9241 ) Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6077: remove Parquet BIT PACKED def level support

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9241 ) Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9239 to look at the new patch set (#3). Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9271 to look at the new patch set (#5). Change subject: IMPALA-6497: add "Last row fetched" and AC events ..

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9288 Change subject: IMPALA-6489: use correct template tuple size .. IMPALA-6489: use correct template tuple size The bug was that we mixed

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9288 ) Change subject: IMPALA-6489: use correct template tuple size .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9288 ) Change subject: IMPALA-6489: use correct template tuple size .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: (22 comments)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 1: I think this is a good start,

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (7 comments) The high level

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 3: Looks good! did you miss checking in the changes

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9271 to look at the new patch set (#4). Change subject: IMPALA-6497: add "Last row fetched" and AC events ..

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6077: remove Parquet BIT PACKED def level support

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9241 ) Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support .. IMPALA-6077: remove Parquet BIT_PACKED def

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 9: (14 comments) main changes: (1) minimized

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#10). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9288 ) Change subject: IMPALA-6489: use correct template tuple size .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9288 ) Change subject: IMPALA-6489: use correct template tuple size .. IMPALA-6489: use correct template tuple size The bug

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 4: (4 comments) Thanks for the review, please see my inline comments and

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#5). Change subject: IMPALA-6508: add KRPC test flag ..

[Impala-ASF-CR] IMPALA-6511: Fix state machine in FIS::UpdateState()

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9294 ) Change subject: IMPALA-6511: Fix state machine in FIS::UpdateState() .. Patch Set 1: Tim, do you have time for a quick look? -- To

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. IMPALA-5440: Add planner tests with

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 9:

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-12 Thread Xinran Tinney (Code Review)
Xinran Tinney has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9288 ) Change subject: IMPALA-6489: use correct template tuple size .. Patch Set 1: Build started:

[Impala-ASF-CR] updated PR to include Michael's review comments

2018-02-12 Thread Anonymous Coward (Code Review)
njanartha...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9290 Change subject: updated PR to include Michael's review comments .. updated PR to include Michael's review comments

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 8: Code-Review+2

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 5: (3 comments) I found a bug which is unrelated to this

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6508: add krpc test flag

2018-02-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#4). Change subject: IMPALA-6508: add krpc test flag ..

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9287 to look at the new patch set (#2). Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 2: Code-Review+2 (1 comment) Fixed comment from

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

2018-02-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9286 Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters .. IMPALA-6509: [docs] Note for haproxy for Kerberized

[Impala-ASF-CR] [docs] Removed the obsolete Llama options files

2018-02-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: We remove the "removed" features from docs. -- To

[Impala-ASF-CR] IMPALA-6508: add krpc test flag

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add krpc test flag .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6499: [docs] Fixed formatting errors in split part function

2018-02-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9275 Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part function .. IMPALA-6499: [docs] Fixed formatting errors in

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8363 to look at the new patch set (#8). Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 7: (4

[Impala-ASF-CR] updated PR to include Michael's review comments

2018-02-12 Thread Anonymous Coward (Code Review)
njanartha...@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/9290 ) Change subject: updated PR to include Michael's review comments .. Abandoned fixup commit to another PR -- To view, visit

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9287 to review the following change. Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: Is this a clean cherry-pick ? -- To view, visit

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Xinran Tinney (Code Review)
Xinran Tinney has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Xinran Tinney (Code Review)
Xinran Tinney has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. IMPALA-5440: Add planner tests with extreme statistics

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#16). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (1 comment) Applied the update.

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5440: Add planner tests with extreme statistics values

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440: Add planner tests with extreme statistics values .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: No, I picked it by hand since the original change

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 9:

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8363 to look at the new patch set (#9). Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 9:

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 12: Verified-1 Build

[Impala-ASF-CR] DRAFT IMPALA-6508: add krpc test flag

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9291 Change subject: DRAFT IMPALA-6508: add krpc test flag .. DRAFT IMPALA-6508: add krpc test flag This change adds a flag "--use_krpc" to

[Impala-ASF-CR] DRAFT IMPALA-6508: add krpc test flag

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: DRAFT IMPALA-6508: add krpc test flag .. Patch Set 3: I'm currently running a private build to validate that the new

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (3 comments) A few initial questions.

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9271 to look at the new patch set (#6). Change subject: IMPALA-6497: add "Last row fetched" and AC events

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-6511: Fix state machine in FIS::UpdateState()

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9294 ) Change subject: IMPALA-6511: Fix state machine in FIS::UpdateState() .. Patch Set 1: Code-Review+2 Seems much simpler -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-12 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#25). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (3 comments)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 13: Code-Review+2 fixed

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-12 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#13). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

  1   2   >