[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-22 Thread Abhishek Sharma (Code Review)
Abhishek Sharma has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. IMPALA-5392: Added all stack frames to ThreadInfo

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 14: Looks like you'll have conflicts with this:

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-22 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#15). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 10: Code-Review+2 forgot to rebase before merge -- To view,

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 2: Code-Review+2 (2 comments) carry

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10479 to look at the new patch set (#2). Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. IMPALA-6953: part 2:

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-22 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10483 Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. IMPALA-7044: Prevent overflow when computing Parquet

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10481 Change subject: [DOCS] Not able to create new tables when the statestore is offline .. [DOCS] Not able to create new tables when the

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. [DOCS] Not able to create new tables when the

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 9: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Tim, thanks for pointing that out. I

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-22 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10482 Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. [DOCS] Added a link to impala kerberos doc in

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. IMPALA-6813: Hedged

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 14: Next change handles the merge. It was

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks ..

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 12: (3 comments)

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10479 Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. IMPALA-6953: part 2: clean up DiskIoMgr Follow-on changes. I separated this

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10245 to look at the new patch set (#9). Change subject: IMPALA-6953: part 1: clean up DiskIoMgr ..

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 7: (3 comments)

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10480 Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to 3.5.1 Protobuf 3.0.0+ has support for both v2 and v3 of protobuf syntax.

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-05-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10478 Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. IMPALA-6917: Implement COMMENT ON TABLE/VIEW This patch implements

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 5:

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: > It looks like this got stalled. Jim, do you

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: > preads add some overhead to

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#13). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: Code-Review+2 Do we know what

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: Code-Review+2 preads add

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 8: Code-Review+2 (1 comment) Looks good to me. The commit message could

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-05-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 12: Code-Review+1 forgot to carry +1 -- To view,

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#4). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10245 to look at the new patch set (#8). Change subject: IMPALA-6953: clean up DiskIoMgr .. IMPALA-6953:

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 8: Code-Review+1 carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 5:

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#5). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 5:

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 11: (30 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#12). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: Sailesh: Even though it

[Impala-ASF-CR] IMPALA-7048: Failed test: query test.test parquet page index.TestHdfsParquetTableIndexWriter.test write index many columns tables

2018-05-22 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10476 ) Change subject: IMPALA-7048: Failed test: query_test.test_parquet_page_index.TestHdfsParquetTableIndexWriter.test_write_index_many_columns_tables

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 12: (5 comments) Looks nice. Please go ahead and rebase

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: > Sailesh: Even though it

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: > (1 comment) > > Rebase. Do you have time to take a look Joe?

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: Code-Review+1 (5 comments) I had already started looking earlier this