[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0 .. IMPALA-4554: fix projection of nested collections with mt_dop > 0 Change-Id:

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 2: (6 comments) The change looks good aside from some minor comments. I think we

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Code-Review+1 Let's someone else have a look. -- To view, visit

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. The bug was that

Re: [Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Dimitris Tsirogiannis
Looking into it now. Dimitris On Tue, Nov 29, 2016 at 10:12 PM, Bharath Vissapragada (Code Review) wrote: > Bharath Vissapragada has posted comments on this change. > > Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata > loading >

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. IMPALA-4450: qgen: use string concatenation operator for postgres queries

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5034 To

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 7: Code-Review+1 (8 comments) Thanks for the review. Please see

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 6: Code-Review+1 this is just a rebase; next patch set will address

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 2: Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/56/ -- To view, visit

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. The bug was that

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5242/2/tests/run-tests.py

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Jim Apple (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5242 to look at the new patch set (#3). Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. ..

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/57/ --

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. Patch Set 3: Code-Review+2 (1 comment) carry +2

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#5). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#7). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] Fix undefined cals to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5278 Change subject: Fix undefined cals to __builtin_ctz. .. Fix undefined cals to __builtin_ctz. GCC's __builtin_ctz[l[l]] functions return

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-30 Thread David Knupp (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5177 to look at the new patch set (#4). Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 13: (13 comments)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#8). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 5: (5 comments) Henry, could you take a look at patchset 6? The changes to

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#6). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#9). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 7: > Uploaded patch set 7. Fixed a comment about cancellation which, I

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 6: (2 comments)

[Impala-ASF-CR] Fix undefined cals to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5004 to look at the new patch set (#3). Change subject: Fix undefined cals to __builtin_ctz. .. Fix undefined cals to

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has restored this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Restored No longer needed for stats, but might as well eliminate undefined behavior -- To view, visit

[Impala-ASF-CR] Fix undefined cals to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: Fix undefined cals to __builtin_ctz. .. Abandoned https://gerrit.cloudera.org/#/c/5004/ -- To view, visit http://gerrit.cloudera.org:8080/5278 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5250

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 2: (5 comments) Agree completely about doing more stress/ASAN runs.

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. The bug was that

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 13: (13 comments)

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5004 to look at the new patch set (#4). Change subject: Fix undefined calls to __builtin_ctz. .. Fix undefined calls

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 5: (11 comments) Did a quick first pass.

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5148 to look at the new patch set (#14). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading ..

[Impala-ASF-CR] Fix undefined cals to builtin ctz.

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix undefined cals to __builtin_ctz. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5004/3/be/src/udf_samples/hyperloglog-uda.cc File

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix undefined calls to __builtin_ctz. .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5004/3/be/src/udf_samples/hyperloglog-uda.cc File

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5242 To

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. IMPALA-4543: Properly escape ignored tests subdirectories. In the shell,

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/4418/5/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5281 Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. IMPALA-4557: Fix flakiness with

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#6). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 3: Rebased -- To view, visit http://gerrit.cloudera.org:8080/5251 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 13: (1 comment)

[Impala-ASF-CR] Bracketing Java logging output with log level checks.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5284 Change subject: Bracketing Java logging output with log level checks. .. Bracketing Java logging output with log level checks. This

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5261 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5261 To unsubscribe, visit

[Impala-ASF-CR] Start a docs build system.

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile File docs/Makefile: > I considered it, but I

[Impala-ASF-CR] Start a docs build system.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile File docs/Makefile: > I guess my feeling is that

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5267 To unsubscribe,

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. IMPALA-4550: Fix CastExpr analysis for substituted slots During slot substitution, the

[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5270 To

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5281 To unsubscribe,

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: > What about the try/catch block in timestamp-functions-ir.cc. > Shouldn't that

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h File

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-11-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 1: This is still being tested. David is going to test this with some Kudu changes going in to

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#10). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 15: Code-Review+2 (2 comments) Nice!

[Impala-ASF-CR] IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support

2016-11-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5295 To

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Fix undefined calls to __builtin_ctz. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 2: (1 comment) This is a great fix! Pretty minimal. I think there is an

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. Patch Set 2: (7 comments)

[Impala-ASF-CR] Bracketing Java logging output with log level checks.

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Bracketing Java logging output with log level checks. .. Bracketing Java logging output with log level checks. This reduces creation of intermediate

[Impala-ASF-CR] Bracketing Java logging output with log level checks.

2016-11-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bracketing Java logging output with log level checks. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5284 To unsubscribe,

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3125: Fix assignment of equality predicates from an outer-join On-clause.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3125: Fix assignment of equality predicates from an outer-join On-clause. .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Dan Hecht (Code Review)
Hello Henry Robinson, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5250 to look at the new patch set (#11). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

[Impala-ASF-CR] Bracketing Java logging output with log level checks part 2.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5297 Change subject: Bracketing Java logging output with log level checks part 2. .. Bracketing Java logging output with log level checks part 2.

[Impala-ASF-CR] IMPALA-4303: Do not reset() qualifier of union operands.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4303: Do not reset() qualifier of union operands. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Bracketing Java logging output with log level checks part 2.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: Bracketing Java logging output with log level checks part 2. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5297 To

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Fix undefined calls to __builtin_ctz. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Fix undefined calls to __builtin_ctz. .. Fix undefined calls to __builtin_ctz. GCC's __builtin_ctz[l[l]] functions return undefined results

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix undefined calls to __builtin_ctz. .. Patch Set 5: Code-Review+1 rebase carry tim's +1 -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe,

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: I moved the parsing code into the lexer and parser. This changed some of the error behavior, where errors

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5148 to look at the new patch set (#16). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5148 to look at the new patch set (#15). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading ..

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5281 to look at the new patch set (#2). Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc ..

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-11-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5288 Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add flag for Kudu read-your-writes The previous

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4418/5/be/src/runtime/query-exec-mgr.cc

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 15: Code-Review+1 New changes lgtm, Nice catch with the useless map, Dimitris! -- To

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 16: Code-Review+2 Carrying +2. I'm running S3 core/hdfs core/hdfs exhaustive

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 9: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5259 to look at the new patch set (#2). Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] Fix undefined calls to builtin ctz.

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix undefined calls to __builtin_ctz. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-11-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h File

  1   2   >