[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 2: (41 comments)

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5683 to look at the new patch set (#4). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-18 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5726/3/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/194/ -- To

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 3: (2 comments)

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (2 comments) All comments addressed. I suggest we expedite the +2'ing of this one so we can get a

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 4: Code-Review+2 Okay. Was wondering if it was for that dcheck; this makes it clear.

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/5161/10/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 11: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5630 To

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe,

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-18 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: Updates to DML statements for Impala + Kudu .. Updates to DML statements for Impala + Kudu Fill in syntax, usage notes, examples for UPDATE, DELETE, UPSERT. Take

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/5710/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5683 to look at the new patch set (#6). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 6: Code-Review+2 There was a mistake in merging when I rebased. Fixed it. -- To

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 1: (8 comments) The general approach looks good - mainly the comments are

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. IMPALA-4549: consistently treat as upper bound for timestamp

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: A couple -- Isso and Disqus. Disqus seemed the best so far. Isso didn't even render

[Impala-ASF-CR] Add doc for MT DOP query option.

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add doc for MT_DOP query option. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5683 to look at the new patch set (#5). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (12 comments) I need to read through the test code but I thought I'd flush out my

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5726/3/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. HIVE-15653 is a Hive Metastore bug

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5683

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 10: (7 comments) Looking good. Most comments about comments.

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (33 comments) Still have more to go (mostly in buffer-pool.cc) but here's another set of

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5731 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (1 comment)

[Impala-ASF-CR] Major update to Impala + Kudu page

2017-01-18 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#5). Change subject: Major update to Impala + Kudu page .. Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and other Kudu notions.

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (3 comments) some preliminary comments

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-18 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: IMPALA-1654: DDL for multiple partitions .. IMPALA-1654: DDL for multiple partitions Syntax and usage notes for ALTER TABLE, COMPUTE STATS, and SHOW FILES. Mixed

[Impala-ASF-CR] Major update to Impala + Kudu page

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Major update to Impala + Kudu page .. Patch Set 4: (7 comments) Addressed comments through the 'EXPLAIN' topic.

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: Marcel, can you plz look at patch set 2 instead. Several things changed and

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5683 To

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-18 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5729 Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. IMPALA-4390: Separate ADD and DROP PARTITION syntax Keep the

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 2: I'll start this review now. -- To view, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#11). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: (2 comments)

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: Have you had a chance to test this with a commenting system? -- To view, visit

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Global search/replace: audience="Cloudera" -> audience="hidden". .. Patch Set 3: Code-Review+2 Resolved another merge conflict, tidied up a couple more instances

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Global search/replace: audience="Cloudera" -> audience="hidden". .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5613 To

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5732 Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 4: (1 comment) I didn't mean to push out PS8 - PS9 reverts the PS8 change.

[Impala-ASF-CR] Improve substitution variables.

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Improve substitution variables. .. Improve substitution variables. Fix the version numbers that show up in titles and in lead-ins, e.g. "

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 4: Build started:

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-18 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5613 to look at the new patch set (#3). Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_update.xml File

[Impala-ASF-CR] Improve substitution variables.

2017-01-18 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5661 to look at the new patch set (#2). Change subject: Improve substitution variables. .. Improve substitution

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. HIVE-15653 is a Hive Metastore bug

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned

[Impala-ASF-CR] Improve substitution variables.

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Improve substitution variables. .. Patch Set 2: Code-Review+2 Fixed merge conflict. Rebuilt PDF and confirmed the substitution changes are still effective. --

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-18 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: Updates to DML statements for Impala + Kudu .. Updates to DML statements for Impala + Kudu Fill in syntax, usage notes, examples for UPDATE, DELETE, UPSERT. Take

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_delete.xml File

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Global search/replace: audience="Cloudera" -> audience="hidden". .. Global search/replace: audience="Cloudera" -> audience="hidden". For this

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 5: (2 comments) Discussed a couple of the outstanding comments offline with Marcel. Made

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5731 Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. IMPALA-4767: Workaround for HIVE-15653 to preserve table

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File

[Impala-ASF-CR] Improve substitution variables.

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Improve substitution variables. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/20/ -- To view, visit

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Tim Armstrong (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5665 to look at the new patch set (#5). Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 5: Code-Review+2 Rebase - carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 6: Dry-run of tests:

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 1: Quick question: how long does expr-test take to run now? -- To view,

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5663/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 1: Quite a bit longer. 5~6 mins in debug builds on my machine. I think it's

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/5668/3/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/coordinator.cc File

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (10 comments)