[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMPALA-3748: add query-wide resource acquisition step This adds a Prepare() method to

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 8: (15 comments) Addressed some early comments from Dimitris and Todd that I skipped over before. (Some

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#8). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS] Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and other

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5739 To

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 4: (32 comments) Did all of the recent comments. I see some earlier ones still to do.

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/206/ -- To

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/206/

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/207/ -- To

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5772 To

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: There's probably no reason not to. I went ahead and pushed a version with comments

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] Add nested testdata flattener

2017-01-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5787 Change subject: Add nested testdata flattener .. Add nested testdata flattener The TableFlattener takes a nested dataset and

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function names

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/209/ -- To

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5788 Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. IMPALA-4820: avoid writing unencrypted data

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/209/ -- To

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 1: (1 comment) Nice change. A suggestion below.

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 4: (5 comments)

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#5). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/5792 Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation. Simple implementation of to_date() that

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 6: (38 comments) http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/case-expr.cc File

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5791 Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation.

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#7). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5640/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#9). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS] Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and other

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: > There's probably no reason not to. I went ahead and pushed a > version with

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5784 Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. IMPALA-4818: Ensure the same number of tests are run

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 4: (5 comments)

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: > > There's probably no reason not to. I went ahead and pushed a > > version with

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-24 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: Updates to DML statements for Impala + Kudu .. Updates to DML statements for Impala + Kudu Fill in syntax, usage notes, examples for UPDATE, DELETE, UPSERT. Take

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5785 Change subject: Remove "Git repository" from navigation bar. .. Remove "Git repository" from navigation bar. It is not in the navigation

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 7: (25 comments) http://gerrit.cloudera.org:8080/#/c/5649/7/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 1: Dry-run: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/208/ -- To view,

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Remove "Git repository" from navigation bar. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5785 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#10). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS] Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 3: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/207/ -- To

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 6: (1 comment) One final issue. I'm assuming that we're going to rename