[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#13). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#14). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8233 to look at the new patch set (#2). Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Lars Volker (Code Review)
Hello Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8240 to look at the new patch set (#4). Change subject: IMPALA-6023: Fix broken breakpad test ..

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 3: (6 comments) This is definitely going to

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 3: (3 comments) Thanks for looking into this.

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#4). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (17 comments) Some initial comments.

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip) .. Patch Set 1: This seems pretty beneficial - a 1-2s

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-10 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8196 to look at the new patch set (#7). Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ..

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 15: Verified+1 -- To

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-10 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#4). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. IMPALA-6023: Fix broken breakpad test We have a test to make

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#6). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 8: Thanks for the contribution!

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8233 to look at the new patch set (#3). Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-10 Thread Bharath Vissapragada (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8235 to look at the new patch set (#5). Change subject: IMPALA-5429: Multi threaded block metadata loading .. IMPALA-5429:

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

2017-10-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8255 Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. IMPALA-5940: Avoid log spew by using Status::Expected() This

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 6: (1 comment) I've been meaning to do another full pass

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#7). Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

2017-10-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)