[kudu-CR] Move maintenance manager to server/

2017-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move maintenance_manager to server/ .. Patch Set 1: Code-Review-1 I'd like to eventually use the MM in the log block manager to clean up full containers with no

[kudu-CR] design docs: Add tablet history GC design doc

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: design docs: Add tablet history GC design doc .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2853/4/docs/design-docs/tablet-history-gc.md File

[kudu-CR] docs: Allow make site.sh to skip javadoc generation

2017-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: docs: Allow make_site.sh to skip javadoc generation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6505 To unsubscribe, visit

[kudu-CR] docs: Allow make site.sh to skip javadoc generation

2017-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: docs: Allow make_site.sh to skip javadoc generation .. docs: Allow make_site.sh to skip javadoc generation This patch adds the ability to skip javadoc

[kudu-CR] docs: Add documentation for background tasks

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add documentation for background tasks .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6501/4/docs/background_tasks.adoc File

[kudu-CR] docs: Add breakpad documentation to user guide

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add breakpad documentation to user guide .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6504/1/docs/minidumps.adoc File

[kudu-CR] docs: Add documentation for background tasks

2017-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: docs: Add documentation for background tasks .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6501 To unsubscribe, visit

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6078/11/src/kudu/common/schema.h File

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#13). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#12). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 13: Addressed Todd's comments. The jenkins testcase failure is unrelated to this change. -- To view,

[kudu-CR] Move maintenance manager to server/

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Move maintenance_manager to server/ .. Patch Set 1: hrm, maybe we should just bite the bullet and make src/maintenance? My issue with 'common' is that that

[kudu-CR] design docs: Add tablet history GC design doc

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: design docs: Add tablet history GC design doc .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2853/4/docs/design-docs/tablet-history-gc.md File

[kudu-CR] Move maintenance manager to server/

2017-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move maintenance_manager to server/ .. Patch Set 1: > hrm, maybe we should just bite the bullet and make src/maintenance? > My issue with 'common' is that that

[kudu-CR] design docs: Fix bad markdown formatting in tablet.md

2017-03-29 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: design docs: Fix bad markdown formatting in tablet.md .. design docs: Fix bad markdown formatting in tablet.md Level 1 headings are only allowed to have a

[kudu-CR] design docs: Fix bad markdown formatting in tablet.md

2017-03-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: design docs: Fix bad markdown formatting in tablet.md .. Patch Set 3: Thanks, let's just fix this here for now -- To view, visit

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890 Allow renaming of primary key column Removed the checks preventing renaming of primary key

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 13: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe,

[kudu-CR] design docs: Add tablet history GC design doc

2017-03-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: design docs: Add tablet history GC design doc .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2853/4/docs/design-docs/tablet-history-gc.md

[kudu-CR] design docs: Add tablet history GC design doc

2017-03-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: design docs: Add tablet history GC design doc .. Patch Set 4: (2 comments)

[kudu-CR] docs: Add documentation for background tasks

2017-03-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: Add documentation for background tasks .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6501/4/docs/background_tasks.adoc File

[kudu-CR] interval tree: improve an O(n) loop to O(lg n)

2017-03-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: interval_tree: improve an O(n) loop to O(lg n) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6496 To unsubscribe, visit

[kudu-CR] Persistent cache support for NVM

2017-03-29 Thread Sarah Jelinek (Code Review)
Sarah Jelinek has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 22: Keeping changes up to date with master. Need to fix some nits apparently. -- To view, visit

[kudu-CR] interval tree: improve an O(n) loop to O(lg n)

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: interval_tree: improve an O(n) loop to O(lg n) .. interval_tree: improve an O(n) loop to O(lg n) In the interval tree implementation, we were scanning

[kudu-CR] [scanners] info message on scanner expiration is back

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [scanners] info message on scanner expiration is back .. [scanners] info message on scanner expiration is back Despite of the TODO, logging about expired

[kudu-CR] [scanners] info message on scanner expiration is back

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [scanners] info message on scanner expiration is back .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6435 To unsubscribe, visit

[kudu-CR] [docs] Add security guide

2017-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/6479/1/docs/security.adoc File docs/security.adoc: Line 31: access

[kudu-CR] [docs] Add security guide

2017-03-29 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6479 to look at the new patch set (#2). Change subject: [docs] Add security guide .. [docs] Add security guide