[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-28 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 5: (3 comments) Updated with the specified changes.

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-28 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12141 to look at the new patch set (#6). Change subject: KUDU-2411: Add OS/Arch detection to binary extract

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [java] deflake RYW tests in TestKuduClient .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12276 To unsubscribe, visit

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 ) Change subject: [java] deflake RYW tests in TestKuduClient .. Patch Set 3: Verified+1 Unrelated flaky test. -- To view, visit

[kudu-CR] [java] enable regression test for KUDU-2415

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12278 ) Change subject: [java] enable regression test for KUDU-2415 .. Patch Set 2: Code-Review+2 Carry Andrew's +2 from last patch -- To view,

[kudu-CR] [java] enable regression test for KUDU-2415

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12278 ) Change subject: [java] enable regression test for KUDU-2415 .. [java] enable regression test for KUDU-2415 As KUDU-2463 fixed the

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 ) Change subject: [java] deflake RYW tests in TestKuduClient .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2662 TestKuduClient.testClientLocation is flaky

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12289 Change subject: KUDU-2662 TestKuduClient.testClientLocation is flaky .. KUDU-2662 TestKuduClient.testClientLocation is flaky At least

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 5: Verified+1 -- To view, visit

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 15: (2 comments) One small thing and it's good to go! Thanks. This is a

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 2: (1 comment) Looks reasonable to me!

[kudu-CR] [spark] Add write duration histograms

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12261 ) Change subject: [spark] Add write duration histograms .. Patch Set 1: (1 comment)

[kudu-CR] docs: add warning about overlapping directories

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12013 ) Change subject: docs: add warning about overlapping directories .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 2: Code-Review+2 LGTM but would appreciate addressing PhilZ's

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Patch Set 8: Code-Review-2 I'm looking into whether it's possible to

[kudu-CR] [tools] Describe more table attributes

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 ) Change subject: [tools] Describe more table attributes .. Patch Set 2: (10 comments) Looks pretty good. Thanks for adding this.

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 ) Change subject: [java] deflake RYW tests in TestKuduClient .. Patch Set 3: (3 comments)

[kudu-CR] docs: add warning about overlapping directories

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12013 ) Change subject: docs: add warning about overlapping directories .. docs: add warning about overlapping directories There

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12276 to look at the new patch set (#4). Change subject: [java] deflake RYW tests in TestKuduClient ..

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12276 ) Change subject: [java] deflake RYW tests in TestKuduClient .. [java] deflake RYW tests in TestKuduClient RYW tests in

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-28 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 5: What about a link to a sample script or an inline

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. rpc: add TCP socket

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 2: (1 comment)

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2662 TestKuduClient.testClientLocation is flaky

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12289 ) Change subject: KUDU-2662 TestKuduClient.testClientLocation is flaky .. KUDU-2662 TestKuduClient.testClientLocation is flaky

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 5: > What about a link to a sample script or an

[kudu-CR] [tools] Describe more table attributes

2019-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 ) Change subject: [tools] Describe more table attributes .. Patch Set 3: (10 comments)

[kudu-CR] KUDU-2662 TestKuduClient.testClientLocation is flaky

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12289 ) Change subject: KUDU-2662 TestKuduClient.testClientLocation is flaky .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] deflake RYW tests in TestKuduClient

2019-01-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 ) Change subject: [java] deflake RYW tests in TestKuduClient .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [tools] Describe more table attributes

2019-01-28 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12281 to look at the new patch set (#3). Change subject: [tools] Describe more table attributes ..

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 5: (2 comments) cool post, enjoyed catching up on what

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. rpc: add TCP socket statistics to /rpcz This adds the ability to

[kudu-CR] [gradle] Increase test JVMs heap size

2019-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 ) Change subject: [gradle] Increase test JVMs heap size .. Patch Set 1: > I am okay with this. > > Though, I would like to understand why

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#17). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 17: (1 comment)

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#16). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 16: Yes, and I saw some reduplicate code in tool_action_perf.cc, I will do