[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#9). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

2019-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12932 Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. [kudu-tool-test] deflake

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-04 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#8). Change subject: WIP [master] introduced SentryPrivilegesFetcher

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 8: > Uploaded patch set 8. I'm thinking to

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: > Overall looks good to me structurally, some nits

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: java/c++: ColumnSchema supports storing column comment .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12890 To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: Verified+1 An unrelated Java flaky. -- To

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 8: Verified+1 unrelated flakies in: *

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#4). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 4: Code-Review+1 (3 comments) Looks good to me, but

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 4: (16 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: (1 comment)

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12933 Change subject: Enable tcmalloc heap sampling by default .. Enable tcmalloc heap sampling by default This enables tcmalloc heap

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: Code-Review+1 sgtm. We've had this on on a test cluster for

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Mitch Barnett, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12933 to look at the new patch set (#2). Change subject: Enable tcmalloc heap sampling by default

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: (1 comment) I vaguely remember this coming up before. Did we

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: (1 comment) > I vaguely remember this coming up before. Did

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] util: pull Random methods out from tests

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. util: pull Random methods out from tests I've found a couple of

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#5). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 5: (1 comment)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#10). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: Code-Review+1 (2 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: (2 comments)

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe,

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Verified+1 unrelated Java flake in TSAN build -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. java/c++: ColumnSchema supports storing column comment

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (14 comments) Sorry I'm late to the party; hope this

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (1 comment)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#8). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#9). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12936 to review the following change. Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: Thanks a lot for the patch - I'm going to re-base

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#10). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: (1 comment)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 7: (2 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: (9 comments)

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Enable tcmalloc heap sampling by default .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12933 To unsubscribe, visit

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Enable tcmalloc heap sampling by default This enables tcmalloc

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 2: Verified+1 The flake is KUDU-2564. -- To view, visit

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#6). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#7). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 7: (7 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: (2 comments) Looks good, just two typos.

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. Patch Set 1: (3 comments)