[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+2 (1 comment) Fix the one misspelling and

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: > Patch Set 1: Code-Review+1 > > I don't have the ability

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+1 I don't have the ability to test this since I

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Verified+1 unrelated Java flake in TSAN build -- To

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe,

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2019-04-04 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12936 to review the following change. Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-21 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-21 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: it was verified to work with and without installing

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-21 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: Verified+1 -- To view, visit

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: Code-Review+2 Assuming it works... -- To view, visit

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: (4 comments)

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-08 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe,

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-08 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#5). Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 4: (4 comments)

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 4: (4 comments)

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#4). Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 3: (4 comments)

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#3). Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#2). Change subject: [build] Fix bulding codegen on MacOS Mojave

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

2018-12-07 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12054 to review the following change. Change subject: [build] Fix bulding codegen on MacOS Mojave