[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Posting a transcript of a side chat, for posterity: ... [1:12 PM] David Alves: no, no other

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Thinking a bit more which constraint we actually want to enforce. I think we need to enforce

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Right, that's definitely a valid concern: on-disk isn't the only place we can "persist" the data. Ri

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc File src/ku

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: I like the changes in general (post specific comments in a few mins). One concern that I hav

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11/src/kudu/tablet/mvcc.h File src/kudu/tablet/

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-19 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#12). Change subject: Allow tablet shutdown without completing txs .. Allow tablet sh

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (12 comments) Not yet ready for review. http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG Com

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG Commit Message: Line 21: Testin

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG Commit Message: Line 21: Testin

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (11 comments) http://gerrit.cloudera.org:8080/#/c/7439/11/src/kudu/tablet/mvcc.h File src/kudu/table

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#11). Change subject: Allow tablet shutdown without completing txs .. Allow tablet sh

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#10). Change subject: Allow tablet shutdown without completing txs .. Allow tablet sh

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 8: (7 comments) Also as per our slack discussion, rather than making use of tablet::FAILED, which in ht

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#9). Change subject: Allow tablet shutdown without completing txs .. Allow tablet shu