Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-2871 https://issue

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/ --- (Updated June 26, 2015, 12:47 a.m.) Review request for mesos, Adam B, Till Toen

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/#review89475 --- Ship it! Ship It! - Adam B On June 26, 2015, 12:47 a.m., Bernd M

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/#review89476 --- Ship it! Ship It! - Kapil Arya On June 26, 2015, 3:47 a.m., Bern

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/#review89477 --- Patch looks great! Reviews applied: [35917] All tests passed. - M

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated June 26, 2015, 3:12 a.m.) Review request for mesos, Ben Mahler and Nik

Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-2877 https

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 26, 2015, 12:18 p.m.) Review request for mesos, Adam B and Till T

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

> On June 24, 2015, 6:41 p.m., Ben Mahler wrote: > > Actually, we should think about one more thing, how does this interact with > > the zookeeper session timeout? The hardcoded individual ping timeout (15secs) was previously longer than the default zk session timeout (10secs), but the zk sess

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review89482 --- Patch looks great! Reviews applied: [29507] All tests passed. - M

Review Request 35920: Change EXPECT to ASSERT when relying in the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/ --- Review request for mesos, Bernd Mathiske and Timothy Chen. Repository: mesos

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89483 --- Patch looks great! Reviews applied: [35919] All tests passed. - M

Re: Review Request 35920: Change EXPECT to ASSERT when relying in the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/#review89484 --- Ship it! Ship It! - Bernd Mathiske On June 26, 2015, 4:27 a.m.,

Re: Review Request 35920: Change EXPECT to ASSERT when relying in the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/#review89488 --- Patch looks great! Reviews applied: [35920] All tests passed. - M

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/ --- (Updated June 26, 2015, 1:12 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/#review89503 --- Ship it! Ship It! - Michael Park On June 26, 2015, 1:12 p.m., Jo

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/ --- (Updated June 26, 2015, 3:24 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 32982: [WIP] Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 3:36 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: [WIP] Added reservation user guide.

> On May 8, 2015, 7:02 p.m., Timothy Chen wrote: > > docs/reservation.md, line 25 > > > > > > existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0? I went with `introduced in 0.14.0` instead. - Mic

Re: Review Request 32982: [WIP] Added reservation user guide.

> On May 11, 2015, 9:51 a.m., Joerg Schad wrote: > > docs/reservation.md, line 25 > > > > > > s/existed prior/available since version x.x.x? I went with `introduced in 0.14.0` here. - Michael --

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 4:04 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89512 --- Patch looks great! Reviews applied: [32982] All tests passed. - M

Review Request 35927: Added TaskStatus::Reason to Termination Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035 https://

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 4:54 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

> On May 8, 2015, 7:02 p.m., Timothy Chen wrote: > > docs/reservation.md, line 243 > > > > > > What happens if you try to unreserve a reservation that is being used > > right now? The reason why we go through the off

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 5:04 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89518 --- Patch looks great! Reviews applied: [35927] All tests passed. - M

Re: Review Request 35861: Correct include list errors for stout

> On June 25, 2015, 10:35 p.m., Kapil Arya wrote: > > The ordering parts looks good. Should we also fix the differentiation > > between `#include ` and `#include "os.hpp"`? I would prefer to not make any changes here that are not required by the style guide or cannot be automatically enforced,

Re: Review Request 35757: Refactored OSNetUri tests for Fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35757/ --- (Updated June 26, 2015, 5:38 p.m.) Review request for mesos and Joris Van Remoo

Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 6:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89532 --- Patch looks great! Reviews applied: [32982] All tests passed. - M

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 6:13 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote: > > docs/reservation.md, line 168 > > > > > > "state of the recources" - what does this mean? > > > > Suggestion: "resource specifications" I've updated th

Re: Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/#review89534 --- Ship it! 3rdparty/libprocess/include/process/http.hpp (line 444) <

Re: Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/ --- (Updated June 26, 2015, 6:30 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35717: Add reservations support to master's state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review89538 --- I made a minor naming comment, which I'll get cleaned up for you. I

Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod

Re: Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/#review89543 --- Ship it! Ship It! - Marco Massenzio On June 26, 2015, 6:58 p.m.,

Re: Review Request 35717: Add reservations support to master's state.json

> On June 26, 2015, 11:44 a.m., Ben Mahler wrote: > > I made a minor naming comment, which I'll get cleaned up for you. > > > > Is there a plan to consistently add reserved and unreserved to the other > > resources? e.g. used and offered. > > Curious if you thought about how to express volumes

Re: Review Request 35717: Add reservations support to master's state.json

> On June 26, 2015, 6:44 p.m., Ben Mahler wrote: > > src/common/http.cpp, line 84 > > > > > > How about calling this 'roleResources' to be clear that this is a role > > breakdown, rather than say, a type, name, etc bre

Re: Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/#review89546 --- Ship it! Ship It! - Michael Park On June 26, 2015, 6:58 p.m., Is

Re: Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/#review89547 --- Patch looks great! Reviews applied: [35934, 35939] All tests passe

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 7:53 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote: > > docs/reservation.md, line 95 > > > > > > This sentence does not strictly add any information. It is more likely > > confusing. What does it mean to "convert" a r

Re: Review Request 32982: Added reservation user guide.

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: > > docs/reservation.md, line 71 > > > > > > this seems to imply that in the Request, the `slave_id` is some part of > > a "form" submission: > > ``` > > -d

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89551 --- Patch looks great! Reviews applied: [32982] All tests passed. - M

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 8:33 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 8:35 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

> On May 8, 2015, 7:02 p.m., Timothy Chen wrote: > > docs/reservation.md, line 79 > > > > > > A notable difference between static reservation is the principal here, > > are you going to cover that? Thanks for bringing

Re: Review Request 32982: Added reservation user guide.

> On May 11, 2015, 9:51 a.m., Joerg Schad wrote: > > docs/reservation.md, line 25 > > > > > > s/existed prior/available since version x.x.x? > > Michael Park wrote: > I went with `introduced in 0.14.0` here. Actua

Re: Review Request 32982: Added reservation user guide.

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: > > docs/reservation.md, lines 97-100 > > > > > > Let us please add at least a suggestion of the possible error codes > > (and a couple Response bodies) here too -

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 26, 2015, 8:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: Added reservation user guide.

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: > > docs/reservation.md, line 71 > > > > > > this seems to imply that in the Request, the `slave_id` is some part of > > a "form" submission: > > ``` > > -d

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89559 --- Ship it! docs/mesos-c++-style-guide.md (line 535)

Review Request 35914: Removed a TODO that is no longer relevant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35914/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1988 https://issues.ap

Review Request 35909: Removed an unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35909/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 35912: Updated createdStatusUpdate to not set the UUID for master-generated updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35912/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-2940 https://i

Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 35911: Moved StatusUpdate.uuid from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35911/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-2940 https://i

Review Request 35943: Removed a stale TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35943/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89562 --- Patch looks great! Reviews applied: [32982] All tests passed. - M

Re: Review Request 35943: Removed a stale TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35943/#review89564 --- Ship it! Ship It! - Michael Park On June 26, 2015, 9:11 p.m., Be

Re: Review Request 35909: Removed an unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35909/#review89563 --- Ship it! Ship It! - Michael Park On June 26, 2015, 9:11 p.m., Be

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/#review89565 --- Just a question: what do we mean by a "pure client" here? - Michael

Review Request 35935: Added a simulation benchmark for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-2941 https://i

Re: Review Request 35909: Removed an unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35909/#review89568 --- Ship it! Ship It! - Vinod Kone On June 26, 2015, 9:11 p.m., Ben

Re: Review Request 35914: Removed a TODO that is no longer relevant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35914/#review89571 --- Ship it! Ship It! - Vinod Kone On June 26, 2015, 9:11 p.m., Ben

Re: Review Request 35943: Removed a stale TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35943/#review89572 --- Ship it! Ship It! - Vinod Kone On June 26, 2015, 9:11 p.m., Ben

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/#review89573 --- src/exec/exec.cpp (line 492)

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89577 --- include/mesos/mesos.proto (lines 1212 - 1214)

Re: Review Request 35935: Added a simulation benchmark for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/#review89578 --- Patch looks great! Reviews applied: [35909, 35914, 35943, 35910, 35

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

> On June 26, 2015, 9:44 p.m., Vinod Kone wrote: > > src/exec/exec.cpp, lines 496-497 > > > > > > s/create/overwrite/ > > > > s/pure clients/HTTP API/ > > > > Can you move this down to #514 where we a

Re: Review Request 35911: Moved StatusUpdate.uuid from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35911/#review89575 --- include/mesos/mesos.proto (line 922)

Re: Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/#review89582 --- As a general design note, we should have the `int code` as a separat

Re: Review Request 35912: Updated createdStatusUpdate to not set the UUID for master-generated updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35912/#review89581 --- Ship it! src/common/protobuf_utils.hpp (line 45)

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- (Updated June 26, 2015, 10:36 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 35935: Added a simulation benchmark for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/#review89583 --- src/tests/reconciliation_tests.cpp (lines 905 - 908)

Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35947/ --- Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:55 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:55 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:56 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89588 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 35799: Support mounting relative paths with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/ --- (Updated June 26, 2015, 11:26 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 35955: Update default value for Socket.recv().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35955/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35955: Update default value for Socket.recv().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35955/#review89592 --- Ship it! Ship It! - Benjamin Hindman On June 26, 2015, 11:57 p.m

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review89595 --- Patch looks great! Reviews applied: [35934, 35939, 35947, 35702] A

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

> On June 26, 2015, 9:44 p.m., Vinod Kone wrote: > > src/exec/exec.cpp, lines 496-497 > > > > > > s/create/overwrite/ > > > > s/pure clients/HTTP API/ > > > > Can you move this down to #514 where we a

Re: Review Request 35935: Added a simulation benchmark for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/ --- (Updated June 27, 2015, 12:37 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 35911: Moved StatusUpdate.uuid from required to optional.

> On June 26, 2015, 10:30 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 2656-2663 > > > > > > s/pure clients/HTTP API/ > > > > How is this even possible with the current driver and slave semsntics?

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/ --- (Updated June 27, 2015, 12:36 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 35911: Moved StatusUpdate.uuid from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35911/ --- (Updated June 27, 2015, 12:36 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 35912: Updated createdStatusUpdate to take an optional UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35912/ --- (Updated June 27, 2015, 12:37 a.m.) Review request for mesos, Jie Yu and Vinod

Review Request 35958: Updated SlaveTest.PingTimeoutNoPings test to use custom timeout values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35958/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

> On June 3, 2015, 2:24 p.m., Ben Mahler wrote: > > src/tests/partition_tests.cpp, lines 647-650 > > > > > > This sounds like testing two particular behaviors in a single test: > > > > (1) A registered slave t

Re: Review Request 35799: Support mounting relative paths with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review89597 --- Patch looks great! Reviews applied: [35799] All tests passed. - M

Re: Review Request 35935: Added a simulation benchmark for reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/#review89598 --- Bad patch! Reviews applied: [35909, 35914, 35943, 35910, 35911] Fa

Review Request 35962: Add mutable get() to Try.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35962/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35889: Add SSL tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35889/ --- (Updated June 27, 2015, 1:18 a.m.) Review request for mesos, Benjamin Hindman a

Review Request 35961: Include protobuf classes in generated Javadoc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/ --- Review request for mesos, Adam B and Ben Whitehead. Bugs: MESOS-1552 https:

  1   2   >