---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/
---
(Updated July 16, 2015, 1:54 a.m.)
Review request for mesos.
Bugs:
On July 9, 2015, 7:11 a.m., Till Toenshoff wrote:
Do we have a JIRA issue that would cover this issue? If so, please add it
to this review-request within the Bugs section. If there is no JIRA,
please create one that describes the problem briefly.
Next question; once the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 16, 2015, 5:47 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 16, 2015, 4:41 a.m.)
Review request for mesos.
Bugs:
On July 15, 2015, 9:19 p.m., Joseph Wu wrote:
src/tests/utils.hpp, line 55
https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line55
* Tab size = 2 spaces.
* Parameters are indented by 4 spaces.
* Comments start with a capital letter and end with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91863
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
On July 14, 2015, 7:41 p.m., Vinod Kone wrote:
src/slave/containerizer/provisioner.cpp, lines 43-56
https://reviews.apache.org/r/34137/diff/2-3/?file=989758#file989758line43
Why do you need foreach loop here if you were going to return error
anyway?
We need the foreach to go
On July 14, 2015, 7:41 p.m., Vinod Kone wrote:
can you fix the depends on please?
I think the two listed are the correct dependencies for this rb?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91859
---
Patch looks great!
Reviews applied: [36402]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91723
---
src/slave/flags.hpp (line 117)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36510/#review91751
---
Ship it!
im assuming you are not building inside build directory?
On July 13, 2015, 5:20 p.m., Paul Brett wrote:
a drive by comment suggested by Joris is inline really necessary here?
On July 13, 2015, 5:20 p.m., Paul Brett wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 307
On July 15, 2015, 5:04 p.m., Vinod Kone wrote:
im assuming you are not building inside build directory?
Yup. I just found out today that the ```build``` directory was conventional :)
- James
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36464/#review91764
---
Ship it!
Looks good but mind removing the deprecated code in a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/#review91770
---
Ship it!
src/sched/sched.cpp (line 1132)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36466/#review91766
---
Ship it!
src/sched/sched.cpp (line 1135)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91765
---
src/sched/sched.cpp (line 1029)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36463/#review91762
---
src/sched/sched.cpp (lines 890 - 892)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36470/#review91773
---
src/sched/sched.cpp (line 852)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36467/#review91767
---
Ship it!
src/sched/sched.cpp (line 745)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36463/#review91779
---
Ship it!
Ship It!
- Ben Mahler
On July 13, 2015, 11:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36470/#review91777
---
Ship it!
Ship It!
- Ben Mahler
On July 14, 2015, 12:30 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36461/#review91757
---
It looks like this could benefit from a bit of documentation that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91778
---
Ship it!
Ship It!
- Ben Mahler
On July 14, 2015, midnight,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91784
---
To make sure that this is fool proof(ish), I would suggest that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36517/
---
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-3050
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36462/#review91760
---
src/tests/mesos.hpp (lines 1328 - 1332)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91782
---
Ship it!
src/common/http.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35752/#review91798
---
Ship it!
Ship It!
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review91795
---
include/mesos/mesos.proto (line 102)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36517/#review91796
---
Ship it!
Ship It!
- Jie Yu
On July 15, 2015, 6:32 p.m., Timothy
On July 14, 2015, 12:20 a.m., Paul Brett wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 307
https://reviews.apache.org/r/36424/diff/1/?file=1008891#file1008891line307
How about returning a tuple/struct of stdout, stderr and return code
and let the caller decide
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36517/#review91805
---
Patch looks great!
Reviews applied: [36517]
All tests passed.
-
On July 15, 2015, 6:13 p.m., Artem Harutyunyan wrote:
To make sure that this is fool proof(ish), I would suggest that this should
only ship only when the Authorizer framework (mentioned in the TODO
comment) becomes available. Also, I would add a screaming comment to
--usage,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36529/#review91831
---
Ship it!
Ship It!
- Timothy Chen
On July 15, 2015, 10:25 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36529/#review91830
---
src/tests/cgroups_tests.cpp (line 1199)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36217/
---
(Updated July 15, 2015, 10:46 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated July 15, 2015, 10:51 p.m.)
Review request for mesos, Anand Mazumdar,
On July 10, 2015, 10:13 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 216
https://reviews.apache.org/r/36402/diff/1/?file=1008565#file1008565line216
I did not review the entire patch but I stopped at this. Seems like I
am missing something here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36529/#review91838
---
Patch looks great!
Reviews applied: [36529]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36510/#review91753
---
Patch looks great!
Reviews applied: [36510]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---
(Updated July 15, 2015, 5:20 p.m.)
Review request for mesos, Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91774
---
Patch looks great!
Reviews applied: [35687]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36524/#review91816
---
Ship it!
Ship It!
- Jie Yu
On July 15, 2015, 8:21 p.m., Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36522/
---
Review request for mesos, Adam B and Jie Yu.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36518/#review91813
---
Patch looks great!
Reviews applied: [36518]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36524/
---
Review request for mesos, Adam B and Jie Yu.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36523/
---
Review request for mesos, Adam B and Jie Yu.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36522/#review91818
---
Ship it!
Please put some context in the review please next time
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36494/#review91819
---
src/sched/sched.cpp (lines 489 - 492)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
---
Have not gone through the whole review yet. It would be worth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36488/#review91840
---
Looks great! Helped me understand the feature much better. Comments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36532/#review91854
---
Patch looks great!
Reviews applied: [36532]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36532/
---
Review request for mesos, Adam B and Joris Van Remoortere.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated July 15, 2015, 11:54 p.m.)
Review request for mesos, Anand Mazumdar,
On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, lines 135-143
https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line135
Can we get these comments back ?
They're on the header file now, do we want them duplciate here?
On July
On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 126
https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line126
Whoops ! Let's return false as earlier. Also add a test-case for empty
check. ( Accept-Encoding )
Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36527/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-3058
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36518/#review91821
---
Ship it!
Looks good given the current Call API. However, per our
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36524/#review91824
---
Patch looks great!
Reviews applied: [36522, 36523, 36524]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36527/#review91828
---
Patch looks great!
Reviews applied: [36527]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36529/
---
Review request for mesos and Timothy Chen.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91732
---
src/tests/utils.hpp (line 26)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36510/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-3054
64 matches
Mail list logo
