Re: Review Request 39258: Add filesystem isolator with command executor test.

> On Nov. 3, 2015, 1:30 a.m., Jie Yu wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 286 > > > > > > any reason you use 'copy'. Can we do bind to speed up tests? > > Timothy Chen wrote: >

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Nov. 4, 2015, 12:22 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 37999: Implemented http::AuthenticatorManager

> On Oct. 21, 2015, 1:03 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, line 52 > > > > > > Duplicate text. I used a separate line because Doxygen uses the first line as a brie

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 4, 2015, 12:25 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 37999: Implemented http::AuthenticatorManager

> On Oct. 21, 2015, 1:46 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/process.cpp, line 885 > > > > > > Why are we doing this? Why isn't it a failure if there is no success > > and also no challenge? Plea

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 4, 2015, 12:27 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

> On Oct. 21, 2015, 2:12 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/include/process/process.hpp, line 83 > > > > > > Why aren't we using shared pointers here? Last time I asked, we don't use std smart pointe

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 4, 2015, 12:29 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review105053 --- src/launcher/fetcher.cpp (line 297)

Re: Review Request 36071: Add flow diagram for docker containerizer.

> On July 7, 2015, 4:51 a.m., Bernd Mathiske wrote: > > 1. Inconsistent capitalization in box labels. > > 2. You explain different paths to obtain an "executor pid" and then you > > checkpoint a "container pid". You lost me there. > > 3. What happens to the tasks? Is this diagram for the executo

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 4, 2015, 12:33 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 39799: Allow hdfs URLs in the HDFS wrapper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39799/#review105055 --- Ship it! src/hdfs/hdfs.hpp (line 205)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105056 --- Bad patch! Reviews applied: [39276, 37998, 39472, 37999, 38000, 38

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 4, 2015, 1:20 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 4, 2015, 1:21 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review105058 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105060 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999, 3

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Nov. 4, 2015, 9:19 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Nov. 4, 2015, 9:21 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

> On Nov. 2, 2015, 4:11 p.m., Vinod Kone wrote: > > What's the plan for slave to agent rename in the logs? Having just the > > allocator output agent when the rest of the code base outputs slave will be > > confusing IMO. > > Alexander Rukletsov wrote: > I think we change as we go. I was i

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review105064 --- Ship it! Ship It! - Guangya Liu On 十月 21, 2015, 12:52 p.m., Ale

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review105065 --- Patch looks great! Reviews applied: [38342, 38335] All tests pass

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Oct. 25, 2015, 5:46 a.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 357 > > > > > > Why do we assume quota for the given role is not set prior to the call? > > I thought we support setting

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Nov. 4, 2015, 2:37 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Nov. 4, 2015, 12:48 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 36 > > > > > > How is this relevant? Agreed, remove reference (which might go stale).

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review105062 --- src/master/quota_handler.cpp (line 151)

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Nov. 4, 2015, 3:31 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Nov. 4, 2015, 4:21 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 39018: Added JSON parsing for Resources.

> On Nov. 4, 2015, 2:54 a.m., Guangya Liu wrote: > > src/v1/resources.cpp, line 1190 > > > > > > remove this Rather than removing it, I thought it might be nice to expand this comment to make it more useful. Let

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

> On Nov. 4, 2015, 2:43 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 6004-6013 > > > > > > Just looking at the patch that introduced this bug, why are we removing > > the out-of-order update prevention?

Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3821 https://issues.

Review Request 39938: Document OS X SIGPIPE delivery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39938/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079 https://issues.ap

Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39941/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079 https://issues.ap

Review Request 39940: Globally ignore SIGPIPE in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39940/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079 https://issues.ap

Re: Review Request 39938: Document OS X SIGPIPE delivery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39938/#review105085 --- Ship it! Ship It! - haosdent huang On Nov. 4, 2015, 5:15 p.m.,

Re: Review Request 39940: Globally ignore SIGPIPE in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39940/#review105086 --- Ship it! Ship It! - haosdent huang On Nov. 4, 2015, 5:16 p.m.,

Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39941/#review105087 --- Ship it! Ship It! - haosdent huang On Nov. 4, 2015, 5:16 p.m.,

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Nov. 4, 2015, 5:26 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Nov. 4, 2015, 5:28 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

> On Nov. 4, 2015, 11:30 a.m., Bernd Mathiske wrote: > > src/launcher/fetcher.cpp, line 297 > > > > > > Or, avoiding a string constant: > > > > CHECK_FALSE(item.cache_filename().empty()); i don't see a CHE

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

> On Nov. 4, 2015, 3:30 a.m., Bernd Mathiske wrote: > > src/launcher/fetcher.cpp, line 297 > > > > > > Or, avoiding a string constant: > > > > CHECK_FALSE(item.cache_filename().empty()); > > Vinod Kone wro

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review105104 --- Ship it! Ship It! - Bernd Mathiske On Oct. 27, 2015, 6:45 p.m.,

Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/ --- Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. Bugs: ME

Review Request 39945: Pass SSL related environment variables to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/ --- Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. Reposito

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review105105 --- Patch looks great! Reviews applied: [39939] All tests passed. -

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 4, 2015, 6:07 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39015/ --- (Updated Nov. 4, 2015, 6:08 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39112: RegistryClient refactor: fixed variable names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39112/ --- (Updated Nov. 4, 2015, 6:08 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39053/ --- (Updated Nov. 4, 2015, 6:08 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 4, 2015, 6:09 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review105083 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Nov. 4, 2015, 6:09 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105109 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hp

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105110 --- I would suggest you add tests for this. - Jojy Varghese On Nov.

Re: Review Request 39945: Pass SSL related environment variables to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/#review105111 --- src/slave/containerizer/containerizer.cpp (line 259)

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105113 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hp

Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3827 https:/

Review Request 39947: Refactored mock allocator into a separate header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3827 https:/

Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository

Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105114 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hp

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105115 --- Can we test that more thoroughly than just "make check"? e.g., if t

Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39941/#review105119 --- Patch looks great! Reviews applied: [39938, 39940, 39941] All tes

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 11:25 a.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. There are tons of methods in libp

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 7:25 p.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. > > Joseph Wu wrote: > There a

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- (Updated Nov. 4, 2015, 12:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 11:25 a.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. > > Joseph Wu wrote: > There

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105128 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 8:24 p.m., Jos

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/#review105129 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 6:50 p.m., Jos

Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 39953: Renamed jenkins_build.sh to docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39953/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/ --- (Updated Nov. 4, 2015, 8:44 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/ --- (Updated Nov. 4, 2015, 8:47 p.m.) Review request for mesos, Cody Maloney and Vi

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/ --- (Updated Nov. 4, 2015, 8:57 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/#review105130 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2015, 8:58 p.m., Timothy

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/ --- (Updated Nov. 4, 2015, 8:58 p.m.) Review request for mesos, Jie Yu and Jojy Var

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Nov. 4, 2015, 8:59 p.m.) Review request for mesos, Jie Yu and Jiang Ya

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/#review105131 --- Ship it! src/slave/containerizer/mesos/mount.cpp (line 72)

Re: Review Request 39953: Renamed jenkins_build.sh to docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39953/#review105133 --- Ship it! Ship It! - Vinod Kone On Nov. 4, 2015, 8:43 p.m., Jojy

Re: Review Request 39869: Added provisioner TestStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39869/ --- (Updated Nov. 4, 2015, 9:03 p.m.) Review request for mesos, Jie Yu and Jojy Var

Re: Review Request 39868: Moved ProvisionerProcess to header for testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39868/ --- (Updated Nov. 4, 2015, 9:03 p.m.) Review request for mesos, Jie Yu and Jojy Var

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/ --- (Updated Nov. 4, 2015, 9:04 p.m.) Review request for mesos, Jie Yu and Jiang Ya

Re: Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/#review105135 --- the diff is empty? - Vinod Kone On Nov. 4, 2015, 8:44 p.m., Jojy

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review105136 --- support/verify_reviews.py (line 122)

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

> On Nov. 4, 2015, 9:12 p.m., Vinod Kone wrote: > > support/verify_reviews.py, line 122 > > > > > > have you verified this change locally? > > > > the docker_build.sh script expects certain environment varia

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review105139 --- Ship it! Ship It! - Kapil Arya On Sept. 23, 2015, 9:55 p.m., Ji

Re: Review Request 39954: Fixed spelling in comments.

> On Nov. 4, 2015, 9:10 p.m., Vinod Kone wrote: > > the diff is empty? hmm thats strange. If you "download" the diff, you will see the patch. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review105142 --- Ship it! src/slave/slave.cpp (line 3343)

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review105143 --- Ship it! src/tests/containerizer/filesystem_isolator_tests.cpp (l

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 3, 2015, 5:02 p.m., Michael Hopcroft wrote: > > This is my initial set of comments. I still need to read from line 112 on > > in stat.hpp and I haven't started reading reparsepoint.hpp. Replied to a few project-specific (we might call it "tribal knowledge") points you raised. If you

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105134 --- src/Makefile.am (line 564)

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/#review105146 --- Ship it! Checked that code did not change in midst of the move.

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105148 --- Bad patch! Reviews applied: [39838] Failed command: ./support/app

Re: Review Request 39805: Moved filesystems tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review105147 --- Ship it! Kudos for alphabetizing the tests by name. 3rdparty/lib

Re: Review Request 39834: Made `path_tests.cpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review105150 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105151 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > > > > > Didn''t you pull these out? Not sure what you mean. > On Nov. 4, 2015,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 4, 2015, 2:30 p.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 373 > > > > > > Instead of doing this, how about just create a new Image::Name? > > Joj

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 10:05 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 43 > > > > > > This was done in another patch by Ben M (currently in > > registry_clie

  1   2   >