Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review112518 --- Ship it! Ship It! - Adam B On Dec. 30, 2015, 11:28 a.m., Artem

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review112519 --- Patch looks great! Reviews applied: [41870] Passed command: expor

Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review112516 --- src/slave/slave.hpp (lines 374 - 376)

Re: Review Request 41858: [WIP][MESOS-4265] kill executors helper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/#review112521 --- src/slave/slave.cpp (line 4891)

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 8:27 a.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41859: [WIP][MESOS-4265] launch tasks after evicting executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/#review112522 --- src/slave/slave.cpp (lines 1374 - 1375)

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review112523 --- Ship it! Looks good enough to me. I'll fix these little things and

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 21, 2015, 3:20 p.m., Greg Mann wrote: > > include/mesos/authorizer/authorizer.hpp, lines 129-131 > > > > > > Though I know what you're saying here, this one sounds a bit confusing > > to me. I wonder if so

Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/ --- Review request for mesos, Joerg Schad and Michael Park. Bugs: MESOS-4271 ht

Review Request 41872: Used only exactly representable floats in test calculation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/ --- Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-4272

Review Request 41876: Used List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4273 https://issues.ap

Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4273 https://issues.ap

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/#review112529 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:53 p.m., A

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/#review112530 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:51 p.m., A

Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/ --- Review request for mesos. Bugs: MESOS-4274 https://issues.apache.org/jira/b

Re: Review Request 40546: Fixed framework CPU counters on slave page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/#review112533 --- Ship it! - Jan Schlicht On Jan. 4, 2016, 4:43 a.m., Ian Babrou w

Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review112535 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:56 p.m., A

Re: Review Request 41513: Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review112536 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:59 p.m., A

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review112534 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:55 p.m., A

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review112528 --- Looks good. Nice, simple, and clean. Just a few suggestions, and we

Re: Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/ --- (Updated Jan. 4, 2016, 11:25 a.m.) Review request for mesos. Bugs: MESOS-4274

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

> On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. > > Alexander Rukletsov wrote: > I'm not sure we can for

Review Request 41880: Removed redundant constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-4276

Review Request 41881: Provided constexpr Duration min and max values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/ --- Review request for mesos, Joris Van Remoortere and Jiang Yan Xu. Bugs: MESOS-42

Re: Review Request 41880: Removed redundant constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112542 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:39 a.m.,

Re: Review Request 41881: Provided constexpr Duration min and max values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112543 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:49 a.m.,

Re: Review Request 41876: Used List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/#review112544 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:41 a.m.,

Review Request 41882: Constrainted types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Bugs: MESOS-4278

Re: Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/#review112545 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:41 a.m.,

Re: Review Request 41882: Constrainted types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review112546 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 11:06 a.m.,

Re: Review Request 41872: Used only exactly representable floats in test calculation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/#review112547 --- Ship it! Ship It! - Alexander Rojas On Jan. 4, 2016, 10:23 a.m.

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112541 --- Ship it! Looks good, but you really need to set up your EXPECTatio

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:19 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:20 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 11:22 a.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112549 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:12 a.m.,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Jan. 4, 2016, 12:26 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/#review112551 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:33 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp, > > line 32 > > > > > > I wonder if there is any good way of protecting ou

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp, > > line 199 > > > > > > Recommend using RAII pattern (e.g. std::unique_p

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:46 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41597: Extending allocator interface to support dynamic weights

> On Jan. 4, 2016, 10:23 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1676-1678 > > > > > > Do we really need this message? Can't we just use `repeated WeightInfo > > weightInfos` in any other protobuf

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 154 > > > > > > Have you checked all of the return types to ensure they are wh

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:55 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:59 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 51 > > > > > > Calling FindClose on an invalid handle is not the best idea. At bes

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 12:02 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41882: Constrainted types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review112562 --- Patch looks great! Reviews applied: [41882] Passed command: expor

Re: Review Request 41872: Used only exactly representable floats in test calculation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/#review112564 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:23 a.m.,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 4, 2016, 1:58 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112565 --- Bad patch! Reviews applied: [41597] Failed command: ./support/app

Re: Review Request 41880: Removed redundant constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112568 --- Ship it! Mind mentioning the testing you've done? - Alexander Ruk

Re: Review Request 41880: Removed redundant constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112571 --- Ship it! Ship It! - Guangya Liu On 一月 4, 2016, 11:28 a.m., Benj

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 1:44 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 1:52 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 1:53 p.m.) Review request for mesos, Adam B, Joerg Schad

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 1:53 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 4, 2016, 1:52 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

> On Dec. 29, 2015, 7:32 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/README.md, lines 536-544 > > > > > > Hm.. since this document is about programming, do we need to say > > 'programming notes'? Or is 'notes' e

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 4, 2016, 4:31 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Jan. 4, 2016, 4:32 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 41425: Fix the Mesos pkg-config.

> On Dec. 23, 2015, 9:15 p.m., Alex Clemmer wrote: > > Just as a short note here, `pkg-config` doesn't work well with the rest of > > the Windows tool chain, so it's worth wondering what our distribution story > > should be there. > > > > If the consumer is using CMake, then this information i

Re: Review Request 41618: Edited defer documentation in libprocess.

> On Dec. 22, 2015, 10:24 a.m., Alexander Rojas wrote: > > Hey Gregg, Thanks for working on this, I really think this needs > > documentation. However, I think we are going great lengths to explain > > relatively simple concepts. I also feel that tying so much the concept of a > > `defer` to a

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Jan. 4, 2016, 8:57 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/#review112599 --- 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp (li

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review112602 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 22, 2015, 8:44

Re: Review Request 41425: Fix the Mesos pkg-config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/#review112603 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 4, 2016, 4:35

Review Request 41888: Fix sandbox browse UI has path which is not selectable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41888/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1976 https://i

Re: Review Request 41881: Provided constexpr Duration min and max values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112609 --- Looks good. How did you choose the particular functions to make con

Re: Review Request 41880: Removed redundant constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112608 --- Ship it! Ship It! - Vinod Kone On Jan. 4, 2016, 11:28 a.m., Ben

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 10, 2015, 4:12 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 109 > > > > > > Can you explain / comment why here (as well as on L139)

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/#review112612 --- docs/oversubscription.md (line 202)

Re: Review Request 35711: Disallow special characters in role name.

> On Dec. 15, 2015, 2:45 a.m., Adam B wrote: > > Thanks for reviving this, and sorry it's taken so long to get back to it. > > Adam B wrote: > You'll also need to add some documentation about what the valid/invalid > role names are, and when they'll be rejected. Could you add this info to

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/ --- (Updated Jan. 4, 2016, 6:35 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39805: Moved filesystems tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/ --- (Updated Jan. 4, 2016, 6:39 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41868: Added credential to Docker image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41868/#review112616 --- Seems like this patch is posted dulpolicate, could you discard one

Re: Review Request 41881: Provided constexpr Duration min and max values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/ --- (Updated Jan. 4, 2016, 6:43 p.m.) Review request for mesos, Joris Van Remoorter

Re: Review Request 41881: Provided constexpr Duration min and max values.

> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote: > > Looks good. How did you choose the particular functions to make constexpr. > > Why not the units for example? or others? The goal was to provide `constexpr` versions of `Duration::min`, `Duration::max`, and `Duration::zero`. The lat

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112618 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 12:02 p.m., Al

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review112619 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 11:20 a.m., Al

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/#review112620 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:35 p.m., Ale

Re: Review Request 39805: Moved filesystems tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review112621 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:39 p.m., Ale

Re: Review Request 39834: Made `path_tests.cpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review112622 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:14 a.m., Al

Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41604/#review112623 --- Ship it! Ship It! - Alex Naparu On Dec. 23, 2015, 6:52 a.m., Al

Re: Review Request 39834: Made `path_tests.cpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/ --- (Updated Jan. 4, 2016, 7:10 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112626 --- review bot is barfing on this review due to files left over after `

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:14 p.m.) Review request for mesos and Benjamin Hindman

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 58-63 > > > > > > An implicit cast operator that is non-const is always code smell > > be

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:23 p.m.) Review request for mesos and Benjamin Hindman

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 116 > > > > > > Why not s/: Writer/: public Writer/ here and elsewhere? > > Michael Park

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:28 p.m.) Review request for mesos and Benjamin Hindman

Re: Review Request 41594: libprocess: Added support for `jsonify` result to `OK` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41594/ --- (Updated Jan. 4, 2016, 7:29 p.m.) Review request for mesos and Benjamin Hindman

  1   2   3   >