Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/ --- (Updated Jan. 4, 2016, 6:43 p.m.) Review request for mesos, Joris Van

Review Request 41891: Renaming offers to outstanding offers

2016-01-04 Thread Diogo Gomes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3817

Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

2016-01-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41892/ --- Review request for mesos, haosdent huang and Jie Yu. Bugs: MESOS-3413

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2016-01-04 Thread Alexander Rukletsov
> On Jan. 4, 2016, 5:30 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, line 41 > > > > > > my question here is, why does `result_of_type` needs to take > >

Re: Review Request 41868: Added credential to Docker image protobuf.

2016-01-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41868/#review112616 --- Seems like this patch is posted dulpolicate, could you discard one

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 58-63 > > > > > > An implicit cast operator that is non-const is always code smell > >

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112641 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/#review112620 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:35 p.m.,

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review112621 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:39 p.m.,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review112619 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 11:20 a.m.,

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112626 --- review bot is barfing on this review due to files left over after

Re: Review Request 41594: libprocess: Added support for `jsonify` result to `OK` response.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41594/ --- (Updated Jan. 4, 2016, 7:29 p.m.) Review request for mesos and Benjamin

Re: Review Request 40429: Report executor exit to framework schedulers.

2016-01-04 Thread Vinod Kone
> On Jan. 4, 2016, 11:15 a.m., Adam B wrote: > > Looks good, but you really need to set up your EXPECTations before you do > > the thing (e.g. `containerizer.destroy()`) that would trigger the > > EXPECTation. Fix these, and I'd feel comfortable committing it. > > Any further thoughts from

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112618 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 12:02 p.m.,

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:14 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 116 > > > > > > Why not s/: Writer/: public Writer/ here and elsewhere? > > Michael Park

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/ --- (Updated Jan. 4, 2016, 8:01 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Benjamin Bannier
> On Jan. 4, 2016, 7:13 p.m., Vinod Kone wrote: > > review bot is barfing on this review due to files left over after > > `distcheck`. for some reason, it is not able to post the error to this > > review. > > > > see: https://builds.apache.org/job/mesos-reviewbot/10563/consoleFull > > > > rm

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-01-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41862/#review112639 --- Ship it! Ship It! docs/containerizer-internals.md (line 115)

Re: Review Request 41880: Removed redundant constructor.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/ --- (Updated Jan. 4, 2016, 8:28 p.m.) Review request for mesos, Alexander

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote: > > Looks good. How did you choose the particular functions to make constexpr. > > Why not the units for example? or others? The goal was to provide `constexpr` versions of `Duration::min`, `Duration::max`, and `Duration::zero`. The

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review112622 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:14 a.m.,

Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41604/#review112623 --- Ship it! Ship It! - Alex Naparu On Dec. 23, 2015, 6:52 a.m.,

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

2016-01-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/#review112635 --- include/mesos/executor/executor.proto (line 91)

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/ --- (Updated Jan. 4, 2016, 7:10 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 84 > > > > > > Did you mean to mark this a friend? Is this supposed to be static? Is > >

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 120 > > > > > > It seems weird to not be making this virtual ... > > Michael Park wrote:

Re: Review Request 41593: stout: Added `jsonify` function.

2016-01-04 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167 > > > > > > Is the `int32_t`, `uint32_t`, and `float` overloads necessary? > >

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/ --- (Updated Jan. 4, 2016, 6:39 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41872: Used only exactly representable floats in test calculation.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/#review112633 --- Patch looks great! Reviews applied: [41872] Passed command:

Re: Review Request 41760: Add initialization method to Anonymous module

2016-01-04 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/ --- (Updated Jan. 4, 2016, 8:16 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review112647 --- Bad patch! Reviews applied: [40975] Failed command:

Re: Review Request 41858: [WIP][MESOS-4265] kill executors helper

2016-01-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/#review112521 --- src/slave/slave.cpp (line 4891)

Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review112535 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:56 p.m.,

Re: Review Request 40429: Report executor exit to framework schedulers.

2016-01-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112541 --- Ship it! Looks good, but you really need to set up your

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2016-01-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Jan. 4, 2016, 12:26 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp, > > line 32 > > > > > > I wonder if there is any good way of protecting

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:55 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/#review112530 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:51 p.m.,

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/#review112529 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:53 p.m.,

Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

2016-01-04 Thread Jocelyn De La Rosa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/ --- Review request for mesos. Bugs: MESOS-4274

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review112528 --- Looks good. Nice, simple, and clean. Just a few suggestions, and

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Artem

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41789: Add put method for http PUT request.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 11:22 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:33 a.m.) Review request for mesos, Artem

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
> On Jan. 4, 2016, 10:23 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1676-1678 > > > > > > Do we really need this message? Can't we just use `repeated WeightInfo > > weightInfos` in any other

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 154 > > > > > > Have you checked all of the return types to ensure they are

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 12:02 p.m.) Review request for mesos, Artem

Re: Review Request 40546: Fixed framework CPU counters on slave page.

2016-01-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/#review112533 --- Ship it! - Jan Schlicht On Jan. 4, 2016, 4:43 a.m., Ian Babrou

Re: Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

2016-01-04 Thread Jocelyn De La Rosa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/ --- (Updated Jan. 4, 2016, 11:25 a.m.) Review request for mesos. Bugs:

Review Request 41880: Removed redundant constructor.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-4276

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:59 a.m.) Review request for mesos, Artem

Re: Review Request 41513: Cleaned up STL I/O includes.

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review112536 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:59 p.m.,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review112534 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:55 p.m.,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:18 a.m.) Review request for mesos, Artem

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:19 a.m.) Review request for mesos, Artem

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp, > > line 199 > > > > > > Recommend using RAII pattern (e.g.

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112543 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:49

Re: Review Request 41875: Provided List constructor from std::initializer_list.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/#review112545 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:41 a.m.,

Review Request 41882: Constrainted types used in Flags instantiation.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Bugs:

Re: Review Request 41876: Used List constructor from std::initializer_list.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/#review112544 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:41 a.m.,

Re: Review Request 41882: Constrainted types used in Flags instantiation.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review112546 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 11:06

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 4, 2016, 11:20 a.m.) Review request for mesos, Artem

Re: Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41877/#review112551 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2016-01-04 Thread Michael Park
> On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. > > Alexander Rukletsov wrote: > I'm not sure we can

Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/ --- Review request for mesos, Joris Van Remoortere and Jiang Yan Xu. Bugs:

Re: Review Request 41880: Removed redundant constructor.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112542 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:39

Re: Review Request 41872: Used only exactly representable floats in test calculation.

2016-01-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/#review112547 --- Ship it! Ship It! - Alexander Rojas On Jan. 4, 2016, 10:23

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112549 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 9:12 a.m.,

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 4, 2016, 11:46 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Clemmer
> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 51 > > > > > > Calling FindClose on an invalid handle is not the best idea. At

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 8:27 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41444: Cleaned up Authorizer interface.

2016-01-04 Thread Adam B
> On Dec. 21, 2015, 3:20 p.m., Greg Mann wrote: > > include/mesos/authorizer/authorizer.hpp, lines 129-131 > > > > > > Though I know what you're saying here, this one sounds a bit confusing > > to me. I wonder if

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2016-01-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review112518 --- Ship it! Ship It! - Adam B On Dec. 30, 2015, 11:28 a.m., Artem

Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors

2016-01-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review112516 --- src/slave/slave.hpp (lines 374 - 376)

Re: Review Request 41859: [WIP][MESOS-4265] launch tasks after evicting executors

2016-01-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/#review112522 --- src/slave/slave.cpp (lines 1374 - 1375)

Re: Review Request 41444: Cleaned up Authorizer interface.

2016-01-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review112523 --- Ship it! Looks good enough to me. I'll fix these little things

Review Request 41872: Used only exactly representable floats in test calculation.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/ --- Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-4272

Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/ --- Review request for mesos, Joerg Schad and Michael Park. Bugs: MESOS-4271

Review Request 41875: Provided List constructor from std::initializer_list.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4273

Review Request 41876: Used List constructor from std::initializer_list.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4273

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review112519 --- Patch looks great! Reviews applied: [41870] Passed command:

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/#review112657 --- Ship it! Ship It!

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Gilbert Song
> On Jan. 4, 2016, 2:06 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 257 > > > > > > Should we also CHECK here fslayers_size() == history size?

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112661 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112667 ---

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Clemmer
> On Jan. 4, 2016, 10:33 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 94 > > > > > > Can you use _rmdir() instead to avoid another deprecation

Re: Review Request 41891: Renaming offers to outstanding offers.

2016-01-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112710 --- Can you attach the screenshot of the webui with these changes? -

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112532 --- Patch looks great! Reviews applied: [41871] Passed command:

Review Request 41905: Added discussion of multiple frameworks sharing the same role.

2016-01-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41905/ --- Review request for mesos, Adam B, Jie Yu, and Joris Van Remoortere. Bugs:

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

2016-01-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/ --- (Updated Jan. 5, 2016, 12:09 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41888: Fix sandbox browse UI has path which is not selectable.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41888/#review112660 --- Patch looks great! Reviews applied: [41888] Passed command:

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112686 ---

  1   2   3   >