Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-01-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Jan. 11, 2016, 10:32 p.m.) Review request for mesos, Benjamin

Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

2016-01-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42165/ --- Review request for mesos, Alexander Rojas, Michael Park, and Neil Conway.

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Jan. 11, 2016, 11:12 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42058: Fixed stout protobuf::parse by passing error message in nested JSON.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42058/ --- (Updated Jan. 11, 2016, 3:39 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Jan. 12, 2016, 12:24 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42167: Fixed stout protobuf::parse passing error message in nested JSON.

2016-01-11 Thread Ben Mahler
> On Jan. 12, 2016, 1:24 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 336 > > > > > > s/for recursive/for the recursive/ > > s/sequencially/sequentially/ We

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review113853 ---

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:46 a.m.) Review request for mesos, Artem

Re: Review Request 42167: Fixed stout protobuf::parse passing error message in nested JSON.

2016-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42167/#review113894 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113896 --- Looks great, thanks! Just a few trivial comments below, and we can

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review113902 --- Patch looks great! Reviews applied: [41244, 41243] Passed

Re: Review Request 41338: Added REASON_RESOURCES_PREEMPTED to mesos proto.

2016-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41338/#review113904 --- Looks like the diff doesn't show up on the WebUI (The downloaded

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Jan. 11, 2016, 10:19 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
> On Jan. 9, 2016, 12:42 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 204 > > > > > > why assert vs. false with errno? > > Alex

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 130 > > > > > > Might want to static_assert that _USE_32BIT_TIME_T is not

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 130 > > > > > > Might want to static_assert that _USE_32BIT_TIME_T is not

Re: Review Request 42096: Fixed race in persistent volume tests.

2016-01-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42096/#review113864 --- Ship it! Ship It! - Jie Yu On Jan. 9, 2016, 1:19 a.m., Greg

Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- Review request for mesos, Alexander Rojas, Michael Park, and Neil Conway.

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review113880 --- Bad patch! Reviews applied: [41958, 41959] Failed command:

Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Klaus Ma
> On Jan. 9, 2016, 5:02 p.m., Klaus Ma wrote: > > src/master/master.cpp, line 3078 > > > > > > If both `offerError.isSome()` and `inverseOfferError.isSome()`, should > > we return `Error()`? > > Joseph Wu wrote:

Re: Review Request 42151: stout: Fixed typo in warning message.

2016-01-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42151/#review113870 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 11, 2016,

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 12, 2016, 12:42 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42154: Moved push_back to end of removeFramework.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42154/#review113893 --- Ship it! Thank you! - Ben Mahler On Jan. 11, 2016, 9:41 p.m.,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
> On Jan. 11, 2016, 9:54 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 63 > > > > > > `>=` if `MAX_PATH` is supposed to include the

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Joris Van Remoortere
> On Jan. 11, 2016, 12:38 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, lines > > 36-42 > > > > > > If this is the only section that is different between

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-01-11 Thread James Peach
> On Nov. 30, 2015, 8:51 a.m., Benjamin Bannier wrote: > > src/tests/oversubscription_tests.cpp, line 117 > > > > > > This isn't really too nice, and e.g. cmake does not put build libraries > > into these paths

Review Request 42167: Fixed stout protobuf::parse passing error message in nested JSON.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42167/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van

Re: Review Request 41943: Fixed stout protobuf::parse to support JSON containing JSON::Null.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41943/ --- (Updated Jan. 11, 2016, 3:39 p.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42166: Fixed stout protobuf::parse to support JSON containing JSON::Null.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42166/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van

Re: Review Request 42152: libprocess: Fixed typos in comments.

2016-01-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42152/#review113871 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 11, 2016,

Re: Review Request 42096: Fixed race in persistent volume tests.

2016-01-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42096/#review113878 --- Ship it! Ship It! - Michael Park On Jan. 9, 2016, 1:19 a.m.,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:40 a.m.) Review request for mesos, Artem

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

2016-01-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Jan. 12, 2016, 12:42 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42166: Fixed stout protobuf::parse to support JSON containing JSON::Null.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42166/#review113881 --- Ship it!

Re: Review Request 42167: Fixed stout protobuf::parse passing error message in nested JSON.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42167/#review113887 --- Ship it!

Re: Review Request 41943: Added test case for stout protobuf parse containing JSON null.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41943/#review113883 --- Ship it!

Re: Review Request 42058: Added test case for protobuf parse passing error msg form nest JSON.

2016-01-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42058/#review113889 --- Ship it!

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2016-01-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/#review113852 --- Ship it! Ship It! - Daniel Pravat On Jan. 5, 2016, 11:58 p.m.,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Jan. 11, 2016, 10:03 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-01-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Jan. 11, 2016, 10:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2016-01-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Jan. 11, 2016, 10:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 42058: Added test case for protobuf parse passing error msg form nest JSON.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42058/ --- (Updated Jan. 11, 2016, 3:40 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41943: Added test case for stout protobuf parse containing JSON null.

2016-01-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41943/ --- (Updated Jan. 11, 2016, 3:40 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42153: mesos: Fixed typos in comments and docs.

2016-01-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42153/#review113872 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 11, 2016,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Jan. 12, 2016, 12:39 a.m.) Review request for mesos, Artem

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- (Updated Jan. 12, 2016, 12:52 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
> On Jan. 11, 2016, 8:45 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 102 > > > > > > Please do not use a `default` branch when switching over

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review113694 --- Why not add an overload for `put()`? It could call into the more

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
> On Jan. 9, 2016, 12:42 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 204 > > > > > > why assert vs. false with errno? Actually, I

Re: Review Request 41882: Constrained types used in Flags instantiation.

2016-01-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/ --- (Updated Jan. 11, 2016, 10:25 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41882: Constrained types used in Flags instantiation.

2016-01-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review113708 --- Ship it! Ship It! - Joerg Schad On Jan. 11, 2016, 9:25 a.m.,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
> On Jan. 9, 2016, 12:42 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > lines 193-199 > > > > > > `free` is meant to be safe for

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-11 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/#review113709 --- src/tests/oversubscription_tests.cpp (line 1301)

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-11 Thread Yongqiao Wang
> On Jan. 11, 2016, 8:12 a.m., Adam B wrote: > > Why not add an overload for `put()`? It could call into the more generic > > `request()`, like you want to do with post/get For enhancing the libprocess/http to send put request besides get and post requests, there already has a JIRA for this,

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-11 Thread Joerg Schad
> On Jan. 9, 2016, 12:06 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 284 > > > > > > The hierarchicalDRF allocator shouldn't care about the framework's > > checkpointing state anymore,

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-11 Thread Joerg Schad
> On Jan. 8, 2016, 10:12 p.m., Adam B wrote: > > src/internal/devolve.cpp, line 70 > > > > > > BUG? Wouldn't you still need to `set_checkpoint(true)`, since the > > SlaveInfo.checkpoint protobuf defaults to false,

Re: Review Request 41882: Constrained types used in Flags instantiation.

2016-01-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review113717 --- Ship it! Ship It! - Alexander Rojas On Jan. 11, 2016, 10:25

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-11 Thread Joerg Schad
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 61 > > > > > > These kinds of implementation details belong at the bottom of the > > document, I think -- it is more important to tell the

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-11 Thread Alex Clemmer
> On Jan. 9, 2016, 12:42 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > lines 61-62 > > > > > > I don't see the check for pathSize wrt.

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41979/#review113695 --- docs/authorization.md (line 192)

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 11, 2016, 10:07 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-11 Thread Joerg Schad
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 33-34 > > > > > > But we did have plan to introduce maximal limit in MESOS-3858 , can we > > calarify here? We discussed that part, but

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2016-01-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review113711 --- Looking good. Just some minor suggestions here and there.

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-11 Thread Joerg Schad
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 306-310 > > > > > > 1) what about adding "update Quota" here and remove it from L189 > > 2) no Quota Limit but only guarantee > > >

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 12, 2016, 2:03 a.m.) Review request for mesos, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-11 Thread Klaus Ma
> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review113930 --- Patch looks great! Reviews applied: [42172] Passed command:

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 12, 2016, 7:30 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41338: Added REASON_RESOURCES_PREEMPTED to mesos proto.

2016-01-11 Thread Klaus Ma
> On Jan. 12, 2016, 9:49 a.m., Joseph Wu wrote: > > Looks like the diff doesn't show up on the WebUI (The downloaded version > > looks fine though). This is possibly because r41434 is private. I've included this code in r41859. @Guangya, would you help to check whether this patch is still

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-11 Thread Guangya Liu
> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 4:04 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

2016-01-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/ --- (Updated Jan. 12, 2016, 6:26 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
> On Jan. 11, 2016, 8:45 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 102 > > > > > > Please do not use a `default` branch when switching over

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113873 --- Patch looks great! Reviews applied: [42040] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 12, 2016, 7:29 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 7:29 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113916 --- Ship it! docs/quota.md (line 61)

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review113923 --- Bad patch! Reviews applied: [41814, 41999, 41815, 41816, 41817,

Re: Review Request 41879: Removed constructor which uses restricted width.

2016-01-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/ --- (Updated Jan. 12, 2016, 7:57 a.m.) Review request for mesos, Michael Park and

Re: Review Request 41878: Consistently used fixed width types.

2016-01-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/ --- (Updated Jan. 12, 2016, 7:57 a.m.) Review request for mesos, Michael Park and

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113952 --- Patch looks great! Reviews applied: [42092, 42086] Passed

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-11 Thread Klaus Ma
> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 42106: Added helper function to return Error in condition.

2016-01-11 Thread Klaus Ma
> On Jan. 12, 2016, 2:03 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp, line 57 > > > > > > Why is there a redundant `while` here? It's used to avoid un-expected

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review113925 --- Bad patch! Reviews applied: [41958, 41959] Failed command:

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 12, 2016, 4:05 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 12, 2016, 4:04 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113944 --- Patch looks great! Reviews applied: [42053] Passed command:

Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

2016-01-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42165/#review113913 --- Greg, I think that the document of reservation.md should also be

Re: Review Request 42048: Defined of the CgroupNetClsIsolatorProcess.

2016-01-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42048/ --- (Updated Jan. 12, 2016, 6:27 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42097/ --- (Updated Jan. 12, 2016, 6:28 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/ --- (Updated Jan. 12, 2016, 2:28 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42097/ --- (Updated Jan. 12, 2016, 6:28 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-11 Thread Alex Clemmer
> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 130 > > > > > > Might want to static_assert that _USE_32BIT_TIME_T is not

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-11 Thread Klaus Ma
> On Jan. 11, 2016, 11:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 12, 2016, 7:30 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Joseph Wu
> On Jan. 8, 2016, 7:13 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 678-709 > > > > > > I saw that there is no test cases for offer validation, do you want to > > add inverseOffer test here? I

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 11, 2016, 1:31 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Kevin Klues
> On Jan. 8, 2016, 7:16 a.m., Anand Mazumdar wrote: > > LGTM. Two minor issues: > > > > 1. May be we can escape without passing the `Master` pointer around? > > 2. Would be great to have a test to go with this? I am submitting the test as a separate patch. > On Jan. 8, 2016, 7:16 a.m., Anand

  1   2   >