Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- (Updated March 29, 2016, 4:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

> On March 29, 2016, 5:02 a.m., Jie Yu wrote: > > Can you provide more context for this change? For instance, why change > > Watchdog and not Setsid? > > Joerg Schad wrote: > Before the enum name WATCHDOG was all capitalized (vs. Setsid). oops, i should not do reviews late night:) - Jie

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 4:33 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45429: Added authentication to the '/registry' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/ --- (Updated March 29, 2016, 5:46 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 45429: Added authentication to the '/registry' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/ --- (Updated March 29, 2016, 5:46 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125889 --- Fix it, then Ship it!

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- (Updated March 29, 2016, 3:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45419: Cleaned up ModuleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/ --- (Updated March 29, 2016, 3:41 p.m.) Review request for mesos, Benjamin Bannier

Review Request 45434: Added test cases for '/files' endpoint authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review125905 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review125882 --- Patch looks great! Reviews applied: [45371, 44378] Passed

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review125880 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125921 --- src/docker/docker.cpp (line 568)

Re: Review Request 45051: Fixed flakiness in ContainerLoggerTest.LOGROTATE_RotateInSandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45051/#review125942 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 7:32

Re: Review Request 45051: Fixed flakiness in ContainerLoggerTest.LOGROTATE_RotateInSandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45051/ --- (Updated March 29, 2016, 12:32 p.m.) Review request for mesos, Artem

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated March 29, 2016, 5:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 5:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review125923 --- Ship it! Ship It! - Daniel Pravat On March 14, 2016, 9:06

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 5:29 p.m.) Review request for mesos, Benjamin

Re: Review Request 44776: Did a general cleanup of s/.get()./->/ in the resources abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44776/#review125930 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 7:36

Re: Review Request 45423: Added note about preventing resource autodetecting to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45423/#review125929 --- Patch looks great! Reviews applied: [45423] Passed command:

Re: Review Request 44777: Added a flags parser for vector to src/common/parse.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/#review125931 --- Ship it! src/common/parse.hpp (line 123)

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 24, 2016, 4:54 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 95 > > > > > > This method aborts early when a error occurs, I think it's useful to > > note this. >

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 29, 2016, 8:54 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45438: Moved realm initialization from constructor to initializer list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45438/#review125950 --- Ship it! Ship It! - Till Toenshoff On March 29, 2016, 6:45

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 29, 2016, 8:51 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 29, 2016, 8:52 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45429: Added authentication to the '/registry' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/#review125960 --- Patch looks great! Reviews applied: [45429] Passed command:

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 29, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 29, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 29, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

> On March 22, 2016, 3:37 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 644-645 > > > > > > These two CHECKS don't make sense. What if the plugin got deleted

Review Request 45438: Moved realm initialization from constructor to initializer list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45438/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 45439: Completed implementation of the Nvidia GPU isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review125937 --- This review supercedes: https://reviews.apache.org/r/44979 -

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review125934 --- Ship it! Looks great, thanks! I'll just touch up some minor

Re: Review Request 45067: Updated the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated March 29, 2016, 12:08 p.m.) Review request for mesos, Greg Mann,

Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Re: Review Request 45419: Cleaned up ModuleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review125911 --- Ship it! src/module/manager.cpp (lines 41 - 42)

Re: Review Request 45067: Updated the long-lived-framework example.

> On March 28, 2016, 5:31 p.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 77 > > > > > > s/. Reject/. Reject/ <-- extraneous space Oops, that's a habit (and the Apache license uses 2 spaces

Re: Review Request 45438: Moved realm initialization from constructor to initializer list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45438/#review125932 --- Ship it! Ship It! - Greg Mann On March 29, 2016, 6:45 p.m.,

Re: Review Request 45434: Added test cases for '/files' endpoint authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/#review125964 --- Patch looks great! Reviews applied: [45434] Passed command:

Review Request 45454: Cleanup orphaned docker containers owned by previous agent instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45454/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/#review125965 --- Fix it, then Ship it! configure.ac (line 215)

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

> On March 18, 2016, 5:34 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 456 > > > > > > Can you please add some comments here for why `devolve`here? > > > > Do we have plan to update all `status`

Re: Review Request 45435: Modified scheduler library to properly handle SSL connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45435/#review125990 --- Ship it! LGTM. I'll let Joseph Wu take a look and ship it as

Re: Review Request 44366: Added GPUs as an explicit resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review125994 --- Ship it! Went over this with kevin, we'll be making some minor

Review Request 45451: Fix the local Docker puller for private registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45451/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5009

Review Request 45455: Added test for recovering orphaned docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45455/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-3573

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 29, 2016, 11:14 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45408: Introduced a `reconnect` method on the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45408/#review125981 --- include/mesos/v1/scheduler.hpp (line 50)

Re: Review Request 45410: Documented when to invoke `send` using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45410/#review125983 --- Ship it! Oh so you added it here. Cool. Can you specificy

Re: Review Request 45409: Added test for `reconnect` functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45409/#review125982 --- src/tests/scheduler_tests.cpp (line 1513)

Re: Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/ --- (Updated March 30, 2016, 12:16 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/ --- (Updated March 29, 2016, 11:08 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/#review125985 --- Fix it, then Ship it! docs/configuration.md (lines 1308 -

Re: Review Request 45435: Modified scheduler library to properly handle SSL connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45435/#review125992 --- Fix it, then Ship it! The approach LGTM.

Review Request 45450: Add JSON::Object::at() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45450/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5009

Review Request 45453: Minor spacing cleanups in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45453/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-3573

Re: Review Request 45398: Added CHANGELOG for python module changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45398/#review125971 --- Ship it! - Vinod Kone On March 29, 2016, 2:21 p.m., Steve

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review125974 --- Ship it! Ship It! - Vinod Kone On March 28, 2016, 10:32

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On March 29, 2016, 12:52 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, line 2193 > > > > > > since this value will not longer always map to the number of `cpus`, > > can we rename

Review Request 45461: Create tempfiles in test temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45461/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/ --- (Updated March 30, 2016, 12:19 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125835 --- src/docker/docker.cpp (lines 553 - 572)

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 29, 2016, 3:04 p.m.) Review request for mesos, Avinash

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 7:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 7:51 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 553-572 > > > > > > I prefer the following format: > > > > case ContainerInfo::DockerInfo::USER: { > > // User

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

> On March 29, 2016, 5:02 a.m., Jie Yu wrote: > > Can you provide more context for this change? For instance, why change > > Watchdog and not Setsid? Before the enum name WATCHDOG was all capitalized (vs. Setsid). - Joerg --- This is

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 8:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125841 --- src/docker/docker.cpp (line 567)

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 29, 2016, 3:11 p.m.) Review request for mesos, Avinash

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/#review125832 --- Patch looks great! Reviews applied: [45397] Passed command:

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated March 29, 2016, 8:56 a.m.) Review request for mesos, Benjamin

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 8:56 a.m.) Review request for mesos, Benjamin

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

> On March 29, 2016, 3:30 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 127 > > > > > > What does "flat" mean, here? Also, is it worth adding a `CHECK` that > > all

Re: Review Request 45410: Documented when to invoke `send` using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45410/#review125843 --- Patch looks great! Reviews applied: [45408, 45409, 45410]

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 29, 2016, 1:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 354 > > > > > > Should we return a Failure here instead? I think we should not return a Failure

Re: Review Request 45419: Cleaned up ModuleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review125849 --- src/module/manager.hpp (line 24)

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 29, 2016, 6:28 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 29, 2016, 6:34 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 29, 2016, 6:58 p.m.) Review request for mesos, Avinash

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 29, 2016, 6:59 p.m.) Review request for mesos, Avinash

Re: Review Request 45381: Pass containerizer to ResourceMonitor and ResourceMonitorProcess.

> On March 28, 2016, 3:52 p.m., Guangya Liu wrote: > > src/slave/slave.hpp, lines 398-399 > > > > > > A question here: What is the use of this API? > > Jay Guo wrote: > This line of code is leaked from another

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review125847 --- Bad patch! Reviews applied: [44378, 45371] Failed command:

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125853 --- Patch looks great! Reviews applied: [45342] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 10:46 a.m.) Review request for mesos and Timothy

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 29, 2016, 6:47 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 29, 2016, 7 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 42516: Add support for user-defined networks.

> On 三月 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 45381: Pass containerizer to ResourceMonitor and ResourceMonitorProcess.

> On March 28, 2016, 11:02 p.m., Jie Yu wrote: > > Chatted with BenM on this. I think we should just kill the ResourceMonitor > > and move all the logics to the agent. We still need to keep the > > /monitor/statistics.json and /monitor/statistics endpoints for backwards > > compatibility. But

  1   2   >