Re: Review Request 50482: Fixed the CORS error when redirect in webui.

> On July 27, 2016, 5:49 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp, line 2038 > > > > > > Is `request.url.path == stringify(request.url)` guaranteed? Even if it > > is, would `request.url.path` be more

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/#review143680 --- More comments: 1) Seems you are losing two cases to handle the

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- (Updated July 27, 2016, 6:57 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

> On July 27, 2016, 7:16 a.m., Jiang Yan Xu wrote: > > Sorry I should have mentioned, although it's fine as a follow up, now that > > we don't do redirects in the UI anymore, we should also clean up the UI and > > javascript for the countdown of the redirect right? Yes, let me remove them.

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On July 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 349 > > > > > > Why do you add the comment here? This flag does not seems to related to > > gpu. This should be merged

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review143705 --- Patch looks great! Reviews applied: [43015, 43569] Passed

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143682 --- Patch looks great! Reviews applied: [50482] Passed command:

Re: Review Request 50124: Added '--device' flag to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50124/#review143697 --- src/docker/executor.hpp (lines 77 - 93)

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1357 > > > > > > Seems no one is using `nvidiaGpus`? It should be set as parameter for > > `--device` when running

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143713 --- Patch looks great! Reviews applied: [50488, 50482] Passed

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- (Updated July 27, 2016, 9:35 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

> On July 27, 2016, 7:22 a.m., Vinod Kone wrote: > > Sorry, I don't understand the fix. Can you elaborate in the description? My bad, the patch is confuse before, now I split it to two patches and update the description and testing done field. - haosdent

Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50488/ --- Review request for mesos, Adam B, Jie Yu, Michael Lunøe, Vinod Kone, and Jiang

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 2:15 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1560 > > > > > > how about > > ``` > > allocator->deallocate(deallocated); > > ``` > > > > Why do

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50477/#review143747 --- 3rdparty/libprocess/include/process/socket.hpp (line 111)

Re: Review Request 50499: Added logic in master/main.cpp to use log network module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/#review143740 --- Failure is related to flaky test bug

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 11:16 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1305-1311 > > > > > > One question for this: I found that the `nvidia devices` was created as > > a `devices string`

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

> On 七月 25, 2016, 3:06 a.m., zhou xing wrote: > > src/master/http.cpp, line 491 > > > > > > just wonder if we can just use regexp to extract string > > 'application/json' or 'application/x-protobuf' from

Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Yubo Li. Bugs:

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50488/#review143762 --- src/master/http.cpp (lines 2039 - 2051)

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 27, 2016, 6:21 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50518: Clarified log messages during master startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50518/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 26, 2016, 10:03 p.m., Jie Yu wrote: > > Thanks a lot for your review, let me apply your comments in the other patches of this chain as well. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143756 --- Ship it! LGTM, @mlunoe could you also take a look? - Jiang

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143757 --- Ship it! LGTM, @mlunoe could you also take a look? - Jiang

Review Request 50516: Fixed quoting for executor and task IDs in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50516/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 50301: Reduced logging verbosity for replicated log operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50301/ --- (Updated July 27, 2016, 5:29 p.m.) Review request for mesos and Anand

Review Request 50520: Tweaked agent logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50520/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 50517: Reduced verbosity of version logging in executor/scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50517/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 5:47 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143773 --- I would really like to avoid {{jsonp}} (as it is basically a

Re: Review Request 50520: Tweaked agent logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50520/#review143782 --- Patch looks great! Reviews applied: [50301, 50516, 50517, 50518,

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

> On July 27, 2016, 8:43 a.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 111 > > > > > > May we show `close.error()` here? The `CHECK_SOME` macro will include the error message

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 10:47 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50524/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Yubo Li. Bugs:

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50524/#review143803 --- Bad patch! Reviews applied: [50524, 50523, 50128, 50127, 50126,

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 10:47 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Review Request 50528: Set allocation level explicitly instead of implicitly in v1 api tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50528/ --- Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. Bugs:

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50477/#review143784 --- Fix it, then Ship it! LGTM + some comment tweaks. This review

Re: Review Request 50490: Moved ZooKeeperNetwork into separate hpp and cpp files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50490/#review143808 --- src/Makefile.am (line 1220)

Re: Review Request 50235: Added more expectations to TASK_LOST test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/#review143828 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143822 --- Ship it! I fixed a few style nits while committing.

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50477/#review143805 --- Fix it, then Ship it! Thanks for taking this on Ben!

Review Request 50535: Updated docker volume isolator to return non-shell 'pre_exec_commands'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50535/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143849 --- src/webui/master/static/js/controllers.js (line 60)

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review143587 --- 3rdparty/libprocess/src/process.cpp (line 321)

Re: Review Request 50418: Cleaned up comments in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50418/#review143853 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 9:35 p.m.,

Re: Review Request 50417: Improved consistency of test code for partitioning an agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/#review143852 --- Ship it! I'm assuming the `Clock::settle()` is no longer

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/#review143855 --- src/tests/slave_tests.cpp (line 2381)

Re: Review Request 50338: Fixed flakiness in SlaveAuthorizerTest.ViewFlags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50338/#review143859 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 1:35 p.m.,

Re: Review Request 50339: Fixed comment typos and whitespace infelicities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50339/#review143860 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 1:35 p.m.,

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/#review143862 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 5:39 p.m.,

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 5:47 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/ --- Review request for mesos, David Robinson and Ian Downes. Bugs: MESOS-5376

Re: Review Request 50416: Added more assertions to master code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50416/#review143851 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 9:35 p.m.,

Re: Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/ --- (Updated July 27, 2016, 11:38 p.m.) Review request for mesos, David Robinson

Re: Review Request 50528: Set allocation level explicitly instead of implicitly in v1 api tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50528/#review143856 --- Ship it! Ship It! - Vinod Kone On July 27, 2016, 7:43 p.m.,

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

> On July 27, 2016, 4:35 p.m., Greg Mann wrote: > > I'm seeing the following test failure after applying this patch chain: > > > > ``` > > [ RUN ] MesosSchedulerDriverTest.MetricsEndpoint > > ../../src/tests/scheduler_driver_tests.cpp:103: Failure > > Value of: (response).get().status > >

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/#review143863 --- docs/getting-started.md (line 50)

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review143861 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review143866 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (line

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

> On July 27, 2016, 11:35 p.m., Greg Mann wrote: > > I'm seeing the following test failure after applying this patch chain: > > > > ``` > > [ RUN ] MesosSchedulerDriverTest.MetricsEndpoint > > ../../src/tests/scheduler_driver_tests.cpp:103: Failure > > Value of: (response).get().status > >

Re: Review Request 50528: Set allocation level explicitly instead of implicitly in v1 api tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50528/#review143816 --- Ship it! Ship It! - Neil Conway On July 27, 2016, 7:43

Review Request 50534: Updated mesos containerizer launch execute() to return 'EXIT_FAILURE'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50534/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 50214: Supported non-shell command in MesosLaunch to avoid arbitrary commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50214/ --- (Updated July 27, 2016, 2:39 p.m.) Review request for mesos, Artem

Re: Review Request 50528: Set allocation level explicitly instead of implicitly in v1 api tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50528/#review143834 --- Patch looks great! Reviews applied: [50528] Passed command:

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review143844 --- src/slave/containerizer/docker.cpp (lines 1305 - 1311)

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/#review143840 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 5:10 p.m.,

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/#review143841 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 5:11 p.m.,

Review Request 50492: Moved Network declaration into Mesos headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Review Request 50498: Added --log_network flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5829

Review Request 50495: Added log network module struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Review Request 50491: Moved Network and NetworkProcess definitions into cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Review Request 50499: Added logic in master/main.cpp to use log network module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5829

Review Request 50497: Added new constructors in Log and LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Review Request 50496: Added static `create` method to log::Network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Review Request 50493: Added Log Network and ZooKeeperNetwork to namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Re: Review Request 50535: Updated docker volume isolator to return non-shell 'pre_exec_commands'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50535/#review143878 --- Patch looks great! Reviews applied: [50214, 50534, 50535]

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 10:47 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

> On July 27, 2016, 5:47 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp, lines 2039-2051 > > > > > > It would be great if we don't duplicate code from > >

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

> On July 27, 2016, 10:36 p.m., Jie Yu wrote: > > Ship It! > > Jie Yu wrote: > I made some adjustments while committing. Thanks a lot! Comparing and learning what you adjusted in this chain, let me avoid them in other patches. - haosdent

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/#review143837 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 5:10 p.m.,

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

> On July 27, 2016, 10:36 p.m., Jie Yu wrote: > > Ship It! I made some adjustments while committing. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/#review143837

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/#review143843 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 5:11 p.m.,

Re: Review Request 50491: Moved Network and NetworkProcess definitions into cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/ --- (Updated July 28, 2016, 5:20 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50492: Moved Network declaration into Mesos headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ --- (Updated July 28, 2016, 5:23 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50493: Added Log Network and ZooKeeperNetwork to namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/ --- (Updated July 28, 2016, 5:25 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50495: Added log network module struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/ --- (Updated July 28, 2016, 5:26 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50496: Added static `create` method to log::Network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- (Updated July 28, 2016, 5:27 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50494: Change module parameters override to merge instead of replace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50494/ --- (Updated July 28, 2016, 5:25 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50498: Added --log_network flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- (Updated July 28, 2016, 5:28 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50497: Added new constructors in Log and LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/ --- (Updated July 28, 2016, 5:27 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50499: Added logic in master/main.cpp to use log network module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- (Updated July 28, 2016, 5:28 a.m.) Review request for mesos and Joseph Wu.