Re: Review Request 52803: Changed agent to send TASK_GONE.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/ --- (Updated Oct. 13, 2016, 3:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- (Updated Oct. 13, 2016, 2:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52828/ --- (Updated Oct. 13, 2016, 2:33 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review152507 --- src/tests/health_check_tests.cpp (line 1679)

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 13, 2016, 2:30 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 13, 2016, 2:33 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152509 --- src/tests/health_check_tests.cpp (line 1516)

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-13 Thread Gastón Kleiman
> On Oct. 13, 2016, 1:18 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 1506 > > > > > > Shouldn't this test also use netcat? I moved this comment to the right RR. - Gastón

Review Request 52827: Added backend suffix to image layer rootfs path.

2016-10-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52827/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6360

Re: Review Request 52723: Changed agent to send TASK_DROPPED during reconciliation.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52723/ --- (Updated Oct. 13, 2016, 3:10 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/#review152501 --- Patch looks great! Reviews applied: [52817, 52470, 52520, 52471,

Re: Review Request 45967: Added documentation for shareable resources.

2016-10-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review152517 --- Ship it! I have some additional comments but let's check this

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152530 --- Can you write the exact test procedure you used to run the

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review152526 --- docs/executor-http-api.md (line 352)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 4:59 p.m., Kevin Klues wrote: > > Can you write the exact test procedure you used to run the command and test > > it? Got it! Added. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52676: Made stout's tests a phony target.

2016-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52676/#review152548 --- Ship it! Ship It! - Kapil Arya On Oct. 10, 2016, 7:54 a.m.,

Re: Review Request 52677: Added all test dependency to libprocess' tests target.

2016-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52677/#review152547 --- Ship it! Ship It! - Kapil Arya On Oct. 10, 2016, 7:54 a.m.,

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152524 --- Patch looks great! Reviews applied: [52787] Passed command:

Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/ --- (Updated Oct. 13, 2016, 5:04 p.m.) Review request for mesos, Alexander

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152543 --- This does not work for me. I still see: ``` [klueska@core-dev

Re: Review Request 52773: Added a loopback test with CNI ptp plugin.

2016-10-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52773/ --- (Updated Oct. 13, 2016, 4:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

2016-10-13 Thread Jie Yu
> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Oct. 13, 2016, 5:06 p.m.) Review request for mesos, Jie Yu and Kevin

Review Request 52831: Corrected usage of "it's" in stout.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52831/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 52830: Corrected usage of "it's" in libprocess.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52830/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 52832: Corrected usage of "it's" in Mesos.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52832/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 52718: Added v1 api helpers to create calls in 'tests/mesos.hpp'.

2016-10-13 Thread Gilbert Song
> On Oct. 10, 2016, 7:56 p.m., Anand Mazumdar wrote: > > Thanks for introducing these test helpers Gilbert. These would be very > > useful for everyone. > > > > Most of my comments are around whether we can add these as gtest custom > > actions instead. Though, we can argue for having both, I

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 3:02 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 1679 > > > > > > This test is flaky, because the master will sometimes not listen on > > 127.0.0.1. > > > >

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-13 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 13, 2016, 6:52 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 5:52 p.m., Kevin Klues wrote: > > This does not work for me. I still see: > > > > ``` > > [klueska@core-dev build]$ ./src/mesos-execute --master=127.0.0.1:5050 > > --name="test-single-1" --command="sleep 2000" > > I1013 10:47:08.270723 38083 scheduler.cpp:176] Version:

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 3:04 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 1516 > > > > > > This test is flaky, because the master will sometimes not listen on > > 127.0.0.1. > > > >

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152553 --- src/tests/health_check_tests.cpp (line 1516)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread Kevin Klues
> On Oct. 13, 2016, 5:52 p.m., Kevin Klues wrote: > > This does not work for me. I still see: > > > > ``` > > [klueska@core-dev build]$ ./src/mesos-execute --master=127.0.0.1:5050 > > --name="test-single-1" --command="sleep 2000" > > I1013 10:47:08.270723 38083 scheduler.cpp:176] Version:

Re: Review Request 52677: Added all test dependency to libprocess' tests target.

2016-10-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52677/ --- (Updated Oct. 13, 2016, 9:33 p.m.) Review request for mesos, Kapil Arya and

Review Request 52841: Provided more information on failed parallel tests.

2016-10-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52841/ --- Review request for mesos, Alexander Rukletsov and Till Toenshoff. Bugs:

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152581 --- Patch looks great! Reviews applied: [52828, 52058] Passed

Re: Review Request 51617: Added the `remove` and `insert` methods.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152569 ---

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52828/ --- (Updated Oct. 13, 2016, 9:36 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

2016-10-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review152538 --- src/master/validation.cpp (lines 500 - 501)

Re: Review Request 52841: Provided more information on failed parallel tests.

2016-10-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52841/#review152578 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 13, 2016,

Re: Review Request 51486: Added `execute` method.

2016-10-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/ --- (Updated Oct. 13, 2016, 8:32 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51617: Added the `remove` and `insert` methods.

2016-10-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 13, 2016, 8:33 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52827: Added backend suffix to image layer rootfs path.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52827/#review152585 --- src/slave/containerizer/mesos/provisioner/docker/paths.cpp

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-10-13 Thread Joseph Wu
> On Aug. 2, 2016, 4:03 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os/rmdir_tests.cpp, lines 116-117 > > > > > > Since these two sets are only modified once within the test, why not do: > > ``` > >

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152600 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp

Re: Review Request 52830: Corrected usage of "it's" in libprocess.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52830/#review152597 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2016, 10:49 a.m.,

Re: Review Request 52831: Corrected usage of "it's" in stout.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52831/#review152598 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2016, 10:49 a.m.,

Re: Review Request 52832: Corrected usage of "it's" in Mesos.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52832/#review152599 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2016, 10:49 a.m.,

Review Request 52847: Fixed docker v2 image manifest protobuf definition.

2016-10-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52847/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Kevin Klues, and Timothy

Re: Review Request 52827: Added backend suffix to image layer rootfs path.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52827/#review152601 --- Patch looks great! Reviews applied: [52827] Passed command:

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50674/#review152610 --- Fix it, then Ship it! 3rdparty/stout/include/stout/gtest.hpp

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

2016-10-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52828/#review152606 --- Fix it, then Ship it! src/tests/slave_tests.cpp (line 932)

Review Request 52848: Cleaned up style in stout rmdir_tests.cpp.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52848/ --- Review request for mesos, Daniel Pravat, Alex Clemmer, Joris Van Remoortere,

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/#review152629 --- Fix it, then Ship it!

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-13 Thread Avinash sridharan
> On Oct. 14, 2016, 4:34 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 198-209 > > > > > > Ditto. Yeah we actually don't need this anymore. Didn't realize `os::which`

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 14, 2016, 3:03 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 397-398 > > > > > > ``` > > if (device.isError()) { > > return Error("Failed to parse device from HostConfig.Devices entry"

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

2016-10-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Oct. 14, 2016, 3:23 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

2016-10-13 Thread Anindya Sinha
> On Oct. 13, 2016, 9:58 p.m., Jiang Yan Xu wrote: > > src/master/validation.cpp, lines 503-504 > > > > > > MESOS-6374 is where we want eventually but for now the same check is in > > `validateDiskInfo()` as well

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review152516 --- src/docker/docker.hpp (lines 98 - 101)

Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/#review152625 --- Patch looks great! Reviews applied: [52814] Passed command:

Review Request 52854: Fixed the sandbox owner for command tasks.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52854/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6391

Review Request 52855: Re-enabled the change user test in slave tests.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52855/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6391

Re: Review Request 52847: Fixed docker v2 image manifest protobuf definition.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52847/#review152626 --- Ship it! Ship It! - Jie Yu On Oct. 13, 2016, 11:25 p.m.,

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review152628 --- src/local/local.cpp (line 183)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 5:52 p.m., Kevin Klues wrote: > > This does not work for me. I still see: > > > > ``` > > [klueska@core-dev build]$ ./src/mesos-execute --master=127.0.0.1:5050 > > --name="test-single-1" --command="sleep 2000" > > I1013 10:47:08.270723 38083 scheduler.cpp:176] Version:

Review Request 52853: Fixed typo in a comment in hooks.hpp.

2016-10-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52853/ --- Review request for mesos and Kapil Arya. Repository: mesos Description

Re: Review Request 52852: Fixed handling of deprecated SSL_ prefix.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52852/#review152621 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2016, 6:56 p.m.,

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

2016-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review152515 --- You need a rebase for this patch.

Review Request 52856: Reverted incorrect changes in 1c2ee5c.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52856/ --- Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Oct. 14, 2016, 4:26 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

2016-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50675/ --- (Updated Oct. 14, 2016, 1:10 a.m.) Review request for mesos, Daniel Pravat and

Review Request 52852: Fixed handling of deprecated SSL_ prefix.

2016-10-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52852/ --- Review request for mesos, Adam B, Benjamin Bannier, and Joseph Wu. Repository:

Re: Review Request 52852: Fixed handling of deprecated SSL_ prefix.

2016-10-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52852/ --- (Updated Oct. 14, 2016, 1:56 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50673/#review152609 --- Ship it! With the cleanups in (

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

2016-10-13 Thread Alex Clemmer
> On Oct. 14, 2016, 12:30 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, lines 129-131 > > > > > > What about defining a macro: > > ``` > > #ifndef __WINDOWS__ > > #define

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

2016-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50674/ --- (Updated Oct. 14, 2016, 1:06 a.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 52803: Changed agent to send TASK_GONE.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/#review152616 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review152514 --- src/docker/docker.hpp (line 336)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
> On Oct. 13, 2016, 5:48 a.m., Kevin Klues wrote: > > I should have looked at this more carefully before giving it a Ship it. It > > seemed reasonable at first glance though. > > > > Did you attempt to compile it before posting the patch? Looks like there > > were errors with the flags

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Oct. 13, 2016, 6:44 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/ --- (Updated Oct. 13, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 13, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52817: Added utils method to check if `ExecutorInfo` different.

2016-10-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52817/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-13 Thread Yubo Li
> On 十月 11, 2016, 3:40 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2150-2151 > > > > > > Here will cause failure if gpu is not enabled, the ideal logic could be: > > > > ``` > >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-13 Thread Yubo Li
> On 十月 12, 2016, 7:31 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 643-696 > > > > > > I was thinking for how to make less code change but need to make sure > > build passed on mac. > >

Review Request 52818: Ensured agent is registered in SlaveEndpointTests.

2016-10-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52818/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/#review152467 --- Bad patch! Reviews applied: [52814] Failed command:

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-10-13 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 13, 2016, 10:13 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-13 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 13, 2016, 10:14 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-10-13 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 13, 2016, 10:15 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 13, 2016, 10:15 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

2016-10-13 Thread Gastón Kleiman
> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 49571: Added a benchmark test for allocations.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review152478 --- Patch looks great! Reviews applied: [45962, 49571] Passed

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152490 --- src/tests/health_check_tests.cpp (line 1506)

Re: Review Request 45967: Added documentation for shareable resources.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review152485 --- Patch looks great! Reviews applied: [45963, 45967] Passed

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

2016-10-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/ --- (Updated Oct. 13, 2016, 2:22 p.m.) Review request for mesos and Jie Yu.

  1   2   >