Re: Review Request 53386: Fixed memory leak in JVM code.

> On Nov. 2, 2016, 4:39 p.m., Benjamin Bannier wrote: > > src/jvm/jvm.cpp, lines 97-102 > > > > > > This will work as long nobody adds new `return` statements before the > > corresponding `delete`. > > > >

Re: Review Request 53285: Show the leader information in WebUI.

> On Oct. 31, 2016, 10:47 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/home.html, line 26 > > > > > > Since `hostname` is deprecated, use `address.hostname`? If that's not > > available, fall back to the

Review Request 53394: Fix incorrect indent in `files.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53394/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 53389: Used `MasterInfo.address` to generate the leader information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53389/ --- Review request for mesos, Vinod Kone and Jiang Yan Xu. Bugs: MESOS-6534

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 2, 2016, 10:52 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 290 > > > > > > I think using an `off_t` for a size is semantically incorrect; I'd stay > > with `size_t`. This

Review Request 53393: Fixed a typo in `gpu-support.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53393/ --- Review request for mesos, Joseph Wu, Kevin Klues, and Vinod Kone. Repository:

Re: Review Request 53350: Removed unnecessary 'parentHooks' parameter from 'Launcher::fork()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53350/#review154593 --- Ship it! Ship It! - Jie Yu On Nov. 1, 2016, 10:27 p.m.,

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/#review154588 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 659)

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Nov. 2, 2016, 5:14 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 30 > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimizer one less

Re: Review Request 53386: Fixed memory leak in JVM code.

> On Nov. 2, 2016, 5:39 p.m., Benjamin Bannier wrote: > > src/jvm/jvm.cpp, lines 97-102 > > > > > > This will work as long nobody adds new `return` statements before the > > corresponding `delete`. > > > >

Re: Review Request 53387: Silenced some `clang-tidy` warnings in test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/#review154626 --- Fix it, then Ship it! Thanks for fixing these Neil! I opened

Re: Review Request 53381: Added a "Known Bugs" section to CHANGELOG for 1.1.0.

> On Nov. 2, 2016, 7:59 p.m., Vinod Kone wrote: > > CHANGELOG, line 102 > > > > > > How is this list being generated? "Affected Version" = 1.1.0 AND > > "priority" = critical? Would prefer to avoid hand generating

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/#review154624 --- CHANGELOG (line 125)

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Nov. 2, 2016, 8:41 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 2, 2016, 8:41 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53381: Added a "Known Bugs" section to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/#review154622 --- CHANGELOG (line 102)

Re: Review Request 53380: Moved Mesos specific build target definition into Mesos CMakeFile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53380/#review154613 --- Patch looks great! Reviews applied: [53379, 53380] Passed

Re: Review Request 53351: Added 'ContainerClass' to help decide how best to launch a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53351/#review154594 --- include/mesos/slave/containerizer.proto (line 32)

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Nov. 2, 2016, 8:47 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 2, 2016, 8:47 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review154530 --- Fix it, then Ship it! 3rdparty/libprocess/src/decoder.hpp

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review154535 --- Fix it, then Ship it! 3rdparty/libprocess/src/profiler.cpp

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154537 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review154538 --- Ship it! Ship It! - Till Toenshoff On Oct. 31, 2016, 6:55

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

> On Nov. 2, 2016, 11:33 a.m., Till Toenshoff wrote: > > Ship It! modulo my comments :) - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review154538

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review154533 --- src/health-check/tcp_connect.cpp (lines 17 - 18)

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review154529 --- Fix it, then Ship it! Looks great, thanks a lot for cleaning

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52828/#review154647 --- src/slave/containerizer/fetcher.cpp (lines 784 - 786)

Re: Review Request 53352: Updated 'LinuxLauncher->fork()` with *enter* and *clone* namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53352/#review154637 --- Fix it, then Ship it!

Re: Review Request 53378: Fixed the command executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53378/ --- (Updated Nov. 2, 2016, 9:51 p.m.) Review request for mesos, Alexander

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/ --- (Updated Nov. 2, 2016, 10:06 p.m.) Review request for mesos, Alexander

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 2, 2016, 10:06 p.m.) Review request for mesos, Alexander

Re: Review Request 53393: Fixed a typo in `gpu-support.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53393/#review154651 --- Ship it! Ship It! - Joseph Wu On Nov. 2, 2016, 10:35 a.m.,

Review Request 53406: Add a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 53380: Moved Mesos specific build target definition into Mesos CMakeFile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53380/#review154652 --- Fix it, then Ship it! src/CMakeLists.txt (lines 521 - 524)

Re: Review Request 53379: Removed Mesos specific build targets from libprocess CMakeFile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53379/#review154653 --- Ship it! LGTM, pending a tweak in the following review. -

Re: Review Request 53344: Updated `/slaves.md` doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53344/#review154648 --- Patch looks great! Reviews applied: [53095, 52637, 52638, 52765,

Re: Review Request 53385: Add a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 2, 2016, 10:05 p.m.) Review request for mesos, Alexander

Re: Review Request 53389: Used `MasterInfo.address` to generate the leader information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53389/#review154657 --- Patch looks great! Reviews applied: [53389] Passed command:

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

> On Oct. 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 723 > > > > > > Can you just use `stringify()` here? Also, can you use `Path().join()` > > instead of just `+`. > >

Review Request 53411: Use a random TCP port for framework tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53411/ --- Review request for mesos. Bugs: MESOS-6537

Re: Review Request 53413: Fix FD leak due to exiting early in mesos fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53413/ --- (Updated Nov. 2, 2016, 11:48 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 53386: Fixed memory leak in JVM code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/ --- (Updated Nov. 2, 2016, 11:56 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On Oct. 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 2161 > > > > > > Maybe consider using a ":" here instead of a comma? > > Guangya Liu wrote: > After a second

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review154663 --- Ship it! Ship It! - Benjamin Mahler On Nov. 2, 2016, 7:26

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review154662 --- Ship it! Ship It! - Kevin Klues On Nov. 2, 2016, 7:26 a.m.,

Review Request 53413: Fix FD leak due to exiting early in mesos fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53413/ --- Review request for mesos, Joseph Wu and Jiang Yan Xu. Bugs: MESOS-5218

Re: Review Request 53381: Added a "Known Bugs" section to CHANGELOG for 1.1.0.

> On Nov. 2, 2016, 7:59 p.m., Vinod Kone wrote: > > CHANGELOG, line 102 > > > > > > How is this list being generated? "Affected Version" = 1.1.0 AND > > "priority" = critical? Would prefer to avoid hand generating

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

> On Nov. 2, 2016, 8:01 p.m., Vinod Kone wrote: > > CHANGELOG, line 132 > > > > > > Should we also have a list of features that have transitioned from > > experimental to stable? I think we should call such

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

> On Nov. 2, 2016, 10:36 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 788-790 > > > > > > This short-circuit leaks the two FDs opened above. RR for this fix:

Re: Review Request 53413: Fix FD leak due to exiting early in mesos fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53413/#review154665 --- Ship it! Confirmed this fixes the FD leak. - Joseph Wu On

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/#review154634 --- Patch looks great! Reviews applied: [53381, 53382, 53383, 53384]

Re: Review Request 53353: Introduced a new 'DEBUG' container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53353/#review154640 --- Ship it! Ship It! - Jie Yu On Nov. 1, 2016, 10:28 p.m.,

Review Request 53407: Fixed the Docker executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53407/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs:

Re: Review Request 53387: Silenced some `clang-tidy` warnings in test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/#review154673 --- Patch looks great! Reviews applied: [53386, 53387] Passed

Re: Review Request 53394: Fix incorrect indent in `files.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53394/#review154669 --- Patch looks great! Reviews applied: [53394] Passed command:

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review154668 --- Fix it, then Ship it! It would be great to describe the

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Nov. 2, 2016, 1:22 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, lines 158-159 > > > > > > This sounds pretty hacky to me. What if there are multiple 'rootfs' > > along

Re: Review Request 53341: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53341/#review154548 --- Ship it! - Benjamin Bannier On Nov. 1, 2016, 5:26 p.m.,

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

> On Nov. 2, 2016, 1:05 a.m., Zhitao Li wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, lines 699-706 > > > > > > Is it possible to paste the Dockerfile used to build this image in this > >

Re: Review Request 50128: Added helper function to 'Docker::Device'.

> On 十一月 1, 2016, 3:19 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 756 > > > > > > I think that we actually need to check invalid permissions here, as it > > is possible that there are invalid

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Nov. 2, 2016, 9:03 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 53372: MESOS-5662: Fixed parent class SetUpTestCase calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53372/#review154546 --- Patch looks great! Reviews applied: [53372] Passed command:

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/#review154547 --- Ship it! Thanks for

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

> On Nov. 2, 2016, 1:37 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 675 > > > > > > Hum, does this work? Do you need to have filters? Aufs and overlayfs is > > not always

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review154556 --- Fix it, then Ship it! Ship It! src/executor/executor.cpp

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 2, 2016, 4:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 2, 2016, 10:52 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 290 > > > > > > I think using an `off_t` for a size is semantically incorrect; I'd stay > > with `size_t`. This

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > I would really like to see actual timings of e.g., an optimized build > > before and after introducing these new flags, e.g., the runtime of > > `libprocess-tests` and `benchmarks`. Just attached a bunch of benchmarking info that I had

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 2, 2016, 3:14 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 29 > > > > > > Let's not suppress this valid and potentially useful diagnostic for the > > whole codebase. It does not

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 2, 2016, 3:35 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > I would really like to see actual timings of e.g., an optimized build > > before and after introducing these new flags, e.g., the runtime of > > `stout-tests`. Just attached a bunch of benchmarking info that I had saved from when I

Review Request 53378: Made the executors skip health updates after killing a task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53378/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6457

Review Request 53379: Removed Mesos specific build targets from libprocess CMakeFile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53379/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Alex Clemmer,

Review Request 53380: Moved Mesos specific build target definition into Mesos CMakeFile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53380/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Alex Clemmer,

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review154519 --- Patch looks great! Reviews applied: [53350, 53351, 53352, 53353,

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/ --- (Updated Nov. 2, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review154558 --- Ship it! Ship It! - haosdent huang On Oct. 31, 2016, 6:56

Review Request 53375: Tweaked some CHANGELOG text for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53375/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review154561 --- Patch looks great! Reviews applied: [51425, 50123, 50841, 50128,

Re: Review Request 53375: Tweaked some CHANGELOG text for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53375/#review154562 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 2, 2016,

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

> On Nov. 2, 2016, 1:26 p.m., Till Toenshoff wrote: > > Thanks for https://issues.apache.org/jira/browse/MESOS-6309 -- we need to > > fix that immediately, it is just too bizarre to leave as is. Just proposed a fix for the above by https://reviews.apache.org/r/53379/ and

Re: Review Request 53378: Made the executors skip health updates after killing a task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53378/ --- (Updated Nov. 2, 2016, 3:47 p.m.) Review request for mesos and Alexander

Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Repository:

Re: Review Request 52645: Harden Mesos

> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am, line 120 > > > > > > Not sure we want to remove the existing `-Werror`. >From a discussion with a few people on Slack it sounded like this

Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Repository:

Review Request 53381: Added a "Known Bugs" section to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Repository:

Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Repository:

Review Request 53385: Ensured that tasks don't transition from KILLING to RUNNING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6457

Review Request 53386: Fixed memory leak in JVM code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 53387: Silenced some `clang-tidy` warnings in test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 53378: Made the executors skip health updates after killing a task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53378/#review154574 --- CHANGELOG (lines 61 - 64)

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review154569 --- Ship it! src/health-check/health_checker.cpp (line 77)

Re: Review Request 53381: Added a "Known Bugs" section to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/#review154577 --- CHANGELOG (line 102)

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. Agreed. But since

Re: Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/#review154580 --- Fix it, then Ship it! docs/release-guide.md (line 79)

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

> On Nov. 2, 2016, 4:29 p.m., Till Toenshoff wrote: > > src/health-check/health_checker.cpp, line 77 > > > > > > Some abstraction doing this automagically would be cool to have, no? > > e.g. `Path::runnable(string)`

Re: Review Request 51608: Extracted "curl" binary into HTTP_CHECK_COMMAND constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51608/#review154583 --- Ship it! src/health-check/health_checker.cpp (line 79)

  1   2   >