Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180510 --- src/slave/gc.hpp Lines 122-123 (patched)

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 11, 2017, 6:47 p.m., Jiang Yan Xu wrote: > > src/slave/gc.cpp > > Lines 179 (patched) > > > > > > Better to call `onAny` and then `CHECK` that it's always ready in the > > continuation so the intention is

Re: Review Request 60788: Windows: Fixed long path support in `reparsepoint.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60788/#review180556 --- Ship it! Ship It! - Joseph Wu On July 11, 2017, 6:44 p.m.,

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 12, 2017, 5:27 p.m., James Peach wrote: > > I think that a better approach is to define a static `UPID > > UPID::anonymous()` function that returns a well-defined anonymous UPID for > > the system. Remove all the sending functions that don't specify a `from` > > UPID and force them

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 12, 2017, 5:27 p.m., James Peach wrote: > > I think that a better approach is to define a static `UPID > > UPID::anonymous()` function that returns a well-defined anonymous UPID for > > the system. Remove all the sending functions that don't specify a `from` > > UPID and force them

Re: Review Request 60636: Added method returning allocated resources for framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60636/#review180595 --- Fix it, then Ship it! Looks good, thanks Andrei! What I'll do

Re: Review Request 60879: Preventing agent recovery failing from unsuccessful `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60879/#review180589 --- Ship it! Ship It! - Jie Yu On July 14, 2017, 7:16 p.m.,

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 12, 2017, 5:27 p.m., James Peach wrote: > > I think that a better approach is to define a static `UPID > > UPID::anonymous()` function that returns a well-defined anonymous UPID for > > the system. Remove all the sending functions that don't specify a `from` > > UPID and force them

Re: Review Request 60867: Added method returning allocated resources for executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/#review180593 --- src/slave/slave.hpp Lines 796-797 (original), 798-799 (patched)

Re: Review Request 60867: Added method returning allocated resources for executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/#review180598 --- src/slave/slave.cpp Lines 7816-7818 (patched)

Review Request 60876: Improved calculation of allocated resources on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60876/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Review Request 60877: Improved calculation of resource limits for containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60877/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Re: Review Request 60877: Improved calculation of resource limits for containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60877/#review180576 --- Patch looks great! Reviews applied: [60867, 60636, 60369, 60539,

Re: Review Request 60846: WIP: Retry logic for unsuccessful `docker rm` during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/ --- (Updated July 14, 2017, 7:16 p.m.) Review request for Gilbert Song and Jie Yu.

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review180577 --- Patch looks great! Reviews applied: [60203, 59294] Passed

Re: Review Request 60846: Preventing agent recovery failing from unsuccessful `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/#review180564 --- Patch looks great! Reviews applied: [60846] Passed command:

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180566 --- src/messages/flags.proto Lines 56 (patched)

Review Request 60879: Preventing agent recovery failing from unsuccessful `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60879/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/ --- (Updated July 14, 2017, 3:37 p.m.) Review request for mesos, Benjamin Mahler

Review Request 60867: Added method returning allocated resources for executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Re: Review Request 60846: Preventing agent recovery failing from unsuccessful `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/ --- (Updated July 14, 2017, 5:37 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60867: Added method returning allocated resources for executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/#review180536 --- Patch looks great! Reviews applied: [60867] Passed command:

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review180544 --- Patch looks great! Reviews applied: [60867, 60636, 60369, 60539,

Review Request 60888: WIP: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305

Review Request 60891: WIP: Implemented agent API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/ --- Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu. Bugs:

Review Request 60889: WIP: Added tests for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60889/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305

Review Request 60890: WIP: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305

Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/ --- (Updated July 15, 2017, 1:11 a.m.) Review request for mesos, Andrew

Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/ --- (Updated July 15, 2017, 1:13 a.m.) Review request for mesos, Andrew

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60847/#review180620 --- Patch looks great! Reviews applied: [60279, 60716, 60820, 60822,

Re: Review Request 60832: Added concept of an `epoch` to support proper settling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60832/#review180628 --- I'm a little confused, isn't this needed for

Re: Review Request 60891: WIP: Implemented agent API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/#review180629 --- Patch looks great! Reviews applied: [60888, 60889, 60890, 60891]

Review Request 60832: Added concept of an `epoch` to support proper settling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60832/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60830/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 60884: Changes for libprocess Message optimization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60884/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 60829: Replaced std::map with hashmap for ProcessManager::processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60829/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 60871: Added double-checked locking for filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60871/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 60893: Add overloaded operator to Promise.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60893/ --- (Updated July 15, 2017, 1:22 a.m.) Review request for mesos. Repository:

Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/#review180624 --- Ship it! This is a small fix, so I'm going to point out the

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 15, 2017, 1:23 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60877: Improved calculation of resource limits for containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60877/#review180631 --- Patch looks great! Reviews applied: [60867, 60636, 60369, 60539,

Re: Review Request 60884: Changes for libprocess Message optimization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60884/#review180613 --- Bad patch! Reviews applied: [60884, 60871, 60831, 60830, 60829,

Review Request 60831: Removed extra/unnecessary allocations of Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60831/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review180615 --- src/slave/http.cpp Line 1312 (original), 1321 (patched)

Re: Review Request 60846: Retry logic for unsuccessful `docker rm` during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/ --- (Updated July 15, 2017, 12:37 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/#review180621 --- Fix it, then Ship it! Other than style, this patch looks good.

Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/ --- (Updated July 15, 2017, 1:13 a.m.) Review request for mesos, Andrew

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 12, 2017, 1:47 a.m., Jiang Yan Xu wrote: > > src/slave/gc.cpp > > Lines 179 (patched) > > > > > > Better to call `onAny` and then `CHECK` that it's always ready in the > > continuation so the intention is

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 15, 2017, 1:15 a.m.) Review request for mesos, Benjamin Mahler

Review Request 60893: Add overloaded operator to Promise.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60893/ --- Review request for mesos. Repository: mesos Description --- - Help for

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180630 --- Bad review! Reviews applied: [53479] Error: No reviewers

Re: Review Request 60784: Fixed a bug in operator== for DiskInfo::Source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60784/#review180605 --- Patch looks great! Reviews applied: [60784] Passed command:

Re: Review Request 60887: Decoupling `Docker::rm` from `Docker::stop` in agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60887/#review180618 --- Patch looks great! Reviews applied: [60887] Passed command:

Re: Review Request 60884: Changes for libprocess Message optimization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60884/#review180625 --- Ship it! Ship It! - Benjamin Mahler On July 15, 2017, 12:13

Re: Review Request 60831: Removed extra/unnecessary allocations of Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60831/#review180623 --- Fix it, then Ship it! Looks good, it would be nice to tease

Review Request 60887: Decoupling `Docker::rm` from `Docker::stop` in agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60887/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-

Re: Review Request 60829: Replaced std::map with hashmap for ProcessManager::processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60829/#review180616 --- Ship it! Ship It! - Benjamin Mahler On July 15, 2017, 12:13

Re: Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60830/#review180619 --- 3rdparty/libprocess/src/process.cpp Line 3806 (original), 3806

Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-7797

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 15, 2017, 2:31 a.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Any reason we seperate 'mesos' from 'docker'? Can we use the same? The reason that we have 'mesos' and

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 14, 2017, 8:47 a.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Lines 122-123 (patched) > > > > > > No need for pointer? > > > > Just `process::Promise promise;` which is default initialized.

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 15, 2017, 1:20 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60846: Retry logic for unsuccessful `docker rm` during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/#review180627 --- Patch looks great! Reviews applied: [60887, 60846] Passed

Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60539/#review180518 --- src/tests/reservation_endpoints_tests.cpp Lines 1678 (patched)

Re: Review Request 60836: Added IntervalSet to Ranges conversion helper declarations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60836/#review180514 --- src/common/values.cpp Lines 43-44 (patched)