Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review187931 --- Bad patch! Reviews applied: [62548] Failed command: python

Re: Review Request 60467: Fixed race in configureSignal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187927 --- Patch looks great! Reviews applied: [60467] Passed command:

Re: Review Request 62959: Added doc for filesystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62959/#review187928 --- PASS: Mesos patch 62959 was successfully built and tested.

Re: Review Request 62964: Re-organized the documentation table of contents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62964/#review187929 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62965: Added doc for cgroups devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62965/#review187930 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62966: Add a couple libprocess examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62966/#review187933 --- PASS: Mesos patch 62966 was successfully built and tested.

Re: Review Request 62836: Ignored the tasks already being killed when killing the task group.

> On Oct. 12, 2017, 4:10 p.m., Benjamin Bannier wrote: > > Does it makes sense to add a test for this? Yeah, I added a test here: https://reviews.apache.org/r/62837/ - Qian --- This is an automatically generated e-mail. To reply,

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

> On Oct. 12, 2017, 1:37 a.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 65 (patched) > > > > > > Is this `uuid` for RP to acknowledge this `Publish` event? Then

Re: Review Request 62836: Ignored the tasks already being killed when killing the task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62836/#review187752 --- Does it makes sense to add a test for this? - Benjamin Bannier

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrade guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/#review187763 --- FAIL: Some Mesos tests failed. Reviews applied: `['62212',

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review187767 --- src/master/allocator/mesos/hierarchical.cpp Line 1445

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Oct. 12, 2017, 11:20 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review187772 --- Ship it! Ship It! - Andrei Budnik On Oct. 12, 2017, 11:20

Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/ --- Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.

Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/#review187775 --- Could you also adjust the tests? Currently they do not compile.

Re: Review Request 62899: Added protobuf message passing benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/ --- (Updated Oct. 12, 2017, 1:09 p.m.) Review request for mesos and Benjamin

Re: Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/ --- (Updated Oct. 12, 2017, 1:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187789 --- PASS: Mesos patch 62929 was successfully built and tested.

Re: Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/#review187790 --- FAIL: Failed to apply the dependent review: 62898. Failed

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187791 --- include/mesos/mesos.proto Lines 1347 (patched)

Re: Review Request 62900: Enabled protobuf arenas code generation.

> On Oct. 12, 2017, 2:19 a.m., Benjamin Mahler wrote: > > I assume you're only touching the files that use protobuf `install` > > handlers because there's a build speed cost? I just changed minimal set of files required to make it compile with the changes in #62901. I didn't notice any impact

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/ --- (Updated Oct. 12, 2017, 4:01 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187797 --- include/mesos/v1/mesos.proto Lines 1328 (patched)

Re: Review Request 62877: Added RESOURCE_PROVIDER agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62877/#review187799 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 958-966

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Oct. 8, 2017, 4:31 a.m., Andrew Schwartzmeyer wrote: > > src/launcher/fetcher.cpp > > Lines 192-211 (original), 198-208 (patched) > > > > > > What's the point of this entire function now, since we have > >

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

> On Oct. 8, 2017, 2:23 a.m., Andrew Schwartzmeyer wrote: > > What is the reason that the HDFS files are now made to build on Windows, > > but (AFAICT) not actually enabled for support? Is there an immediate plan > > to support HDFS, and if not, why start building the files? HDFS should work,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

> On Oct. 8, 2017, 4:16 a.m., Andrew Schwartzmeyer wrote: > > src/hdfs/hdfs.cpp > > Lines 117-118 (original), 117-118 (patched) > > > > > > I believe that [this > >

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

On Oct. 8, 2017, 3:37 a.m., Jeff Coffler wrote: > > These changes in spirit are fine, but I don't like how the URI conversion > > has to be done at all. It should be as simple as `uri::from_path(input)`. That's exactly what I ultimately did. - Jeff

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

> On Oct. 8, 2017, 3:27 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 28-35 (patched) > > > > > > General note on comment style: Mesos / stout / libprocess uses `//` > > over

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

> On Oct. 8, 2017, 3:33 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 33 (patched) > > > > > > Also, the casing comment applies to the funciton name too, plus the > > double

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/ --- (Updated Oct. 12, 2017, 5:34 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

> On Oct. 12, 2017, 4:53 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 1328 (patched) > > > > > > need the same s/source/volume/ changes for the v1 protos Of course, sorry. Fixed now. -

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Oct. 8, 2017, 2:56 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 16 (patched) > > > > > > What was this included for? My only guess is `WIFEXITED`? Removed,

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187804 --- Ship it! Ship It! - James DeFelice On Oct. 12, 2017, 3:34

Re: Review Request 62878: Sent CheckpointResourcesMessage only when reregister with an old master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62878/#review187803 --- Ship it! Ship It! - Benjamin Bannier On Oct. 11, 2017, 5:27

Re: Review Request 62879: Stopped sending checkpoint resources message on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62879/#review187805 --- Ship it! Ship It! - Benjamin Bannier On Oct. 11, 2017, 5:28

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/#review187781 --- I would much prefer if we'd add another patch before this that

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review187808 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017,

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrade guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/#review187809 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017,

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review187810 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017,

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/ --- (Updated Oct. 12, 2017, 3:57 p.m.) Review request for mesos, Andrei Budnik and

Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8012

Review Request 62939: Document the Linux build requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62939/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

> On Oct. 4, 2017, 9:26 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/open.hpp > > Lines 26 (patched) > > > > > > I believe we should update the minimal Linux kernel requirements in the > >

Re: Review Request 62939: Document the Linux build requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62939/#review187817 --- Fix it, then Ship it! docs/getting-started.md Line 27

Re: Review Request 62939: Document the Linux build requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62939/ --- (Updated Oct. 12, 2017, 5:12 p.m.) Review request for mesos, Andrew

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187824 --- FAIL: Some Mesos tests failed. Reviews applied: `['62929']`

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- (Updated Oct. 12, 2017, 6:06 p.m.) Review request for mesos, Andrew

Review Request 62944: Fixed flaky test SharedPersistentVolumeRescindOnDestroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62944/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8076

Re: Review Request 62944: Fixed flaky test SharedPersistentVolumeRescindOnDestroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62944/#review187830 --- Ship it! Ship It! - Gaston Kleiman On Oct. 12, 2017, 11:34

Re: Review Request 62944: Fixed flaky test SharedPersistentVolumeRescindOnDestroy.

> On Oct. 12, 2017, 11:38 a.m., Gaston Kleiman wrote: > > Ship It! Thx! - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62944/#review187830

Re: Review Request 60467: Fixed race in configureSignal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187847 --- src/slave/posix_signalhandler.hpp Line 37 (original), 38

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review187852 --- FAIL: Some Mesos tests failed. Reviews applied: `['62938']`

Re: Review Request 62939: Document the Linux build requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62939/#review187853 --- FAIL: Failed to apply the dependent review: 62638. Failed

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187869 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2017, 3:34 p.m.,

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187868 --- Patch looks great! Reviews applied: [62929] Passed command:

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review187874 --- FAIL: Some Mesos tests failed. Reviews applied: `['62548']`

Re: Review Request 58071: Updated test helpers to support changed disk types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58071/#review187875 --- can you rebase? - Jie Yu On April 5, 2017, 9:40 a.m., Jan

Re: Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/#review187877 --- Fix it, then Ship it!

Re: Review Request 62899: Added protobuf message passing benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/#review187855 --- 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 583 (patched)

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61675/ --- (Updated Oct. 12, 2017, 4:14 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60467: Fixed race in configureSignal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187890 --- FAIL: Some Mesos tests failed. Reviews applied: `['60467']`

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61675/#review187891 --- Fix it, then Ship it! This is great, thanks!

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61675/#review187894 --- FAIL: Failed to apply the current review. Failed command:

Review Request 62959: Added doc for filesystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62959/ --- Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review187884 --- docs/newbie-guide.md Line 2 (original), 2 (patched)

Re: Review Request 54073: Added Linux Namespaces semantic doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54073/ --- (Updated Oct. 12, 2017, 5:23 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review187907 --- Patch looks great! Reviews applied: [62938] Passed command:

Re: Review Request 54073: Added Linux Namespaces semantic doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54073/#review187906 --- Fix it, then Ship it! docs/containerizer-internals.md Lines

Review Request 62962: Added doc for cgroups/cpu isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62962/ --- Review request for mesos, Gilbert Song, Jie Yu, and James Peach. Repository:

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62962/#review187910 --- Fix it, then Ship it! docs/isolators/cgroups-cpu.md Lines 26

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62962/ --- (Updated Oct. 12, 2017, 5:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

> On Oct. 12, 2017, 5:40 p.m., Jie Yu wrote: > > docs/isolators/cgroups-cpu.md > > Lines 26 (patched) > > > > > > this is a bit confusing. i would refrash that `this mechanism is always > > enabled when you turn on

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

> On Oct. 13, 2017, 12:13 a.m., Vinod Kone wrote: > > docs/newbie-guide.md > > Line 72 (original), 60 (patched) > > > > > > We should probably move everything below this to advanced guide. Good call, will do. -

Re: Review Request 62959: Added doc for filesystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62959/#review187912 --- Fix it, then Ship it! Looks good!

Re: Review Request 62959: Added doc for filesystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62959/#review187917 --- Fix it, then Ship it! docs/isolators/filesystems.md Lines 29

Review Request 62964: Re-organized the documentation table of contents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62964/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 62964: Re-organized the documentation table of contents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62964/#review187920 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2017, 1:16 a.m.,

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

> On Oct. 12, 2017, 4:21 p.m., Gaston Kleiman wrote: > > This is great, thanks! Ah, I missed your comments. Let me submit a separate patch to address them! - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Review Request 62965: Added doc for cgroups devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62965/ --- Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.

Re: Review Request 62965: Added doc for cgroups devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62965/ --- (Updated Oct. 13, 2017, 1:30 a.m.) Review request for mesos, Gilbert Song,

Review Request 62966: Add a couple libprocess examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62966/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description