Re: Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64514/ --- (Updated Dec. 13, 2017, 11:53 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 64381: Mesos: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/ --- (Updated Dec. 13, 2017, 12:07 p.m.) Review request for mesos, Benjamin

Re: Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64514/#review193664 --- Ship it! src/master/master.hpp Lines 784-785 (patched)

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 13, 2017, 12:08 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Dec. 13, 2017, 3:26 p.m.) Review request for mesos and Alexander

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/#review193671 --- Fix it, then Ship it! This implements the same functionality

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review193678 --- FAIL: Some Mesos tests failed. Reviews applied: `['64574']`

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/#review193686 --- FAIL: Some Mesos tests failed. Reviews applied: `['64506',

Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7361

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/ --- (Updated Dec. 13, 2017, 2:49 p.m.) Review request for mesos. Changes ---

Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Re: Review Request 63953: Added logging based on container class.

> On Dec. 8, 2017, 6:05 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/containerizer.hpp > > Line 356 (original), 361-368 (patched) > > > > > > Let's pull this is a separate patch.

Review Request 64576: Refactored if statements to use containerClass().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64576/ --- Review request for mesos. Repository: mesos Description --- Simplifies

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193771 --- Fix it, then Ship it!

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/ --- (Updated Dec. 14, 2017, 1:31 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64587: Printed fatal messages in lambdas where errors happen in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64587/#review193764 --- Ship it! Ship It! - Jie Yu On Dec. 14, 2017, 1:19 a.m.,

Re: Review Request 64584: Add a unit test for pre-existing volume support in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64584/#review193763 --- Ship it! Ship It! - Jie Yu On Dec. 13, 2017, 11:32 p.m.,

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64467/#review193758 --- I would suggest re-phrasing the summary to reflect that this is

Re: Review Request 64583: Supporting pre-existing volumes with no profile in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64583/#review193762 --- Ship it! Ship It! - Jie Yu On Dec. 13, 2017, 11:32 p.m.,

Re: Review Request 64588: Made the agent forward status updates for unknown offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64588/#review193765 --- Fix it, then Ship it! src/slave/slave.cpp Line 7257

Re: Review Request 64589: Fixed a bug related to offer operation application in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64589/#review193769 --- Fix it, then Ship it! src/slave/slave.cpp Line 3847

Re: Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review193768 --- src/slave/slave.cpp Lines 7264-7266 (original), 7264-7266

Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64559/ --- (Updated Dec. 13, 2017, 11:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/ --- (Updated Dec. 14, 2017, 1:18 a.m.) Review request for mesos, Gaston Kleiman,

Review Request 64589: Fixed a bug related to offer operation application in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64589/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/#review193750 --- Ship it! Ship It! - Jie Yu On Dec. 14, 2017, 1:31 a.m.,

Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. Repository:

Review Request 64591: Printed out the source profile and ID for a disk resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64591/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64581/ --- (Updated Dec. 14, 2017, 1:20 a.m.) Review request for mesos, Greg Mann, Jie

Review Request 64587: Printed fatal messages in lambdas where errors happen in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64587/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Review Request 64588: Made the agent forward status updates for unknown offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64588/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. Repository:

Review Request 64593: Disabled `SlaveTest.ResourceProviderPublishAll` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64593/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/ --- (Updated Dec. 13, 2017, 11:55 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in the latest status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64521/#review193747 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64581/#review193755 --- Ship it! Ship It! - Jie Yu On Dec. 14, 2017, 1:20 a.m.,

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/#review193746 --- Fix it, then Ship it!

Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64581/#review193748 --- src/examples/test_csi_plugin.cpp Lines 110 (patched)

Re: Review Request 64556: Made master acknowledge unknown operations during agent reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64556/#review193752 --- src/master/master.cpp Lines 7675-7679 (patched)

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/#review193688 --- FAIL: Some Mesos tests failed. Reviews applied: `['64575']`

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/ --- (Updated Dec. 13, 2017, 4:04 p.m.) Review request for mesos, Alexander

Re: Review Request 64576: Refactored if statements to use containerClass().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64576/#review193694 --- FAIL: Some Mesos tests failed. Reviews applied: `['64575',

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

> On Dec. 13, 2017, 12:20 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Line 502 (original), 502 (patched) > > > > > > Let's not do this in this patch as it is an unrelated change. Instead > > we

Re: Review Request 64536: Removed race from SlaveRecoveryTest.ReconnectExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64536/#review193708 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 12, 2017,

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

> On Dec. 13, 2017, 12:20 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Line 6992 (original) > > > > > > One motivation for such helper functions can be that it becomes clearer > > than

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/ --- (Updated Dec. 13, 2017, 7:26 p.m.) Review request for mesos, Alexander

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/ --- (Updated Dec. 13, 2017, 7:34 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/#review193722 --- Fix it, then Ship it! src/slave/paths.cpp Lines 581-587

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/#review193690 --- src/master/master.cpp Line 3876 (original), 3881 (patched)

Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64581/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos

Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64493/#review193728 --- Fix it, then Ship it! Just some minor suggestions below, I

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

> On Dec. 12, 2017, 5:03 a.m., Benjamin Mahler wrote: > > Can you also describe how it worked before in the description? I think that > > would be helpful for the reader and for posterity. > > Meng Zhu wrote: > Done. Hm.. did you forget to add it? > On Dec. 12, 2017, 5:03 a.m., Benjamin

Re: Review Request 64557: Handled the RP disconnection case in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64557/#review193733 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Dec. 13, 2017, 7:47 p.m.) Review request for mesos and Alexander

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/ --- (Updated Dec. 13, 2017, 7:47 p.m.) Review request for mesos and Alexander

Re: Review Request 64563: Moved a comment to a more relevant location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64563/#review193726 --- Ship it! Ship It! - Benjamin Mahler On Dec. 13, 2017, 2:14

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/ --- (Updated Dec. 13, 2017, 8:20 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/#review193670 --- src/master/master.hpp Line 593 (original), 593 (patched)

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review193742 --- Do we have a good argument for support of trailing slashes in

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

> On Dec. 11, 2017, 9:03 p.m., Benjamin Mahler wrote: > > Can you also describe how it worked before in the description? I think that > > would be helpful for the reader and for posterity. > > Meng Zhu wrote: > Done. > > Benjamin Mahler wrote: > Hm.. did you forget to add it? Line

Review Request 64570: Windows: Temporarily fixed the docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64570/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Review Request 64583: Supporting pre-existing volumes with no profile in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64583/ --- Review request for mesos, James DeFelice and Jie Yu. Repository: mesos

Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64559/#review193744 --- Fix it, then Ship it! LGTM!

Review Request 64584: Add a unit test for pre-existing volume support in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64584/ --- Review request for mesos, James DeFelice and Jie Yu. Repository: mesos