Re: Review Request 64743: Enabled function sections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review194224 --- cmake/CompilationConfigure.cmake Line 262 (original), 262

Re: Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/#review194226 --- Fix it, then Ship it! docs/agent-recovery.md Lines 20-21

Re: Review Request 64069: Ensured command executor always honors shutdown request.

> On Dec. 19, 2017, 3:25 p.m., Andrei Budnik wrote: > > src/launcher/executor.cpp > > Lines 768 (patched) > > > > > > Let's print warning message before terminating: > > ``` > > LOG(WARNING) << "Attempted to

Re: Review Request 64069: Ensured command executor always honors shutdown request.

> On Dec. 18, 2017, 9:40 p.m., Vinod Kone wrote: > > What about the fix for other built-in executors (docker, default)? > > > > Also, this only seems to fix the shutdown path, what about kill task path? > > > > > > Regaring the fix for kill task when a task hasn't been launched from the > >

Re: Review Request 64762: Renamed offer operation to operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64762/#review194309 --- Ship it! Ship It! - Jie Yu On Dec. 21, 2017, 2:25 a.m.,

Re: Review Request 64450: Update docs to mention new flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/ --- (Updated Dec. 20, 2017, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64749/ --- (Updated Dec. 20, 2017, 1:59 p.m.) Review request for mesos, Alexander

Re: Review Request 64750: Fixed an agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64750/#review194250 --- PASS: Mesos patch 64750 was successfully built and tested.

Re: Review Request 64450: Update docs to mention new flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/#review194239 --- Fix it, then Ship it! I'll fix the last outstanding issue and

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 20, 2017, 4:07 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64713: Fixed a crash when resubscribing resource providers.

> On Dec. 19, 2017, 4:28 p.m., Benjamin Bannier wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 1150 (original), 1150 (patched) > > > > > > Let's add a comment here outlining that we start a

Re: Review Request 64713: Fixed a crash when resubscribing resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64713/ --- (Updated Dec. 20, 2017, 2:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64069: Ensured command executor always honors shutdown request.

> On Dec. 15, 2017, 4:48 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp > > Lines 768 (patched) > > > > > > Can you add a test for this? Writing test is tricky: our test harness does not allow to drop

Re: Review Request 64450: Update docs to mention new flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/#review194241 --- PASS: Mesos patch 64450 was successfully built and tested.

Re: Review Request 64450: Update docs to mention new flag.

> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote: > > docs/agent-recovery.md > > Lines 20-22 (original), 21-23 (patched) > > > > > > Why have you killed this paragraph? Maybe somehow combine it with the > >

Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64749/#review194240 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 20, 2017,

Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64749/ --- Review request for mesos, Alexander Rukletsov and Gilbert Song. Repository:

Re: Review Request 64450: Update docs to mention new flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/ --- (Updated Dec. 20, 2017, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- (Updated Dec. 20, 2017, 4:12 p.m.) Review request for mesos, Andrei Budnik,

Review Request 64750: Fixed an agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64750/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 64713: Fixed a crash when resubscribing resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64713/#review194242 --- PASS: Mesos patch 64713 was successfully built and tested.

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review194263 --- PASS: Mesos patch 64033 was successfully built and tested.

Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- (Updated Dec. 20, 2017, 4:27 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- (Updated Dec. 20, 2017, 4:27 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Dec. 20, 2017, 4:27 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64726: Renamed operation protos for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/#review194261 --- include/mesos/mesos.proto Line 2279 (original), 2277 (patched)

Re: Review Request 64750: Fixed an agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64750/#review194254 --- Ship it! Let's add some unit test to capture this regression!

Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/#review194262 --- PASS: Mesos patch 64070 was successfully built and tested.

Re: Review Request 64726: Renamed operation protos for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/#review194268 --- Ship it! Ship It! - Greg Mann On Dec. 20, 2017, 7:21 p.m.,

Re: Review Request 64726: Renamed operation protos for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/#review194271 --- FAIL: mesos-java failed to build. Reviews applied: `['64726']`

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 20, 2017, 8:14 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64032/ --- (Updated Dec. 20, 2017, 8:14 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- (Updated Dec. 20, 2017, 8:16 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Dec. 20, 2017, 8:17 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64726: Renamed operation protos for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/ --- (Updated Dec. 20, 2017, 11:21 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64741/#review194269 --- src/master/http.cpp Lines 4232-4235 (original), 4232-4234

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Dec. 20, 2017, 8:35 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64726: Renamed operation protos for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/#review194266 --- Ship it! Ship It! - Jie Yu On Dec. 20, 2017, 7:21 p.m.,

Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Review Request 64755: Adjusted the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64755/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod

Review Request 64754: Made helper functions of `Bytes` return a double value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64754/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod

Review Request 64756: Fixed a bug that SLRP would fail if the state files do not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64756/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64754: Made helper functions of `Bytes` return a double value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64754/#review194277 --- 3rdparty/stout/include/stout/bytes.hpp Lines 82-85 (original),

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review194273 --- PASS: Mesos patch 64033 was successfully built and tested.

Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review194274 --- src/slave/slave.cpp Line 7428 (original), 7439 (patched)

Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/#review194276 --- FAIL: Failed to apply the dependent review: 64003. Failed

Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64741/#review194280 --- Ship it! Ship It! - Meng Zhu On Dec. 19, 2017, 5:47 p.m.,

Review Request 64760: Fixed a few comment typos in the `hierarchical.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64760/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 64756: Fixed a bug that SLRP would fail if the state files do not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64756/#review194279 --- PASS: Mesos patch 64756 was successfully built and tested.

Re: Review Request 64754: Made helper functions of `Bytes` return a double value.

> On Dec. 20, 2017, 10:25 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/bytes.hpp > > Lines 82-85 (original), 82-85 (patched) > > > > > > I'm not so sure we need these at all, is it possible to remove

Re: Review Request 64760: Fixed a few comment typos in the `hierarchical.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64760/#review194304 --- Ship it! Ship It! - Benjamin Mahler On Dec. 21, 2017, 12:50

Re: Review Request 64754: Removed `kilobytes()`, `megabytes()`, etc from `Bytes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64754/ --- (Updated Dec. 21, 2017, 3:41 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64755/ --- (Updated Dec. 21, 2017, 3:41 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 64763: Fixed compilation for python eggs when gRPC is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64763/ --- Review request for mesos, Jie Yu and Kapil Arya. Repository: mesos

Review Request 64765: Removed a stale TODO in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64765/ --- Review request for mesos, Alexander Rukletsov and Meng Zhu. Repository: mesos

Re: Review Request 64762: Renamed offer operation to operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64762/#review194305 --- PASS: Mesos patch 64762 was successfully built and tested.

Re: Review Request 64765: Removed a stale TODO in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64765/#review194306 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194257 --- PASS: Mesos patch 64069 was successfully built and tested.

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review194275 --- src/master/allocator/mesos/hierarchical.cpp Lines 1681-1684

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review194283 --- Tests look good, do we want to add a test to ensure unchoppable

Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64761/#review194292 --- Fix it, then Ship it! Looks good, modulo stripping the

Review Request 64762: Renamed offer operation to operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64762/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. Repository:

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/#review194206 --- Fix it, then Ship it! src/common/resources_utils.hpp Line 175

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/ --- (Updated Dec. 20, 2017, 6:25 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64761/ --- (Updated Dec. 20, 2017, 6:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 64743: Enabled function sections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review194303 --- PASS: Mesos patch 64743 was successfully built and tested.

Review Request 64761: Moved the quota headroom tracking before quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64761/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7099

Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API.

> On Dec. 20, 2017, 7:52 p.m., Meng Zhu wrote: > > src/master/http.cpp > > Lines 4232-4235 (original), 4232-4234 (patched) > > > > > > how about: > > > > `*getTasks.add_pending_tasks() =

Re: Review Request 64743: Enabled function sections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/ --- (Updated Dec. 21, 2017, 1:47 a.m.) Review request for mesos, Andrew

Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/#review194288 --- Looks good! Rather than "exclusively" how about all-or-nothing

Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64761/#review194294 --- FAIL: Failed to apply the dependent review: 64003. Failed

Re: Review Request 64743: Enabled function sections.

> On Dec. 20, 2017, 10:52 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 267 (patched) > > > > > > What about static archives? Last time I looked this was broken in the > > cmake

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated Dec. 21, 2017, 10:07 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/ --- (Updated Dec. 20, 2017, 6:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review194301 --- Ship it! Ship It! - Benjamin Mahler On Dec. 21, 2017, 2:25

Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/#review194302 --- Ship it! Ship It! - Benjamin Mahler On Dec. 21, 2017, 2:48

Re: Review Request 64763: Fixed compilation for python eggs when gRPC is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64763/#review194307 --- PASS: Mesos patch 64763 was successfully built and tested.