Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review195884 --- support/apply-reviews.py Lines 275 (patched)

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195889 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 20, 2018,

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/#review195919 --- Please add a test in the next review. src/master/master.hpp

Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone.

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195918 --- This test emitted some gmock warnings for me. Could you get rid

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Nov. 30, 2017, 6:33 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Line 318 (original), 391-428 (patched) > > > > > > LGTM though another maintainer may want to take a look.

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/#review195647 --- src/master/master.hpp Lines 2208 (patched)

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/#review195932 --- Ship it! Ship It! - Vinod Kone On Jan. 22, 2018, 1:21 p.m.,

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- (Updated Jan. 22, 2018, 7:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/#review195923 --- Fix it, then Ship it! include/mesos/v1/mesos.proto Line 1310

Re: Review Request 65107: Updated the task state metrics to be more readable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65107/#review195930 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2018, 1:34 a.m.,

Re: Review Request 65108: Added documentation for `protobuf::isTerminalState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65108/#review195931 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2018, 1:34 a.m.,

Re: Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65245/#review195926 --- src/webui/master/static/agent.html Line 45 (original), 45

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review195528 --- src/tests/containerizer/docker_tests.cpp Lines 61-62 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 17, 2018, 10:18 a.m., Benjamin Bannier wrote: > > src/common/protobuf_utils.cpp > > Lines 1288-1290 (patched) > > > > > > Once we have settled where to transport this information we should > > create a

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review195907 --- PASS: Mesos patch 65189 was successfully built and tested.

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/#review195908 --- PASS: Mesos patch 65263 was successfully built and tested.

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review195911 --- Ship it! Ship It! - Armand Grillet On Jan. 22, 2018, 1:58

Review Request 65215: Updated mesos-tidy setup for upgraded Boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65215/ --- Review request for mesos, Benno Evers and Michael Park. Repository: mesos

Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. Bugs:

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review195902 --- PASS: Mesos patch 65261 was successfully built and tested.

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195914 --- include/mesos/agent/agent.proto Lines 72 (patched)

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- (Updated Jan. 22, 2018, 7:51 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195927 --- src/tests/api_tests.cpp Lines 1011-1013 (patched)

Re: Review Request 65253: Fixed dropped events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- (Updated Jan. 22, 2018, 11:36 p.m.) Review request for mesos, Benjamin

Re: Review Request 65255: Updated inverse-offers-framework with authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65255/ --- (Updated Jan. 22, 2018, 11:42 p.m.) Review request for mesos, Alexander

Re: Review Request 65253: Fixed dropped events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/#review195953 --- Ship it! Ship It! - Vinod Kone On Jan. 22, 2018, 11:36

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

> On Jan. 22, 2018, 8:02 p.m., Vinod Kone wrote: > > Thank you for the review! :) > On Jan. 22, 2018, 8:02 p.m., Vinod Kone wrote: > > src/master/master.hpp > > Lines 2208 (patched) > > > > > > can you use

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

> On Jan. 23, 2018, 4:24 a.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > To confirm, would this new test have failed without the fix for > https://issues.apache.org/jira/browse/MESOS-8460 ? Actually no. The root cause of MESOS-8460 is we used a framework pointer after that

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/ --- (Updated Jan. 23, 2018, 12:11 a.m.) Review request for mesos, James Peach,

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/ --- (Updated Jan. 22, 2018, 4:23 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review195956 --- Nice to see both, will wait for update from vinod's review. -

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

> On Jan. 22, 2018, 7:26 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Line 11260 (original), 11292 (patched) > > > > > > So looks like we do make a copy of the event for > >

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- (Updated Jan. 22, 2018, 9:10 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 65273: Added the agent flag --disk_profile_adaptor to agent.md file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65273/#review195944 --- Ship it! Ship It! - Jie Yu On Jan. 22, 2018, 9:55 p.m.,

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/#review195950 --- Fix it, then Ship it! include/mesos/v1/mesos.proto Line 2459

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review195947 --- src/tests/environment.cpp Lines 344-348 (patched)

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/#review195949 --- Fix it, then Ship it! Nice to see performance improvements

Re: Review Request 65274: Fixed --ip6 and --ip6_discovery_command document location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65274/#review195951 --- Ship it! But fix the description since it's a copy of the

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/ --- (Updated Jan. 22, 2018, 3:21 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64386: Refactored health checks to take in executor information.

> On Jan. 22, 2018, 5:27 a.m., Alexander Rukletsov wrote: > > src/checks/checker.hpp > > Lines 69-70 (original), 73-74 (patched) > > > > > > These guys can now be part of `MesosRuntimeInfo` : ) And fix the spelling

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

> On Jan. 22, 2018, 8:24 p.m., Vinod Kone wrote: > > Ship It! To confirm, would this new test have failed without the fix for https://issues.apache.org/jira/browse/MESOS-8460 ? - Vinod --- This is an automatically generated e-mail. To

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195939 --- Ship it! Ship It! - Greg Mann On Jan. 22, 2018, 8:45 p.m.,

Review Request 65274: Fixed --ip6 and --ip6_discovery_command document location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65274/ --- Review request for mesos, Andrew Schwartzmeyer and Avinash sridharan.

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/#review195938 --- 3rdparty/libprocess/Makefile.am Lines 200 (patched)

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/ --- (Updated Jan. 22, 2018, 1:59 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65253: Avoided dropping events on the master operator API stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65253/ --- (Updated Jan. 22, 2018, 8:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/ --- (Updated Jan. 22, 2018, 12:45 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review195696 --- src/logging/flags.hpp Lines 22 (patched)

Review Request 65273: Added the agent flag --disk_profile_adaptor to agent.md file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65273/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195942 --- This patch will likely need a few tweaks based on how the

Review Request 65277: Logged pid of launched containers in the linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65277/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/#review195962 --- Fix it, then Ship it! src/master/master.cpp Lines 10170

Re: Review Request 65277: Logged pid of launched containers in the linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65277/#review195964 --- Why does this need to be in a hook gated by the parent<->child

Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8305

Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65111/#review195969 --- Seems like we need http vs driver based tests, and also need to

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

> On Jan. 23, 2018, 1:29 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10170 (patched) > > > > > > s/Indicated/Indicates/ ? Oh, yeah this isn't my comment but I'll touch it up here since it's been

Review Request 65280: Fixed make clean without Python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65280/ --- Review request for mesos, Benjamin Bannier, Benno Evers, Kapil Arya, and Joseph

Re: Review Request 65215: Updated mesos-tidy setup for upgraded Boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65215/#review195895 --- FAIL: Failed to apply the dependent review: 62161. Failed

Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8462

Re: Review Request 64386: Refactored health checks to take in executor information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/#review195894 --- Akash — good stuff, I like the direction it is going. Let's do

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 22, 2018, 3:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/ --- (Updated Jan. 22, 2018, 2:58 p.m.) Review request for mesos, Armand Grillet