Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202137 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

> On April 30, 2018, 11:38 a.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/stat.hpp > > Lines 186 (patched) > > > > > > the comment should be `x / (10 * 1000 * 1000)` :) > > Andrew

Review Request 66871: Added documentation about new gauge on `master/subscribers_active`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66871/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-6499

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66863/#review202139 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/ --- (Updated April 30, 2018, 2:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/#review202142 --- PASS: Mesos patch 66870 was successfully built and tested.

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review202143 --- Bad patch! Reviews applied: [54987, 54986, 66871, 53267] Failed

Re: Review Request 53330: Tracked layers and pull latency in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated April 30, 2018, 2:23 p.m.) Review request for mesos, Xiaojian Huang,

Review Request 66860: Avoid copying of register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8628

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review202154 --- Fix it, then Ship it! Overall LGTM. src/master/master.cpp

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review202133 --- Fix it, then Ship it!

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202135 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/ --- (Updated April 30, 2018, 2:09 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/ --- (Updated April 30, 2018, 3:36 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated April 30, 2018, 3:35 p.m.) Review request for mesos, Xiaojian Huang,

Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Repository:

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review202146 --- FAIL: Failed to apply the dependent review: 53267. Failed

Re: Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65852/#review202149 --- Ship it! Ship It! - Meng Zhu On Feb. 28, 2018, 6:31 p.m.,

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/#review202136 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22

Re: Review Request 54986: Added metric for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/ --- (Updated April 30, 2018, 2:08 p.m.) Review request for mesos, Eric Chung,

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

> On April 30, 2018, 1:18 p.m., Akash Gupta wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Line 234 (original), 233 (patched) > > > > > > I think the first half of this test could be out of the

Review Request 66872: Updated FrameworkInfo comparator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review202147 --- Fix it, then Ship it!

Re: Review Request 53330: Tracked layers and pull latency in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review202153 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66292: Validated that all tasks in the same group have same max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66292/ --- (Updated April 30, 2018, 3:51 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202180 --- src/tests/persistent_volume_tests.cpp Lines 788 (patched)

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/#review202181 --- PASS: Mesos patch 66881 was successfully built and tested.

Re: Review Request 66811: Added `libacl` as a dependency of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/ --- (Updated May 1, 2018, 10:23 a.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 66812: Added `libacl` as a dependency of Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66812/ --- (Updated May 1, 2018, 10:25 a.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 66811: Added `libacl` as a dependency of stout.

> On April 27, 2018, 6:04 p.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 288 (patched) > > > > > > This file should not be committed together with the changes to stout > > (project split). > >

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review202138 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:17

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated April 30, 2018, 1:52 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 53267: Added a gauge to track active subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/ --- (Updated April 30, 2018, 1:53 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 54986: Added metric for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/ --- (Updated April 30, 2018, 2:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/ --- (Updated April 30, 2018, 1:44 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

> On April 30, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 1785 (patched) > > > > > > `()` can be removed. Oh yeah, I often forget about this, I took them out. I

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66863/ --- (Updated April 30, 2018, 11:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 66283: Added support of `max_completion_time` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/#review202152 --- Fix it, then Ship it! src/docker/executor.cpp Lines 418

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202157 --- Fix it, then Ship it! Overall LGTM. Thanks for your hard work!

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/#review202155 --- Fix it, then Ship it!

Re: Review Request 66291: Added support to `max_completion_time` in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/#review202156 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 66259: Added `max_completion_time` support to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66259/#review202150 --- Fix it, then Ship it! src/launcher/executor.cpp Lines 1052

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/ --- (Updated April 30, 2018, 4:32 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 66874: Added per-framework metrics for active task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66874/#review202161 --- PASS: Mesos patch 66874 was successfully built and tested.

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66863/#review202162 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 66860: Avoid copying of register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/#review202165 --- PASS: Mesos patch 66860 was successfully built and tested.

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review202176 --- FAIL: Failed to apply the dependent review: 53267. Failed

Re: Review Request 66860: Avoid copying of register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/#review202179 --- src/master/master.cpp Line 2488 (original), 2489 (patched)

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202183 --- src/tests/persistent_volume_tests.cpp Lines 823 (patched)

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66863/#review202185 --- PASS: Mesos patch 66863 was successfully built and tested. All

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review202170 --- src/tests/authorization_tests.cpp Lines 1980 (patched)

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202160 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path.

> On April 30, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 1785 (patched) > > > > > > `()` can be removed. > > Benjamin Mahler wrote: > Oh yeah, I often forget

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review202178 --- Bad patch! Reviews applied: [66875, 53105, 54987, 54986, 66871,

Re: Review Request 66883: Added/updated tests to check per framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66883/#review202189 --- PASS: Mesos patch 66883 was successfully built and tested.

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review202123 --- Patch looks great! Reviews applied: [66683] Passed command:

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/#review202128 --- Fix it, then Ship it!

Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review202129 --- Ship it! Ship It! - Akash Gupta On April 16, 2018, 8:24

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202132 --- Fix it, then Ship it!

Re: Review Request 66821: Added framwork metrics helper normalize() and getPrefix().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66821/ --- (Updated April 30, 2018, 11:41 a.m.) Review request for mesos, Benjamin

Review Request 66868: Used `operator->` instead of `get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66868/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 66868: Used `operator->` instead of `get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66868/#review202113 --- Ship it! Ship It! - Armand Grillet On April 30, 2018, 9:14

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated April 30, 2018, 11:45 a.m.) Review request for mesos, Benjamin

Re: Review Request 66842: Added counter metrics for offer filter durations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66842/ --- (Updated April 30, 2018, 6:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66868: Used `operator->` instead of `get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66868/#review202114 --- PASS: Mesos patch 66868 was successfully built and tested.

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review202115 --- PASS: Mesos patch 66683 was successfully built and tested.

Re: Review Request 66868: Used `operator->` instead of `get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66868/#review202116 --- Patch looks great! Reviews applied: [66868] Passed command: