---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204492
---
Patch looks great!
Reviews applied: [67502, 67503, 67504, 67505]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
---
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
---
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
---
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67501/#review204483
---
PASS: Mesos patch 67501 was successfully built and tested.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67501/#review204484
---
Patch looks great!
Reviews applied: [67501]
Passed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204485
---
PASS: Mesos patch 67505 was successfully built and tested.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204480
---
Patch looks great!
Reviews applied: [67164, 67190, 67191, 67154,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67157/#review204481
---
Ship it!
Ship It!
- Benjamin Bannier
On June 8, 2018, 3:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67501/
---
Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67335/#review204494
---
I tried to apply it to ship it and get it out of my inbox ;) but:
> On June 4, 2018, 4:53 p.m., Joseph Wu wrote:
> > General note on code organization:
> >
> > Since you are splitting the `io::internal::read/write` functions into Posix
> > and Windows implementations, it would be helpful to organize the code like:
> > ```
> > 3rdparty/libprocess/src/
> > |--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/#review204496
---
Fix it, then Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204495
---
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/#review204497
---
src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 1801
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67387/#review204499
---
Ship it!
Ship It!
- Andrew Schwartzmeyer
On May 30, 2018,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67386/#review204498
---
Fix it, then Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67391/#review204504
---
3rdparty/libprocess/include/process/io.hpp
Lines 29-39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204507
---
Fix it, then Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204509
---
PASS: Mesos patch 67223 was successfully built and tested.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67286/#review204521
---
Fix it, then Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review204522
---
Ship it!
Ship It!
- Akash Gupta
On May 24, 2018, 10:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67393/#review204506
---
Fix it, then Ship it!
:D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204523
---
src/tests/containerizer/launcher.hpp
Line 60 (original), 60
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67390/#review204503
---
3rdparty/libprocess/src/libwinio_eventloop.cpp
Lines 52-73
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67392/#review204505
---
Ship it!
Ship It!
- Andrew Schwartzmeyer
On May 30, 2018,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67389/#review204501
---
3rdparty/libprocess/src/libwinio_impl.cpp
Lines 53-59 (patched)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
---
(Updated June 8, 2018, 10:04 p.m.)
Review request for mesos, Benjamin Bannier,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67465/#review204502
---
Ship it!
Ship It!
- Akash Gupta
On June 7, 2018, 9:59 p.m.,
30 matches
Mail list logo