Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

2018-06-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review204492 --- Patch looks great! Reviews applied: [67502, 67503, 67504, 67505]

Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

2018-06-08 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Review Request 67504: Added helper for posting the result of a build

2018-06-08 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Review Request 67502: Refactored API functionality into separate module

2018-06-08 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Review Request 67503: Added helper for fetching review id

2018-06-08 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 67501: Added authorization for resource provider operations.

2018-06-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review204483 --- PASS: Mesos patch 67501 was successfully built and tested.

Re: Review Request 67501: Added authorization for resource provider operations.

2018-06-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review204484 --- Patch looks great! Reviews applied: [67501] Passed command:

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

2018-06-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review204485 --- PASS: Mesos patch 67505 was successfully built and tested.

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review204480 --- Patch looks great! Reviews applied: [67164, 67190, 67191, 67154,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

2018-06-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review204481 --- Ship it! Ship It! - Benjamin Bannier On June 8, 2018, 3:21

Review Request 67501: Added authorization for resource provider operations.

2018-06-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs:

Re: Review Request 67335: Added `windows/cpu` and `windows/mem` isolators into `agent.md`.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67335/#review204494 --- I tried to apply it to ship it and get it out of my inbox ;) but:

Re: Review Request 67388: Moved: `io::internal::read/write` to separate file.

2018-06-08 Thread Andrew Schwartzmeyer
> On June 4, 2018, 4:53 p.m., Joseph Wu wrote: > > General note on code organization: > > > > Since you are splitting the `io::internal::read/write` functions into Posix > > and Windows implementations, it would be helpful to organize the code like: > > ``` > > 3rdparty/libprocess/src/ > > |--

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67384/#review204496 --- Fix it, then Ship it!

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/#review204495 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

2018-06-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67358/#review204497 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 1801

Re: Review Request 67387: Updated Mesos code to use `io::prepare_async`.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67387/#review204499 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 30, 2018,

Re: Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67386/#review204498 --- Fix it, then Ship it!

Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67391/#review204504 --- 3rdparty/libprocess/include/process/io.hpp Lines 29-39

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204507 --- Fix it, then Ship it!

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review204509 --- PASS: Mesos patch 67223 was successfully built and tested.

Re: Review Request 67286: White list fds that child processes can inherit in stout.

2018-06-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/#review204521 --- Fix it, then Ship it!

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

2018-06-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/#review204522 --- Ship it! Ship It! - Akash Gupta On May 24, 2018, 10:47

Re: Review Request 67393: Windows: Ported io_tests.cpp.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67393/#review204506 --- Fix it, then Ship it! :D

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

2018-06-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204523 --- src/tests/containerizer/launcher.hpp Line 60 (original), 60

Re: Review Request 67390: Windows: Integrated libwinio with libprocess code.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67390/#review204503 --- 3rdparty/libprocess/src/libwinio_eventloop.cpp Lines 52-73

Re: Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67392/#review204505 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 30, 2018,

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/#review204501 --- 3rdparty/libprocess/src/libwinio_impl.cpp Lines 53-59 (patched)

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/ --- (Updated June 8, 2018, 10:04 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used.

2018-06-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67465/#review204502 --- Ship it! Ship It! - Akash Gupta On June 7, 2018, 9:59 p.m.,