Re: Review Request 68203: Updated volume isolators to honor volume mode.

> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 318 (patched) > > > > > > I'd suggest we separate this patch, and have one patch for each > >

Re: Review Request 68203: Updated volume isolators to honor volume mode.

> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 318 (patched) > > > > > > I'd suggest we separate this patch, and have one patch for each > >

Review Request 68216: Updated `volume/image` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68216/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68214/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68215: Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68215/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68218/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68212/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68220/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68221/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 68242: Added tests for `Resources` move semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68242/#review206912 --- src/tests/resources_tests.cpp Lines 800 (patched)

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206913 --- Fix it, then Ship it! Much appreciated Greg! Looks like there

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review206915 --- src/master/allocator/mesos/hierarchical.cpp Lines 807-815

Re: Review Request 68239: Updated port mapper CNI test.

> On Aug. 6, 2018, 10:35 p.m., Chun-Hung Hsiao wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1957-1958 (original), 1990-1996 (patched) > > > > > > This test waits for all `TASK_RUNNING` before

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/ --- (Updated Aug. 6, 2018, 8:30 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- (Updated Aug. 6, 2018, 8:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206907 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 1799

Re: Review Request 67503: Added support helper for fetching review ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/#review206382 --- Fix it, then Ship it! LGTM except the first line. FYI the

Re: Review Request 68197: Added move support for `class Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/#review206910 --- Fix it, then Ship it! Looks good! Just a note below about the

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

> On Aug. 1, 2018, 8:40 p.m., James Peach wrote: > > I don't have a good sense of whether this is going to fix the underlying > > problem, but making it a config option is definitely a benefit and the code > > looks fine. I'm also puzzled about how making something configurable will fix this

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

> On Aug. 6, 2018, 8:40 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 382 (patched) > > > > > > If `iptables` prints something

Review Request 68244: Propagated the verbose build option to bundled components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68244/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Repository:

Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68095/#review206906 --- Issues spotted while doing some manual testing:

Re: Review Request 68242: Added tests for `Resources` move semantics.

> On Aug. 6, 2018, 2:27 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp > > Line 1069 (original), 1136 (patched) > > > > > > Is it possible to instead augment any existing tests of addition (e.g. >

Re: Review Request 68242: Added tests for `Resources` move semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68242/ --- (Updated Aug. 6, 2018, 4:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- (Updated Aug. 6, 2018, 11:42 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/ --- (Updated Aug. 6, 2018, 11:42 p.m.) Review request for mesos, Avinash

Re: Review Request 68243: Updated Git repository URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68243/#review206900 --- Ship it! Ship It! - James Peach On Aug. 6, 2018, 7 p.m.,

Re: Review Request 68197: Added move support for `class Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/ --- (Updated Aug. 6, 2018, 4:15 p.m.) Review request for mesos and Benjamin

Re: Review Request 68238: Fixed `mesos-style.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68238/#review206902 --- Ship it! Ship It! - Armand Grillet On Aug. 6, 2018, 6:10

Re: Review Request 67504: Added support script to post build results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review206905 --- support/python3/post-build-result.py Lines 1 (patched)

Re: Review Request 68239: Updated port mapper CNI test.

> On Aug. 6, 2018, 10:35 p.m., Chun-Hung Hsiao wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1799 (patched) > > > > > > What's the reason of doing a pre-test cleanup first? To prevent > >

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206920 --- Fix it, then Ship it!

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206903 ---

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206904 --- Fix it, then Ship it!

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review206908 --- support/python3/common.py Lines 146 (patched)

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review206909 --- Fix it, then Ship it! support/python3/verify-reviews.py Lines

Re: Review Request 68248: Added futhre move support for `Resources` addition operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68248/#review206930 --- PASS: Mesos patch 68248 was successfully built and tested.

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review206922 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68175/#review206921 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68197: Added move support for `class Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/#review206925 --- src/common/resources.cpp Lines 2046-2051 (patched)

Re: Review Request 68242: Added tests for `Resources` move semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68242/#review206926 --- PASS: Mesos patch 68242 was successfully built and tested.

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206928 --- PASS: Mesos patch 68239 was successfully built and tested. All

Re: Review Request 68244: Propagated the verbose build option to bundled components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68244/#review206927 --- PASS: Mesos patch 68244 was successfully built and tested.

Review Request 68248: Added futhre move support for `Resources` addition operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68248/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9110

Re: Review Request 68242: Added tests for `Resources` move semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68242/#review206923 --- Ship it! src/tests/resources_tests.cpp Lines 1081-1083

Review Request 68250: Pass compiler/linker flags when building the gRPC bundle in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68250/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9137

Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68251/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9137

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/ --- (Updated Aug. 6, 2018, 1:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67844/ --- (Updated Aug. 6, 2018, 1:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68018: Added `SeccompFilter` class. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Andrew

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68020: Added new `--seccomp_config_dir` flag to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68020/ --- (Updated Aug. 6, 2018, 1:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/ --- (Updated Aug. 6, 2018, 1:39 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68229: Removed unused local variable in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68229/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review206793 --- LGTM, I suggest merging this after the Python 3 update of

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68229/#review206882 --- Ship it! Ship It! - Alexander Rojas On Aug. 6, 2018, 4:14

Review Request 68227: Updated git repository url.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68227/ --- Review request for mesos. Repository: mesos Description --- With the

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review206877 --- Fix it, then Ship it! src/tests/master_benchmarks.cpp Lines

Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 6, 2018, 10:30 a.m.) Review request for mesos, Benno Evers and

Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206876 --- Ship it! Ship It! - Benno Evers On Aug. 6, 2018, 10:30

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review206875 --- 3rdparty/libprocess/include/process/statistics.hpp Lines 60

Re: Review Request 68227: Updated git repository url.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68227/#review206873 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 6, 2018,

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 12:42 a.m., Benjamin Mahler wrote: > > A couple of comments on the benchmark information before looking at the > > code, these probably belong on the previous review, but since the numbers > > are only shown in this one I'll leave these here: > > > > * Can we compare

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 6, 2018, 10:30 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206891 --- Ship it! 3rdparty/libprocess/include/process/statistics.hpp

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206892 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 6, 2018, 4:52

Review Request 68238: Fixed `mesos-style.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68238/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206895 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 2002

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/ --- (Updated Aug. 6, 2018, 4:52 p.m.) Review request for mesos, Avinash sridharan,

Review Request 68239: Updated port mapper CNI test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 68016: Added libseccomp to the build.

> On July 31, 2018, 12:33 a.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 538-541 (patched) > > > > > > What targets need `ENABLE_SECCOMP_ISOLATOR` defined? Presumably this is > >

Re: Review Request 68197: Added move support for `class Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/ --- (Updated Aug. 6, 2018, 9:48 a.m.) Review request for mesos and Benjamin

[GitHub] jieyu closed pull request #306: Fixed the iptables deadlock in CNI port mapper plugin.

jieyu closed pull request #306: Fixed the iptables deadlock in CNI port mapper plugin. URL: https://github.com/apache/mesos/pull/306 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jieyu commented on issue #306: Fixed the iptables deadlock in CNI port mapper plugin.

jieyu commented on issue #306: Fixed the iptables deadlock in CNI port mapper plugin. URL: https://github.com/apache/mesos/pull/306#issuecomment-410775862 Closed this as the review has been moved to reviewboard. This is an

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206887 --- Ship it! Ship It! - Deepak Goel On Aug. 6, 2018, 4:52 p.m.,

Review Request 68243: Updated Git repository URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68243/ --- Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. Repository:

Review Request 68242: Added tests for `Resources` move semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68242/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9110