Re: Review Request 69713: Fixed a bug in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69713/#review211873 --- Ship it! Ship It! - Qian Zhang On Jan. 11, 2019, 1:34 p.m.,

Re: Review Request 69716: Updated `SlaveRecoveryTest.Reboot` to expect none pids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69716/ --- (Updated Jan. 11, 2019, 4 p.m.) Review request for mesos, Andrei Budnik,

Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69717/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone. Bugs:

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 10, 2019, 11:41 p.m., Vinod Kone wrote: > > Can you write a unit test for this by spoofing the reboot? Here it is: https://reviews.apache.org/r/69717/ - Qian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211871 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 2612-2613

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211868 --- Ship it! Ship It! - Qian Zhang On Jan. 11, 2019, 1:08 p.m.,

Re: Review Request 69714: Fixed a bug in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69714/#review211874 --- Ship it! Ship It! - Qian Zhang On Jan. 11, 2019, 2:14 p.m.,

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211867 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69717/#review211872 --- PASS: Mesos patch 69717 was successfully built and tested.

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211869 --- src/tests/containerizer/cni_isolator_tests.cpp Line 138

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69711/#review211870 --- Ship it! Ship It! - Qian Zhang On Jan. 11, 2019, 1:13 p.m.,

Review Request 69718: Avoided copying some `Owned` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69718/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/ --- Review request for mesos, Chun-Hung Hsiao and James DeFelice. Bugs: MESOS-9223

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211878 --- PASS: Mesos patch 69719 was successfully built and tested.

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211875 ---

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review211880 --- PASS: Mesos patch 69721 was successfully built and tested.

Re: Review Request 69718: Avoided copying some `Owned` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69718/#review211877 --- PASS: Mesos patch 69718 was successfully built and tested.

Re: Review Request 69718: Avoided copying some `Owned` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69718/ --- (Updated Jan. 11, 2019, 11:17 a.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 69718: Avoided copying some `Owned` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69718/#review211876 --- Fix it, then Ship it!

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

> On Jan. 11, 2019, 8:50 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Should we call `ContainerizerTest::SetUp()` instead? Good

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 3:54 p.m., Andrei Budnik wrote: > > src/slave/state.cpp > > Lines 493-500 (patched) > > > > > > All tests (including a new one) are passed after removing this code. > > Maybe we don't need to

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

> On Jan. 11, 2019, 9:53 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 72-77 (original), 72 (patched) > > > > > > I think we still need

Re: Review Request 69712: Added a CNI reboot test.

> On Jan. 11, 2019, 9:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 2612-2613 (patched) > > > > > > `%s` is the total size, should we check the device ID instead? err,

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/ --- (Updated Jan. 11, 2019, 6:09 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/ --- (Updated Jan. 11, 2019, 6:10 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69711/ --- (Updated Jan. 11, 2019, 6:09 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- (Updated Jan. 11, 2019, 6:09 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 11, 2019, 6:08 p.m.) Review request for mesos, Gastón Kleiman

Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5189

Review Request 69720: Made `SSLTest` an unparameterized test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5189

Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69717/#review211884 --- Ship it! Ship It! - Andrei Budnik On Jan. 11, 2019, 8:01

Re: Review Request 69716: Updated `SlaveRecoveryTest.Reboot` to expect none pids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69716/#review211885 --- Ship it! Ship It! - Andrei Budnik On Jan. 11, 2019, 8 a.m.,

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

> On Jan. 10, 2019, 8:53 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 8954 (original), 8982-8984 (patched) > > > > > > Nit: fits on one line. I'm curious, do we have an (informal) guideline that says

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/ --- (Updated Jan. 11, 2019, 2:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211888 --- src/slave/state.cpp Lines 493-500 (patched)

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/#review211889 --- PASS: Mesos patch 69669 was successfully built and tested.

Review Request 69723: WIP: Operation feedback on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69723/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211900 --- PASS: Mesos patch 69708 was successfully built and tested.

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211898 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 6:49

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211902 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 6:52

Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69717/#review211904 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/ --- (Updated Jan. 11, 2019, 6:49 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211899 --- PASS: Mesos patch 69715 was successfully built and tested.

Re: Review Request 69716: Updated `SlaveRecoveryTest.Reboot` to expect none pids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69716/#review211903 --- Ship it! Ship It! - Gilbert Song On Jan. 11, 2019,

Re: Review Request 69723: WIP: Operation feedback on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69723/#review211905 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211908 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 6:10

Review Request 69724: Updated configuration documentation to include random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69724/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 69724: Updated configuration documentation to include random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69724/#review211907 --- Ship it! Ship It! - Benjamin Mahler On Jan. 11, 2019, 9:48

Review Request 69725: Added missing `libssl-dev` to the generated Ubuntu 16.04 image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69725/ --- Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 69725: Added missing `libssl-dev` to the generated Ubuntu 16.04 image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69725/#review211909 --- Ship it! Ship It! - Gastón Kleiman On Jan. 11, 2019, 2

Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Repository: mesos

Re: Review Request 69728: Invoked base test `SetUp` and `TearDown` methods in derived tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69728/#review211915 --- Ship it! Ship It! - Gilbert Song On Jan. 11, 2019, 3:17

Re: Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/#review211916 --- Ship it! Ship It! - Gastón Kleiman On Jan. 11, 2019, 2:46

Re: Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211921 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 11:21

Review Request 69729: Removed unused class fields in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69729/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 69581: Fixed an interleaving bug on the master actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69581/#review211913 --- src/master/master.cpp Line 11315 (original), 11315 (patched)

Re: Review Request 69581: Fixed an interleaving bug on the master actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69581/#review211912 --- Ran into an issue with this patch when testing - looks like we

Review Request 69728: Invoked base test `SetUp` and `TearDown` methods in derived tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69728/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Repository: mesos

Re: Review Request 69728: Invoked base test `SetUp` and `TearDown` methods in derived tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69728/#review211917 --- Ship it! Ship It! - Jie Yu On Jan. 11, 2019, 11:17 p.m.,

Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/ --- Review request for mesos, Deepak Goel and Gilbert Song. Bugs: MESOS-9518

Re: Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211919 --- Very interesting. I did not find a kernel doc mentioned this

Re: Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211918 --- Ship it! Ship It! - Gilbert Song On Jan. 11, 2019, 3:21

Re: Review Request 69724: Updated configuration documentation to include random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69724/#review211920 --- PASS: Mesos patch 69724 was successfully built and tested.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211922 --- This looks good to me, but I am not a cmake expert. It would be

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 12, 2019, 12:27 a.m.) Review request for mesos, Benjamin

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211924 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211925 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/#review211931 --- PASS: Mesos patch 69726 was successfully built and tested.

Re: Review Request 69729: Removed unused class fields in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69729/#review211932 --- Ship it! Seems useful to add a bit of context to the

Re: Review Request 69729: Removed unused class fields in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69729/#review211933 --- PASS: Mesos patch 69729 was successfully built and tested.